From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4A37C624A4 for ; Thu, 3 Sep 2026 08:59:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=V1QGsX6n7s/Q58nwjzCnUIFO1aaMfaPkZ14gV28tNtM=; b=JHFS1aHL+9yjeauo9lXtvMEw9F 6vk+XvA+qUodsprxWznxC865f3k3GsUk0PlFr3G4mMwLcLlQ53ue67sClM244D18h4qyMC5JhxJo0 IJ3z54aML6V5G2jL1IPMGrh3SAsQw4B8tuhkfZHzQS3tqoC3w0pFPRBWpUX6WSffZ/RaFb5u/athy MWJVa+eg9gxDG5O7UN/7xcc3HQMWJtOpdmjfGtWy+w2bY1foG8HXQxC12wJpfNUxsZtrn52DmmV0v IY19rBRZRkN/KHuxjdEG3f28gv/mN2y/eDQCKPD4udLkGIvQoxpx6ojdJW4goKZTfMoSrYTB5mAHw 3P1FRzAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x23Hs-0000000Grq2-2ZTC; Thu, 03 Sep 2026 08:59:12 +0000 Received: from smtpout-02.galae.net ([185.246.84.56]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x23Hq-0000000Grol-1Fso; Thu, 03 Sep 2026 08:59:11 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 227C41A18F9; Thu, 3 Sep 2026 08:59:07 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id E519A602B8; Thu, 3 Sep 2026 08:59:06 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id CDB7D11C79B6F; Thu, 3 Sep 2026 10:58:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1788425945; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=V1QGsX6n7s/Q58nwjzCnUIFO1aaMfaPkZ14gV28tNtM=; b=q1GHvmMjv4Wa6DSVg0LmjGGBrxi4LPtvTp4UyOe4G6EegU/mLn1n5mIKxBVj6oLhjuXXWU v/dAmFaKftte7CBAZkrOfBE70aMZNpgU8kEJEfTHIRqLcbSttVx0gPuxMJk/dpGgpHV7oZ e7bLnyBn9DkvQ0okpSO14YyQOyBWGlK4A6zKDhbd2cLlmqPPD93NU8qmKGBWYiUwwSURKK uLYpBw+hl1d4Ly8fJ9LCB8ItREG2ebAvNOdHJF3niAAbjbf/3SQEUPejTorP3sL6soehQi I2vTd3bUZKcctPRCFR8/zJIX8Oo67eTENP3LmZVNWu5C4z0UHQhF2ZKBSNwepQ== Message-ID: <7d0e6b70-b474-44d9-bf57-6079b8d9651e@bootlin.com> Date: Thu, 3 Sep 2026 10:58:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3 01/10] net: stmmac: move XPCS lifetime management to platform drivers To: Coia Prant Cc: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Vinod Koul , Maxime Coquelin , Alexandre Torgue , Lad Prabhakar , Romain Gantois , Heiner Kallweit , Neil Armstrong , Russell King , Shawn Lin , David Heidelberg , netdev@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-renesas-soc@vger.kernel.org References: <20260901150111.141037-1-coiaprant@gmail.com> <20260901150111.141037-2-coiaprant@gmail.com> <0dec5462-f6d5-4ef9-9d02-5fdf7f3090a0@bootlin.com> Content-Language: en-US From: Maxime Chevallier In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260903_015910_468969_E1CC0979 X-CRM114-Status: GOOD ( 17.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/3/26 10:51, Coia Prant wrote: > Maxime Chevallier 于2026年9月3日周四 16:32写道： >> >> Hi again, >> >> Sorry I had a second look at that after a good night's sleep, and actually here >> we may regress. The original logic checked for "pcs-handle" presence, then >> for the pcs mask, but if no PCS is found we didn't error out, we returned 0. >> >> This is making it mandatory to have a PCS. Please handle gracefully the "there's no >> PCS" case :( >> >> >> Maxime > > Hi, > > This change covers all callbacks that use `select_pcs`. Drivers > without `select_pcs` callbacks will not have their pcs used by > Phylink. > > Currently, only the Intel mgbe driver uses xpcs, and Intel has also > set a mask for pcs-handle not set. > > This means that on Intel platforms, the parts that implement > `select_pcs` always require xpcs to exist. > > I think there shouldn't be any problems here, but I agree with you, > regression issues can indeed easily occur here. Alight, let's keep it this way. The assumption becomes "if you have a pcs_init() callback, it means you expect a PCS to be there, ENODEV is an actual error". My reviewed-by still stands then. Maxime