From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CBE88C4332F for ; Thu, 20 Oct 2022 07:25:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S6TWLtenMoF4j5yHrcpUmYMx/8KBlRbxnu4ruTgNmKI=; b=05n2yr6yHQTDlO A8sc3B4K+XTBmtYfZRsVkBmdGmDk5nFurUFi+QiJAnTXF+ki/1IY1jyzGJVlaW2vyO9QrZAYX3zvo 2nUyxen3u2F3tT7kfO7IVJYCgZ88ztOUpEgQSEMIl1HGkTx4WLD6eicduRBtG0w8LSMQ7T3KDEXEn x0fCFP1aMw1KRdlQgqxUKNzPrhF86+U558uNrBjje4a0P1L7dxTtnTFHHUNQkBNMymUWYGj0CZ/a4 K5/vBQbr0WzWX59ntcV/CIW3DExjzVE4GtVUG836Gaann78+opRnL7FwwbQkQA2XWj/Mh+f1mKGMU JsRHHDY9n3FkP20V8kmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olPuZ-00BcQ5-SH; Thu, 20 Oct 2022 07:24:16 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olPuW-00BcL7-I0 for linux-arm-kernel@lists.infradead.org; Thu, 20 Oct 2022 07:24:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1666250653; x=1697786653; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=lcY+6lhKWoFMKuE0EiNm+GRDj3bSrWO5DJ7mfWHiZPM=; b=l6Zff11PsDBjrJ6G8fs+U/4gnk2dqN6iTvCWYabADn5L3G0OABjtjX9I 0IDIvWTkIeq5C2sJsKQwGNoBPCLY+gah0y76sSOj1k+Su47CrAeeM5Ud7 gGfh4+4P6Ydu9hCMLHg2uuju6sT9jMe/Eqe8b1r2niDYdhaZSKrRVxI+2 DCLC5Ua9z/cIV0xDxDprlxic4365suEBQf9F/sZ+F8l0nQFW+E3P8mFFA WGfc3wrOJ8BokWpd51Kj7rmoQl5bnJgGM3B9KZkwd9EOPUrq++4cc8Qee pzT1B27rTRhVMh1m1cbRx0gqD6FR4Ftmyf5A+ps0Zzw61kG3PdMSeVscI g==; X-IronPort-AV: E=Sophos;i="5.95,198,1661842800"; d="scan'208";a="179693769" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 20 Oct 2022 00:24:11 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Thu, 20 Oct 2022 00:24:08 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12 via Frontend Transport; Thu, 20 Oct 2022 00:24:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pqs0rav3yxaI2U77pfZTd0pdSFwyT6THp4FZ6GslMCbuRCFtFs/1tvxoi8MhInsGBf2cQg41pzghIBog20u4nbO41fnAFVvanbwXrEozbfS/ApEmAME8bBgicOsG7fuYjx5Fk1nXQIv2pnYc66YE2ksB0pUlwSmA8ViP/nHquhHeMqaJ7hzAGqN/IApmDxijXTaLgETaJ5lKCeRyM3qGyiD9Q6VIOa/tcBdUXgv8Y/+5YaBRfp87rsBcgAeokl+G2jg20+bwaJ4DGKHHSPecoXFDpjCUZ8d+8b5xLlweeT6L5ZVVf3j+3cHNVsfnIkug249JDZihTFSvQRcKn6PlNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lcY+6lhKWoFMKuE0EiNm+GRDj3bSrWO5DJ7mfWHiZPM=; b=aivfPfMi2Qk5NOumaJHdktlJcS/uYmnb/efn8kIJ6aFhYtc/AYSqaXCoI9WD9tyci+3H/wJMCLOcybNISRx8M5I2T16hT4knhKJLrIz43luOnpxLXZx4dhVQoZsdVvHIE/roT5JzIUnE/kpnyKJAPGxDHNuO63Ohhu5tw5oPXEZKqmJlx/F7GPcO+GSQaFpq8qqu241+pMMBvYp6cCQBTXjQbyJ0khRfMvZKUi+KtjJwTCBugP827CR6kA5A5c+stJwCs+8LKVPumcWADlwDGzr85Ec0JEdq1eaws5fIYwQgkEzQba/ojLAj1k3Lhs4QkwGMV/uWg+jK9dT2zr+1vA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lcY+6lhKWoFMKuE0EiNm+GRDj3bSrWO5DJ7mfWHiZPM=; b=hMYF/e+EDUoSZ2csCbOyPPOq/7gQUSMicraud586R0NsWU90WCplwyRYuqRqT1iiXWeCp+MLNEEreGAkuCtew1JLYVkOCf+dfDLQywJHO5yaWEdOmLot+rSbB8kfkG9B+owuZc3Ev5kX8Iv2M+g27RdiZycg+iLtZmM3Ml4O/uU= Received: from DM4PR11MB6479.namprd11.prod.outlook.com (2603:10b6:8:8c::19) by IA1PR11MB7343.namprd11.prod.outlook.com (2603:10b6:208:424::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Thu, 20 Oct 2022 07:24:03 +0000 Received: from DM4PR11MB6479.namprd11.prod.outlook.com ([fe80::cf13:1785:f79d:9eb9]) by DM4PR11MB6479.namprd11.prod.outlook.com ([fe80::cf13:1785:f79d:9eb9%7]) with mapi id 15.20.5723.032; Thu, 20 Oct 2022 07:24:03 +0000 From: To: Subject: Re: [PATCH 28/33] dmaengine: at_hdmac: Use devm_request_irq() Thread-Topic: [PATCH 28/33] dmaengine: at_hdmac: Use devm_request_irq() Thread-Index: AQHY5FTtS51J5v3KG0ym94wpt/4W1g== Date: Thu, 20 Oct 2022 07:24:03 +0000 Message-ID: <7d22c3c3-fb39-4b53-e306-acd8f1a0e648@microchip.com> References: <20220820125717.588722-1-tudor.ambarus@microchip.com> <20220820125717.588722-29-tudor.ambarus@microchip.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB6479:EE_|IA1PR11MB7343:EE_ x-ms-office365-filtering-correlation-id: 78ae9925-316f-4d25-4116-08dab26c10c3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pT+4sLZjZVkZNd0uQCY1sxjq8Mz6NQ13mcFg9RuttWnaZYqtYVXhTlymtLLJ4wkViIpP2Yz9RMBfi8e98a6k3kYq264qXC3d5g7MUen/J0ngylABo9t3KH85+xT54WcA0WewfjSsvRDHry1KQRdZ9g7KJwTs8LlDypKuZB4si+Eiy9nM0T4Y9B1R8Ank6vpNjTnOVeTYcLKs40dPBEvISSAapizcVjJJ0V9or/iqcK0ICh1xsV/Bnyjr20K8qlaEmOoFQhCQ9n9JM+8fj7cBGGjuOrzvitFVR2QVNJElth9pbv/+XSd4XpfBkAzMtbOSAdmwc4mpCPo7mdW3DENK7XcDH+XiYdFVp8Q7NMXEnia4kVcLBHT1Wks7PZe5z2bnBIPNatSBq09QgdN0E0nlhrnTcdrvePmP2+F28Z0PwyPT5IS0Zj4pVP1atTZs4nfjXUe9shPtQzgjYx3SXN1lI3Wm0ENpOR6zdiLilVzWPfGl4yRhVc8eVB2jukXXEfAn4l/gsPWcuav7IOMLnLBYhNPIcIV1FWLyq4MIHVe2N3FDczZwdUG8S2lfDphLFjKG3frgQlfswbvJAPe4T4eJC8Sih0WmjdYKVuwkwUg+z7aF7BGVfJT3AMup5LBJC8V8VfOsT5Th/Co1qXj5UayM3yOml82nciQiptTEeOtAFqc2gVuMYtXYvFgdDHRD5FgNxqCwjTmZXgKDkU8VB+cRq+eSOVXBxc1a2/IzGSX9Toa8zkzgypiC84gdsqYzsPAigXwdqALlZQvpHVwaR3YQiownz87GxM9RydQD7nnWEuCKF71jjBdeLzwULW3PGMyXN7YaRyLw3qC5F7I1kRa8Xw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB6479.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39860400002)(396003)(376002)(346002)(136003)(451199015)(478600001)(31686004)(6486002)(66556008)(64756008)(66446008)(7416002)(26005)(5660300002)(6512007)(41300700001)(2906002)(8676002)(83380400001)(76116006)(4326008)(91956017)(38070700005)(71200400001)(66946007)(36756003)(8936002)(316002)(53546011)(2616005)(54906003)(38100700002)(31696002)(66476007)(186003)(6506007)(86362001)(6916009)(122000001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?N3NtV3BIL1RDWkZ4djhQZXF4Qms2TlJ6eTNnZU1HZG5ud0JhRWpDWDFMQys0?= =?utf-8?B?UVZFMzd3alhobDhoRUpJd0p4U0JwazNWZ0dHaVJkelpyMklGcVVPVlNoOC8w?= =?utf-8?B?SW5pUlRNT21SeFdtVFNTRTF1U1R5d3lORFFWRzF6akY0UU1ST09JdWVhVFNV?= =?utf-8?B?anRud01URmVWWmlGTS9PbEUvbFI4ZS9pZjdIbkd6bjhUTEhXNG1ONU5xSkNl?= =?utf-8?B?ZTB0NnU3M2FDWndtcHF2SVI3WDBHKzRsb1BsZm1BcWEveEVNcHAxaVBISzVE?= =?utf-8?B?aUF5bit6KzdPLzNCNmViR3dhVlF1SXVsR2FBTVhrcG5UU3NIcTVBbFdIdGxG?= =?utf-8?B?NGcrcmZKdnVHVGFhT1IzTjF5bjM3OGFUclhmRE40cXBJZXQ4RjB0ejNjZlQv?= =?utf-8?B?ZnQrRWdDZEZKbTNSbkl3eVlMN1FIVUszNWhhTzM0cGlHNDVER0JRSmpoNVBs?= =?utf-8?B?bE44MWVWRXBUWnA4eHZQSzRMdzgvS1J5SE1ZWmxBeU1kSDJwWlFVTWlzR213?= =?utf-8?B?aEtWTW5Mb0ZPSkZkRzVOdE8rRXlPalZQSGFhbnQyN2JtcVRqKy9MOGFqcisw?= =?utf-8?B?SmxCdEd3Z25US2xVeEVXc1NRdGlKanV5a0RkeXpiQkppVlMyVG5YRGEzN2NR?= =?utf-8?B?aUdWZEVQU0FXQ2JKSnN6a0Z0clNlRWxJdnZQbUx3TFNzT0tST2FkRDBHRm9Z?= =?utf-8?B?OWlaaXM3S2lqbE9oWHd0MjIybEpqVFMva1ozWEx5L0RtaGxyQ3FSNmk1U0RT?= =?utf-8?B?UHFhQUxocWtVMGlsVlVrTjFPbVFtS1dXWnlyK2h0UGd3NlNtYXh1UGZ0ckRq?= =?utf-8?B?MzFpOEcwYW13QjBaaW5yUThXQjJxck8xMkVhYklLZFhlV3FNZU1QRXk4VEY5?= =?utf-8?B?TmFKQThDeURkWnZnSTdSSmROcG5HS01JQUxienJFblFhREM3VUYwR3dpOGRo?= =?utf-8?B?K0ZTdTc4bTJHdnRoNVY1TERTT3p0Z0Q0ajhmUGMwVUFSSXV0LzM2Y1F6Ym93?= =?utf-8?B?Q2M4TDllcmd2WXNIL1orZk5oa1M5MVRLV0V1RXBlZGEzWmZqRXFiYWFocHg5?= =?utf-8?B?enFydFliU2FtTXduVi9yWUs1SHdQVVR3TjJ6RExFd0dZRGVXMjljVExSNm5W?= =?utf-8?B?ZnVpOWRLMnhydmIrekhFeDdTSmpzdlh3cFFGMVpMSTdpc3R5enNzVm03dDJS?= =?utf-8?B?aXBrMEQvVVlJS29EV1lYOG5rN05QM1pzblJGTjl2WDhha1ZoQUsvNWplYk9Z?= =?utf-8?B?djA2ekNkbmdhTmh1OVlSbFZmUkFNQitUNFE1ajBWTE1ybzRtRFNVZ1NXNkMv?= =?utf-8?B?WVRNaWVER3lIampnbWpUeGIxQW5rQjRxS1Z3czV1eXdpRmdBaElyNE55YmVn?= =?utf-8?B?RG82UE5Xa29mZ1M1dG1ZL0VZK0VIV2lUZmJ6b0pVZFFGSVVPSlR0Zy94UytC?= =?utf-8?B?cE94TmErZzJBcmc3QU5OTDhyYjRDSHh1cnZkd1h3NFpMOFJyNUxndjVWc0lp?= =?utf-8?B?b3UraHNRVW83ZGFONWdKL0RveGJ6dU8rL2cyUjZjRmU5OTMzZmI2UVVyY0tj?= =?utf-8?B?Sy9nMG50dEtGbkFzL2x2VkpBbDRTcTFuQjRqN0dEa240c21NZ2tnWUdxa0sx?= =?utf-8?B?NkIxM2RwVkhPMlZtdm4xaXNHQ2NBa25mcmo2STQwWHJUbmNqNWFqTHpCRFk3?= =?utf-8?B?NkZTRk1QUVA1K3U0WUorZktGRWZFMFZIWGFJTWR6aU5FV0NHQXhKaDRxNTZ0?= =?utf-8?B?WUVMOUQycnpvaktFNjhIb3RkYllNbTNpb21Idy91N252dCsvcURMMk4wOFQ4?= =?utf-8?B?M3RFOGlWTFJWNUl1TWNyOWJtd3pUdWs4S3gzYUlJTUNkcEFDUmxndU1iOTNB?= =?utf-8?B?RW1mdzdXQzZ6b0tHNUU2ZWFmMXpiSDJMSVg0WVNWSFZCTzhoVldUR1Nsdnc2?= =?utf-8?B?akdjUUdueFZCcHI2RlMzeGQwcTR2eUhFVlEwTS91UEpyQmRpLy9BcHRzUEtC?= =?utf-8?B?eFdpbHZBQVJnRFAvcm1wQU9aVlpLWG5pQUlMWlFUbzlTRXM2WEYzLzJaa0s2?= =?utf-8?B?ZCs2VVlxTUhncnFmUCtYU0d6TW45M0RjWmV3VDIzZ2tQSWFBZllTSmJEL0Yy?= =?utf-8?Q?2LJX9JloIWxCJaVN06LlLrfGs?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6479.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78ae9925-316f-4d25-4116-08dab26c10c3 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2022 07:24:03.3477 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GpjasZ3RS6zzuQlJb72EefewxodTE7tGpvcn8iwaXvnBwGEovYEO/OJ8griHwDpUbucdGnu5M7kDP1B+/0nuUpdVB+aW0ubR9QNQHcsBuCk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7343 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221020_002412_762737_A1575F5D X-CRM114-Status: GOOD ( 21.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, maciej.sosnowski@intel.com, mripard@kernel.org, torfl6749@gmail.com, du@axentia.se, Ludovic.Desroches@microchip.com, regressions@leemhuis.info, dmaengine@vger.kernel.org, dan.j.williams@intel.com, peda@axentia.se, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/19/22 19:49, Vinod Koul wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 20-08-22, 15:57, Tudor Ambarus wrote: >> IRQs requested with this function will be automatically freed on driver >> detach. Use devm_request_irq() and make the code cleaner. > > That is not really good idea! > >> >> Signed-off-by: Tudor Ambarus >> --- >> drivers/dma/at_hdmac.c | 11 ++++------- >> 1 file changed, 4 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c >> index 9c414f167b62..96b885f83374 100644 >> --- a/drivers/dma/at_hdmac.c >> +++ b/drivers/dma/at_hdmac.c >> @@ -2241,6 +2241,10 @@ static int __init at_dma_probe(struct platform_device *pdev) >> irq = platform_get_irq(pdev, 0); >> if (irq < 0) >> return irq; >> + err = devm_request_irq(&pdev->dev, irq, at_dma_interrupt, 0, >> + dev_name(&pdev->dev), atdma); >> + if (err) >> + return err; >> >> /* discover transaction capabilities */ >> atdma->dma_device.cap_mask = plat_dat->cap_mask; >> @@ -2257,10 +2261,6 @@ static int __init at_dma_probe(struct platform_device *pdev) >> /* force dma off, just in case */ >> at_dma_off(atdma); >> >> - err = request_irq(irq, at_dma_interrupt, 0, "at_hdmac", atdma); >> - if (err) >> - goto err_irq; > > here you are ready to receive the irq, but now you moved it early on.. > it may cause issues.. Oh, yes. > >> - >> platform_set_drvdata(pdev, atdma); >> >> /* create a pool of consistent memory blocks for hardware descriptors */ >> @@ -2377,8 +2377,6 @@ static int __init at_dma_probe(struct platform_device *pdev) >> err_memset_pool_create: >> dma_pool_destroy(atdma->dma_desc_pool); >> err_desc_pool_create: >> - free_irq(platform_get_irq(pdev, 0), atdma); >> -err_irq: >> clk_disable_unprepare(atdma->clk); >> err_clk_prepare: >> clk_put(atdma->clk); >> @@ -2397,7 +2395,6 @@ static int at_dma_remove(struct platform_device *pdev) >> >> dma_pool_destroy(atdma->memset_pool); >> dma_pool_destroy(atdma->dma_desc_pool); >> - free_irq(platform_get_irq(pdev, 0), atdma); > > Now we have an active irq while we are unrolling device, which can be > fired and cause tasklet to also get scheduled... > > You need to make sure now irq cant fire here and tasklet is killed.. right, I should have disabled the irq here and I missed it. Thanks, will respin. > >> >> list_for_each_entry_safe(chan, _chan, &atdma->dma_device.channels, >> device_node) { >> -- >> 2.25.1 > > -- > ~Vinod -- Cheers, ta _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel