* [PATCH 06/27] cpufreq: brcmstb: Don't validate the frequency table twice
2018-02-26 5:08 [PATCH 00/27] cpufreq: Stop validating cpufreq table in drivers Viresh Kumar
@ 2018-02-26 5:08 ` Viresh Kumar
2018-02-26 5:08 ` [PATCH 12/27] cpufreq: mediatek: " Viresh Kumar
` (3 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Viresh Kumar @ 2018-02-26 5:08 UTC (permalink / raw)
To: linux-arm-kernel
The cpufreq core is already validating the CPU frequency table after
calling the ->init() callback of the cpufreq drivers and the drivers
don't need to do the same anymore. Though they need to set the
policy->freq_table field directly from the ->init() callback now.
Stop validating the frequency table from brcmstb driver.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpufreq/brcmstb-avs-cpufreq.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/cpufreq/brcmstb-avs-cpufreq.c b/drivers/cpufreq/brcmstb-avs-cpufreq.c
index 7281a2c19c36..6cdac1aaf23c 100644
--- a/drivers/cpufreq/brcmstb-avs-cpufreq.c
+++ b/drivers/cpufreq/brcmstb-avs-cpufreq.c
@@ -902,11 +902,7 @@ static int brcm_avs_cpufreq_init(struct cpufreq_policy *policy)
return ret;
}
- ret = cpufreq_table_validate_and_show(policy, freq_table);
- if (ret) {
- dev_err(dev, "invalid frequency table: %d\n", ret);
- return ret;
- }
+ policy->freq_table = freq_table;
/* All cores share the same clock and thus the same policy. */
cpumask_setall(policy->cpus);
--
2.15.0.194.g9af6a3dea062
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 12/27] cpufreq: mediatek: Don't validate the frequency table twice
2018-02-26 5:08 [PATCH 00/27] cpufreq: Stop validating cpufreq table in drivers Viresh Kumar
2018-02-26 5:08 ` [PATCH 06/27] cpufreq: brcmstb: Don't validate the frequency table twice Viresh Kumar
@ 2018-02-26 5:08 ` Viresh Kumar
2018-02-26 5:09 ` [PATCH 19/27] cpufreq: s3c24xx: " Viresh Kumar
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Viresh Kumar @ 2018-02-26 5:08 UTC (permalink / raw)
To: linux-arm-kernel
The cpufreq core is already validating the CPU frequency table after
calling the ->init() callback of the cpufreq drivers and the drivers
don't need to do the same anymore. Though they need to set the
policy->freq_table field directly from the ->init() callback now.
Stop validating the frequency table from mediatek driver.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpufreq/mediatek-cpufreq.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c
index 84d658d57029..eb8920d39818 100644
--- a/drivers/cpufreq/mediatek-cpufreq.c
+++ b/drivers/cpufreq/mediatek-cpufreq.c
@@ -460,21 +460,12 @@ static int mtk_cpufreq_init(struct cpufreq_policy *policy)
return ret;
}
- ret = cpufreq_table_validate_and_show(policy, freq_table);
- if (ret) {
- pr_err("%s: invalid frequency table: %d\n", __func__, ret);
- goto out_free_cpufreq_table;
- }
-
cpumask_copy(policy->cpus, &info->cpus);
+ policy->freq_table = freq_table;
policy->driver_data = info;
policy->clk = info->cpu_clk;
return 0;
-
-out_free_cpufreq_table:
- dev_pm_opp_free_cpufreq_table(info->cpu_dev, &freq_table);
- return ret;
}
static int mtk_cpufreq_exit(struct cpufreq_policy *policy)
--
2.15.0.194.g9af6a3dea062
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 19/27] cpufreq: s3c24xx: Don't validate the frequency table twice
2018-02-26 5:08 [PATCH 00/27] cpufreq: Stop validating cpufreq table in drivers Viresh Kumar
2018-02-26 5:08 ` [PATCH 06/27] cpufreq: brcmstb: Don't validate the frequency table twice Viresh Kumar
2018-02-26 5:08 ` [PATCH 12/27] cpufreq: mediatek: " Viresh Kumar
@ 2018-02-26 5:09 ` Viresh Kumar
2018-02-26 5:09 ` [PATCH 21/27] cpufreq: scpi: " Viresh Kumar
2018-03-09 10:00 ` [PATCH 00/27] cpufreq: Stop validating cpufreq table in drivers Viresh Kumar
4 siblings, 0 replies; 7+ messages in thread
From: Viresh Kumar @ 2018-02-26 5:09 UTC (permalink / raw)
To: linux-arm-kernel
The cpufreq core is already validating the CPU frequency table after
calling the ->init() callback of the cpufreq drivers and the drivers
don't need to do the same anymore. Though they need to set the
policy->freq_table field directly from the ->init() callback now.
Stop validating the frequency table from s3c24xx driver.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpufreq/s3c24xx-cpufreq.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/cpufreq/s3c24xx-cpufreq.c b/drivers/cpufreq/s3c24xx-cpufreq.c
index 6bebc1f9f55a..3f0947e119a9 100644
--- a/drivers/cpufreq/s3c24xx-cpufreq.c
+++ b/drivers/cpufreq/s3c24xx-cpufreq.c
@@ -351,11 +351,8 @@ struct clk *s3c_cpufreq_clk_get(struct device *dev, const char *name)
static int s3c_cpufreq_init(struct cpufreq_policy *policy)
{
policy->clk = clk_arm;
-
policy->cpuinfo.transition_latency = cpu_cur.info->latency;
-
- if (ftab)
- return cpufreq_table_validate_and_show(policy, ftab);
+ policy->freq_table = ftab;
return 0;
}
--
2.15.0.194.g9af6a3dea062
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 21/27] cpufreq: scpi: Don't validate the frequency table twice
2018-02-26 5:08 [PATCH 00/27] cpufreq: Stop validating cpufreq table in drivers Viresh Kumar
` (2 preceding siblings ...)
2018-02-26 5:09 ` [PATCH 19/27] cpufreq: s3c24xx: " Viresh Kumar
@ 2018-02-26 5:09 ` Viresh Kumar
2018-03-12 12:43 ` Sudeep Holla
2018-03-09 10:00 ` [PATCH 00/27] cpufreq: Stop validating cpufreq table in drivers Viresh Kumar
4 siblings, 1 reply; 7+ messages in thread
From: Viresh Kumar @ 2018-02-26 5:09 UTC (permalink / raw)
To: linux-arm-kernel
The cpufreq core is already validating the CPU frequency table after
calling the ->init() callback of the cpufreq drivers and the drivers
don't need to do the same anymore. Though they need to set the
policy->freq_table field directly from the ->init() callback now.
Stop validating the frequency table from scpi driver.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpufreq/scpi-cpufreq.c | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c
index c32a833e1b00..7b31efe53252 100644
--- a/drivers/cpufreq/scpi-cpufreq.c
+++ b/drivers/cpufreq/scpi-cpufreq.c
@@ -150,13 +150,7 @@ static int scpi_cpufreq_init(struct cpufreq_policy *policy)
}
policy->driver_data = priv;
-
- ret = cpufreq_table_validate_and_show(policy, freq_table);
- if (ret) {
- dev_err(cpu_dev, "%s: invalid frequency table: %d\n", __func__,
- ret);
- goto out_put_clk;
- }
+ policy->freq_table = freq_table;
/* scpi allows DVFS request for any domain from any CPU */
policy->dvfs_possible_from_any_cpu = true;
@@ -170,8 +164,6 @@ static int scpi_cpufreq_init(struct cpufreq_policy *policy)
policy->fast_switch_possible = false;
return 0;
-out_put_clk:
- clk_put(priv->clk);
out_free_cpufreq_table:
dev_pm_opp_free_cpufreq_table(cpu_dev, &freq_table);
out_free_priv:
--
2.15.0.194.g9af6a3dea062
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 21/27] cpufreq: scpi: Don't validate the frequency table twice
2018-02-26 5:09 ` [PATCH 21/27] cpufreq: scpi: " Viresh Kumar
@ 2018-03-12 12:43 ` Sudeep Holla
0 siblings, 0 replies; 7+ messages in thread
From: Sudeep Holla @ 2018-03-12 12:43 UTC (permalink / raw)
To: linux-arm-kernel
On 26/02/18 05:09, Viresh Kumar wrote:
> The cpufreq core is already validating the CPU frequency table after
> calling the ->init() callback of the cpufreq drivers and the drivers
> don't need to do the same anymore. Though they need to set the
> policy->freq_table field directly from the ->init() callback now.
>
> Stop validating the frequency table from scpi driver.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
FWIW,
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
Tested-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 00/27] cpufreq: Stop validating cpufreq table in drivers
2018-02-26 5:08 [PATCH 00/27] cpufreq: Stop validating cpufreq table in drivers Viresh Kumar
` (3 preceding siblings ...)
2018-02-26 5:09 ` [PATCH 21/27] cpufreq: scpi: " Viresh Kumar
@ 2018-03-09 10:00 ` Viresh Kumar
4 siblings, 0 replies; 7+ messages in thread
From: Viresh Kumar @ 2018-03-09 10:00 UTC (permalink / raw)
To: linux-arm-kernel
On 26-02-18, 10:38, Viresh Kumar wrote:
> Hi,
>
> A patchset [1] sent last week already updated the cpufreq core to start
> validating cpufreq table if the policy contains a valid
> "policy->freq_table" pointer.
>
> This series updates all such drivers to stop validating the cpufreq
> table directly and let only the core handle it.
>
> It depends on the previous series [1] and two cleanup patches [2][3] and
> is rebased over 4.16-rc3.
>
> It is already tested by the 0-day testing infrastructure and no issues
> were reported.
We will assume no objections or concerns if you (cc'd here and on the individual
commits) don't respond and the series will then get merged into linux-next next
week.
Thanks.
--
viresh
^ permalink raw reply [flat|nested] 7+ messages in thread