From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10E26CD5BC0 for ; Thu, 5 Sep 2024 12:57:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=l7owXbb/VBHFK4fce9yvs3MuB77QKDDPRcXj4+oan0Q=; b=WV3kABOchcZmuZzIL/1/3LwZIX mvYwlIu8JwOISFaeXhW7LcY0zr7qBGp9xWXiN4pHzDJf7jPyZg9pWtPeDxpUzs4s1DYdptRDA4uU0 vYWwkY318hIdbiaGtne/fH1/0UQtNVIO0vc2lt8OQWe4IjjlnQT31T3HY+17ICMf74jYQC1LMlkzo I3vMSbXk5R4gu8q7dXHaJusBQX8+x/hZOl2Wm8qJW+hcqMw6+ihRjiCvQmDLxeHsJb8jyhOT4n6oJ ODYjVvuaUvCmwVrTNs24t6AIZJ/HKNbhpQxH3SDMk4viiGudH4nCKKBF8eo04Ko+E+2PKqdPrKwQT IqkCHm2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1smC2g-00000008R8F-3QNN; Thu, 05 Sep 2024 12:56:54 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1smC00-00000008QYu-1RaY for linux-arm-kernel@lists.infradead.org; Thu, 05 Sep 2024 12:54:10 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1806A5C4A0E; Thu, 5 Sep 2024 12:54:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9A7CC4CEC7; Thu, 5 Sep 2024 12:54:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725540847; bh=4XmQrAWJa5piLkccrwPYm7CbCPObuT5Tr2OL+43Vsc4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=txu4W7qKn8OrUNqks3clxcNgtI03eSEqYPGKxseaFpb3VVT+cQbLADzUqZbxjhuV7 kr964Vc9rTdbND8dpwVDDIfp3SW3V7tlEL0SyoR/0py/cp4noniTyItlLO8oUXcBIF y+UeiBTqaN3cCCMv4CUTJ3aWTWrTMFPSxxPKg78qA1O+rUu6zzKn8+Prsm2vNSvBlW KfGrbfkOjBd/RrkuapZB01929cjMkUed4Z62nuzx+m0TRT6zzIXkZtnjNnw7hLP1D4 pLqFD3pdKqYZP5nsGxi/6lLhoRBv32QYZFM/cNY2NzjoAmzmORI3wwFFwJggwox0vJ wJUHJha6rVW+A== Message-ID: <7d47081b-e7f8-4391-946a-f23e110976ec@kernel.org> Date: Thu, 5 Sep 2024 14:54:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 1/2] firmware: arm_scmi: Ensure that the message-id supports fastchannel To: Cristian Marussi , Sudeep Holla Cc: Konrad Dybcio , Johan Hovold , Sibi Sankar , linux-kernel@vger.kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org References: <20240904031324.2901114-1-quic_sibis@quicinc.com> <20240904031324.2901114-2-quic_sibis@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240905_055408_485206_B96373AA X-CRM114-Status: GOOD ( 14.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4.09.2024 4:20 PM, Cristian Marussi wrote: > On Wed, Sep 04, 2024 at 01:38:55PM +0100, Sudeep Holla wrote: >> On Wed, Sep 04, 2024 at 01:29:29PM +0200, Konrad Dybcio wrote: >>> On 4.09.2024 9:00 AM, Johan Hovold wrote: >> >> [...] >> >>>> >>>> Unfortunately, this patch breaks resume from suspend on the x1e80100 crd: >>>> >>>> [ 26.919676] CPU4: Booted secondary processor 0x0000010000 [0x511f0011] >>>> [ 26.960607] arm-scmi firmware:scmi: timed out in resp(caller: do_xfer+0x164/0x568) >>>> [ 26.987142] cpufreq: cpufreq_online: ->get() failed >>>> >>>> and then the machine hangs (mostly, I saw an nvme timeout message after a >>>> while). >>>> >>>> Make sure you test suspend as well as some of the warnings I reported >>>> only show up during suspend. >>> >>> Eh it looks like PERF_LEVEL_GET (msgid 8) requires the use of FC, but >>> the firmware fails to inform us about it through BIT(0) in attrs.. >>> >> >> Just trying to understand things better here. So the firmware expects OSPM >> to just use FC only for PERF_LEVEL_GET and hence doesn't implement the >> default/normal channel for PERF_LEVEL_GET(I assume it returns error ?) >> but fails to set the attribute indicating FC is available for the domain. >> > > Is not that FCs are optional BUT PERF_LEVEL_GET standard messages is > support is mandatory by the spec anyway ? So doing a bit of poking I think it's that FC is not marked as supported, but we need to read out the frequency from the .get_addr.. which is only populated if we go through fastchannel_init Konrad