From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EE7CC6FD20 for ; Tue, 21 Mar 2023 19:35:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UTnIHQ4/IaYdaHy82s7BILtX5x8pmwa/U7CMGz+bzKU=; b=ZTWQ+LuSWHPNyh NWrLmNCqCtRBFRMxMhAYspYcAkjCLaCK8QXerWj7rmqM4k0uSpBGs4D5PImPqFbm7inkpnsg/OKDX 0kWg2XM2IVPh+wFuqgaDDDv3vapviWbjeoJ47pn1Z6PIn6GTkEFRWe04/bVk7CT0ENLn/lWaCmsTP v0ABTtkL3A+1YdTygqB65H6nNHBiiJWIZ1XEcqqrmTrqR7yjEhrEsi7JEqYrgjG8knHPDp4Ss8sko Me3xcGGnvixxONw/Zp9SN8Rw/T8M2dOgLcWuRCq/KTxhUw2hObl+Ug7sDlQcRrvo8LfEdlf06ofpA zLCVezhuBmjRGprXdlkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pehkT-00DVnJ-2v; Tue, 21 Mar 2023 19:34:21 +0000 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pehk4-00DVXK-0V for linux-arm-kernel@lists.infradead.org; Tue, 21 Mar 2023 19:33:59 +0000 Received: by mail-lf1-x12c.google.com with SMTP id t11so20543008lfr.1 for ; Tue, 21 Mar 2023 12:33:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679427234; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JMHhMtonsK7206fFrguTPhzlan6ylHN3dFzR3FtCHqU=; b=DCkVJgx5M23kD7k2bq7WLI2pRpSdvanRfk8ncagMTwNUQVu7Bjxka0AtqfeIH53IVq ut6KpJq0gwl4w0bKU7woofqTwlkgHMYggthFa3SCl+F7I97qFXkWpyDVkHx8yyRAlS6n aNXbeNTBmjPs8frGvwiueaLoTnIrbSLW0YIlW7IfVtI8xH3+JWrbeAyy7CY5PgEOrMdJ WOj35tpXYPJCbKYONREBkVppfJ7IAtd/S43GdbRnMfvIAkghy6lzWoU/B79NpRVmCNGL 5rAfZyHrHv4mxOJACUAEH8duhcXsVg1ynpYJYhr6gvNVsyww0ZUkpLmVHGIKSJHGGEqi fnRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679427234; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JMHhMtonsK7206fFrguTPhzlan6ylHN3dFzR3FtCHqU=; b=VC8feFIWyvis2EAeNFm5TOI+5uOpE+vk5IqfOUuaEuS98LXjufTAoPQY5JOnYmLHHv aDIR5NrYmd46ihCykoGJgBG8sjBiNGg7jD9BlYibmmr1WPqESkRxUzxmJjg/W7Qml9CJ PzJ37gEJ3Ei2YnVKyY8Z/NkNB0yHWhcKSDttSOWpupljTTHkUSJWUNKCFgBmKwxH5si1 2iCnjC2+MtLGxnPTOVvyKXTuqmVhSmx9nH7ftmyeKNkyRf1aacRFerx/HTevH577zNSn kHqS8MhydoTinsZp2ISH1DTE6AsUAzgUgWZz997PEvii5FMSMP/V8tgYRNKYySRrk5+U 8DQg== X-Gm-Message-State: AO0yUKU00ym5Hw1z6NeTORFkjK3n2RL7PoSjG5IQQryXEvP8bn7AHha/ RqNn0C3Fti126Vlh3cWyXrYvNg== X-Google-Smtp-Source: AK7set/7NLnyEkxDSUA9YVO7IO07SEYU/d89whtJ6yXcPqhZfZ0byhUFUgX/8egdo7Ka51f2/nft4w== X-Received: by 2002:ac2:44da:0:b0:4ea:c730:aac3 with SMTP id d26-20020ac244da000000b004eac730aac3mr1356890lfm.3.1679427233818; Tue, 21 Mar 2023 12:33:53 -0700 (PDT) Received: from [192.168.1.101] (abym238.neoplus.adsl.tpnet.pl. [83.9.32.238]) by smtp.gmail.com with ESMTPSA id y3-20020ac24463000000b004db00b4c671sm2295208lfl.7.2023.03.21.12.33.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Mar 2023 12:33:53 -0700 (PDT) Message-ID: <7d4f9662-2eb1-e2d2-193c-e6453dc7b93b@linaro.org> Date: Tue, 21 Mar 2023 20:33:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH net-next v2 06/12] arm64: dts: qcom: sc8280xp: Add ethernet nodes Content-Language: en-US To: Andrew Halaney , linux-kernel@vger.kernel.org Cc: agross@kernel.org, andersson@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, vkoul@kernel.org, bhupesh.sharma@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, richardcochran@gmail.com, linux@armlinux.org.uk, veekhee@apple.com, tee.min.tan@linux.intel.com, mohammad.athari.ismail@intel.com, jonathanh@nvidia.com, ruppala@nvidia.com, bmasney@redhat.com, andrey.konovalov@linaro.org, linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, ncai@quicinc.com, jsuraj@qti.qualcomm.com, hisunil@quicinc.com, echanude@redhat.com References: <20230320221617.236323-1-ahalaney@redhat.com> <20230320221617.236323-7-ahalaney@redhat.com> From: Konrad Dybcio In-Reply-To: <20230320221617.236323-7-ahalaney@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230321_123356_916175_4464F58F X-CRM114-Status: GOOD ( 15.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20.03.2023 23:16, Andrew Halaney wrote: > This platform has 2 MACs integrated in it, go ahead and describe them. > > Signed-off-by: Andrew Halaney > --- > > Changes since v1: > * None > > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 53 ++++++++++++++++++++++++++ > 1 file changed, 53 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index 0d02599d8867..a63e8e81a8c4 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -761,6 +761,59 @@ soc: soc@0 { > ranges = <0 0 0 0 0x10 0>; > dma-ranges = <0 0 0 0 0x10 0>; > > + ethernet0: ethernet@20000 { > + compatible = "qcom,sc8280xp-ethqos"; > + reg = <0x0 0x00020000 0x0 0x10000>, > + <0x0 0x00036000 0x0 0x100>; Please correct the indentation here. > + reg-names = "stmmaceth", "rgmii"; > + > + clocks = <&gcc GCC_EMAC0_AXI_CLK>, > + <&gcc GCC_EMAC0_SLV_AHB_CLK>, > + <&gcc GCC_EMAC0_PTP_CLK>, > + <&gcc GCC_EMAC0_RGMII_CLK>; Please correct the indentation here. > + clock-names = "stmmaceth", "pclk", "ptp_ref", "rgmii"; Please turn this into a vertical list. > + > + interrupts = , > + ; Please correct the indentation here. Same for the other node. Konrad > + interrupt-names = "macirq", "eth_lpi"; > + iommus = <&apps_smmu 0x4c0 0xf>; > + power-domains = <&gcc EMAC_0_GDSC>; > + > + snps,tso; > + snps,pbl = <32>; > + rx-fifo-depth = <4096>; > + tx-fifo-depth = <4096>; > + > + status = "disabled"; > + }; > + > + ethernet1: ethernet@23000000 { > + compatible = "qcom,sc8280xp-ethqos"; > + reg = <0x0 0x23000000 0x0 0x10000>, > + <0x0 0x23016000 0x0 0x100>; > + reg-names = "stmmaceth", "rgmii"; > + > + clocks = <&gcc GCC_EMAC1_AXI_CLK>, > + <&gcc GCC_EMAC1_SLV_AHB_CLK>, > + <&gcc GCC_EMAC1_PTP_CLK>, > + <&gcc GCC_EMAC1_RGMII_CLK>; > + clock-names = "stmmaceth", "pclk", "ptp_ref", "rgmii"; > + > + interrupts = , > + ; > + interrupt-names = "macirq", "eth_lpi"; > + > + iommus = <&apps_smmu 0x40 0xf>; > + power-domains = <&gcc EMAC_1_GDSC>; > + > + snps,tso; > + snps,pbl = <32>; > + rx-fifo-depth = <4096>; > + tx-fifo-depth = <4096>; > + > + status = "disabled"; > + }; > + > gcc: clock-controller@100000 { > compatible = "qcom,gcc-sc8280xp"; > reg = <0x0 0x00100000 0x0 0x1f0000>; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel