From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93EB5C64ED6 for ; Mon, 27 Feb 2023 16:39:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PJr4gWJfWq4AF+H980DcrjWrIssIWecYmU6iqe2mVFc=; b=cM1AX7hEY78s0S XTtbxdFpsvanL3zX0YDsFvFtU4aSFuwuoGcsFkgWC926GlWg/3OqJFL+uK1cnblvgK+zvDup8AQEL TbUu3zyGzrKq4je/EdrbiRsaBn7cSlMVJfyYFd5oI7U/E1NsEEgMpA2w6lhxO2wOBkpRz+f7bq/sM wHLRSvkxFjq+okLRFu80YxM9vXb5O5zterTZlGWECeFIbijTt6DjG9ySZs9JvqB02dZ6fi2C9J3q0 puQkR0HvjIL2T9av1jFsYQVYBQIoUU99MxnB7BL/PuYRJ+c3brLeOXmGuis8JKXtJLsLDc6mmheZa m9drCDOv5iSHbBzE3Nfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWgWQ-00ANvR-0Y; Mon, 27 Feb 2023 16:38:42 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWgWN-00ANuj-0c for linux-arm-kernel@lists.infradead.org; Mon, 27 Feb 2023 16:38:40 +0000 Received: by mail-wr1-x42b.google.com with SMTP id bx12so3733584wrb.11 for ; Mon, 27 Feb 2023 08:38:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UdlgcB/Y9MWIyQdrrEyftem3TGdOyYMADGKRIrz+XL4=; b=KhaR/5PFYBZ4e0/PRC2atbQksjLPyXgLZJVUNc/QdjF0faE1bUZtR3FTBZbZimbu4I 0sv2dFi4dPI3UntSAqkpLk954/7hl7pigQbGVhwGvDnhXFWUVujxRBQ1ZojobtjUyAYC 4dfLvyWXnNFKBC/W2ntFo+IiTI+8lIJB0hwG59RF1xx00Z+c1b85fWAXfh6BzR8OsPOA vuFuV77k2jO+uZQUecWr9IiNFbJekfOf0uYASJJVhMUQ0T4nQdNplY08nFqTEaKAYZtg lYlKplNS/6qzuFpkRKmYp3qJQyw/dzF9sH50E7T4yG5tD102EsCiRdfmngXOdKUZ2Al+ Xy3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UdlgcB/Y9MWIyQdrrEyftem3TGdOyYMADGKRIrz+XL4=; b=xNrE9qdRJ0vZ8xxHAnOuZAtDZD91J+1NzXtR5p3gqTSis/VaAQA81vztWVa6AZ/IDM X6Mp5iwYgynd1kqHu/F+RcKRTHOsvUd85ghktRSUPTKX6ANply4HznMHw6xNSShzLLIG F1WWBg+kIhtJEw2whQR5AW/yDqDgHHga/oIgp9e5sQEjNUanXRQ7Dm5lw3AWoyMypmOd HJ7ffkKNxH7trzKodVt92V9JLQ3OT/O9n4iJ4oOie0TXx+0ds2JJfThtY5D9sDSuONfj 8W+gU1nvTkzH1f6nBpXDcEeqlpU2M4sATK5W8MOBMOo8h39PSbJNgWL2izVT5C9LCOZT JckA== X-Gm-Message-State: AO0yUKW5E7wK3HjQ0gyCY1ZELlYisnJRk0Par0oEKG66urvJ4qmvMUgg xcwOB2YheHL//Aqqilkoqim1fQ== X-Google-Smtp-Source: AK7set83TuZ0j8uIK5yzlvtwSbF2UceAh+Q/YkwHcVaUWm3uThlwlmN/wPeuy1AW2ayn9bdQwarG7w== X-Received: by 2002:adf:f0cd:0:b0:2c7:d75:373a with SMTP id x13-20020adff0cd000000b002c70d75373amr15215774wro.1.1677515915389; Mon, 27 Feb 2023 08:38:35 -0800 (PST) Received: from [192.168.1.20] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id t3-20020a5d6903000000b002c56af32e8csm7691119wru.35.2023.02.27.08.38.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Feb 2023 08:38:35 -0800 (PST) Message-ID: <7d52af12-0ff8-4bea-22da-596e5bac02e3@linaro.org> Date: Mon, 27 Feb 2023 17:38:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH AUTOSEL 4.19 2/3] ARM: dts: exynos: Use Exynos5420 compatible for the MIPI video phy Content-Language: en-US To: Pavel Machek , Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Markuss Broks , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org References: <20230226034424.776084-1-sashal@kernel.org> <20230226034424.776084-2-sashal@kernel.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230227_083839_115434_0A79085B X-CRM114-Status: GOOD ( 15.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27/02/2023 17:27, Pavel Machek wrote: > Hi! > >> From: Markuss Broks >> >> [ Upstream commit 5d5aa219a790d61cad2c38e1aa32058f16ad2f0b ] >> >> For some reason, the driver adding support for Exynos5420 MIPI phy >> back in 2016 wasn't used on Exynos5420, which caused a kernel panic. >> Add the proper compatible for it. > > This is likely bad idea for 4.14, as that compatible is still in use: I don't understand this. What does it mean? That compatible was used and still is used somewhere... Just because incorrect compatible is used somewhere is not really related whether it should be (or not) replaced with correct compatible. BTW you mentioned v4.14 but AUTOSEL is for v4.19. > > drivers/phy/samsung/phy-exynos-mipi-video.c: .compatible = "samsung,s5pv210-mipi-video-phy", > arch/arm/boot/dts/exynos5420.dtsi: compatible = "samsung,s5pv210-mipi-video-phy"; > arch/arm/boot/dts/exynos3250.dtsi: compatible = "samsung,s5pv210-mipi-video-phy"; > arch/arm/boot/dts/exynos4.dtsi: compatible = "samsung,s5pv210-mipi-video-phy"; > > phy-exynos-mipi-video.c lists other compatibles, too, but with > different data. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel