From: Shrikanth Hegde <sshegde@linux.ibm.com>
To: maddy@linux.ibm.com, catalin.marinas@arm.com
Cc: tglx@linutronix.de, bigeasy@linutronix.de, vschneid@redhat.com,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
linux-kernel@vger.kernel.org, will@kernel.org,
linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com,
Christophe Leroy <christophe.leroy@csgroup.eu>,
mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org
Subject: Re: [PATCH 1/1] sched: preempt: Move dynamic keys into kernel/sched
Date: Fri, 13 Jun 2025 15:19:11 +0530 [thread overview]
Message-ID: <7d8b517f-3122-446e-aa72-ce0dd99a9a27@linux.ibm.com> (raw)
In-Reply-To: <20250610075344.1379597-2-sshegde@linux.ibm.com>
+Cristope Leroy.
On 6/10/25 13:23, Shrikanth Hegde wrote:
> Dynamic preemption can be static key or static call based.
> Static key is used to check kernel preemption depending on
> the current preemption model. i.e enable for lazy, full.
>
> Code is spread currently across entry/common.c, arm64 and latest being
> powerpc. There is little arch specific to it. For example, arm64,
> powerpc does the same thing. It is better to move it into kernel/sched
> since preemption is more closely associated with scheduler.
>
> Plus, Any new arch that wants dynamic preemption enabled need to have
> only HAVE_PREEMPT_DYNAMIC_KEY.
>
> This is more of code movement. No functional change.
>
> Suggested-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Signed-off-by: Shrikanth Hegde <sshegde@linux.ibm.com>
> ---
> arch/arm64/include/asm/preempt.h | 1 -
> arch/arm64/kernel/entry-common.c | 8 --------
> arch/powerpc/include/asm/preempt.h | 16 ----------------
> arch/powerpc/kernel/interrupt.c | 4 ----
> include/linux/entry-common.h | 1 -
> include/linux/sched.h | 8 ++++++++
> kernel/entry/common.c | 1 -
> kernel/sched/core.c | 4 ++++
> 8 files changed, 12 insertions(+), 31 deletions(-)
> delete mode 100644 arch/powerpc/include/asm/preempt.h
Hi. Catalin, Maddy,
Does respective arch changes seem ok?
next prev parent reply other threads:[~2025-06-13 9:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 7:53 [PATCH 0/1] powerpc, arm64: move preempt dynamic key into kernel/sched Shrikanth Hegde
2025-06-10 7:53 ` [PATCH 1/1] sched: preempt: Move dynamic keys " Shrikanth Hegde
2025-06-13 9:49 ` Shrikanth Hegde [this message]
2025-06-16 16:37 ` Mark Rutland
2025-07-13 4:50 ` Shrikanth Hegde
2025-07-11 14:56 ` Will Deacon
2025-07-14 2:39 ` Madhavan Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d8b517f-3122-446e-aa72-ce0dd99a9a27@linux.ibm.com \
--to=sshegde@linux.ibm.com \
--cc=bigeasy@linutronix.de \
--cc=catalin.marinas@arm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maddy@linux.ibm.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).