From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80731C3DA42 for ; Wed, 17 Jul 2024 07:48:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pvQ7mUcEDAkd5SXE13W2JsLBSq8CV9Djj3677zFvYx4=; b=r+JfWg6FabNRbTMz0sJw3MQkT4 WgHv8I7f0NjAlZcatOTccXE/y97+xZywoJKq9HHggHTuB5ZAIm739J9XYacUg3lNlYi9skO3AZonv MooJRKoaUaXmlzMWxPabtetnkbumtymdE+ZZH6flRvDNWWOVFA0T3fyFLQdw6JjOz+L+jmIaVO3Zh ks/xEouziI1npi0aAQUBzeKRVHaIruZzU3GtqrDbbBYuIw6og+unudfaTAsB9DGe31tKueOsST8HI MopZlNB8ydqWb7qhq7tyesGQYbLTO7+aQmgBt0/tFFGp5hJn+a7HdRBSPTRAfMNf/DT5/iQb922wg Joljf6vg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTzOc-0000000D1Lh-0JHr; Wed, 17 Jul 2024 07:48:18 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTzO8-0000000D1GF-2HX7 for linux-arm-kernel@lists.infradead.org; Wed, 17 Jul 2024 07:47:58 +0000 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-427c4843df5so1498805e9.0 for ; Wed, 17 Jul 2024 00:47:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1721202467; x=1721807267; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pvQ7mUcEDAkd5SXE13W2JsLBSq8CV9Djj3677zFvYx4=; b=U2bCuBIPtxnvrXfbl4fSEDPeqtNuTFSoQVZVRxpr08iuCDzyVjzsjjw2lZe8Qq6Yar Trj2GkasVHJa1oSgDDFGu9p2CO3YaxDNs87dFy6C6bXCd9uKEyB/Cl+L2xlsn7Hl0nFn kv76Q3ru6W2HSditM7OBeDudM31rUQREBgwpvRR/ootvP/0wny62p0+MTUeeVW8B7Ang e3ua525zcx70T/vlLD/39zyE5FIS19qknPJuXzQ1oCFjHLCFzfhUzVbnoDGUq6l/uJVr JmkyKJX91j/ci7ZmKKeadZnJgeTtsUfXDsVriwKXCHnWqu8k7R38pRFa9awTso71FqaP iTBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721202467; x=1721807267; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pvQ7mUcEDAkd5SXE13W2JsLBSq8CV9Djj3677zFvYx4=; b=UXKEcxJyf+DtIs+6jq/muKCdUZUo9SYtL+ZFqH0BbL5s92NMTaEgZiicCETFHKzlqb r9rH2Wh0E7wpqID7EO09hLD9nI81so212QiYVtdAtlaiAd7NSpToAIfjBB/Bjd2IiZmz bK8hMK7Z44wbGwA9gC4+Xqt9+u4EQojJAjg0xYnvTO+HsceavcJZYy0Ss0Re009c4FOe LDjjpzO/t1G+efIhtGInCS+KLPZ7knIygQ6ZKXJMaEXNsHR0/5I2sNaWNmjpMg9VHcGS wjuM3EXvjfqBq5rmTvU4oOZj3Te4ObM0WIWdgkeFEOgW7WqqqEEwQoO8yrsiFKtrQkG8 7xlA== X-Forwarded-Encrypted: i=1; AJvYcCWOpjPVVWmdeYIMS5S4vcRwDBdRrlGA9HDdSIQzR6TwGgwRKDn3BLhpNhzNqy+4vpoSVcSwySMmvFiPYX6NrAmefRVC0wURh4lHxpjOAHNskvrCu0Y= X-Gm-Message-State: AOJu0YwPxG3LWCASQCiari+SQs8QKYOOFZFqS0k64UkNPYrpb8bicEmg vK+gBmIIp1mf4YMUMQpmxoCpcdjAMzZ/WAJ8aBHkRl2Cb1GJ6+lCqDplH4hVFwU= X-Google-Smtp-Source: AGHT+IEGuVvZ44case4QSyMvRj6cX5xkzPcx+lS4rYQA4fq/bF4ojc304lVV4+Qj7wTa26bO8bS1UA== X-Received: by 2002:a05:600c:1d8c:b0:425:7c5f:1bac with SMTP id 5b1f17b1804b1-427c2cbdd5fmr7701125e9.21.1721202466683; Wed, 17 Jul 2024 00:47:46 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.171]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427a5e9a809sm160194035e9.28.2024.07.17.00.47.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jul 2024 00:47:46 -0700 (PDT) Message-ID: <7d99171f-746c-4eea-bf3e-d8f3954e4d8f@tuxon.dev> Date: Wed, 17 Jul 2024 10:47:45 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/11] mfd: renesas-vbattb: Add a MFD driver for the Renesas VBATTB IP Content-Language: en-US To: Krzysztof Kozlowski , lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, alexandre.belloni@bootlin.com, geert+renesas@glider.be, magnus.damm@gmail.com, mturquette@baylibre.com, sboyd@kernel.org, p.zabel@pengutronix.de Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Claudiu Beznea References: <20240716103025.1198495-1-claudiu.beznea.uj@bp.renesas.com> <20240716103025.1198495-3-claudiu.beznea.uj@bp.renesas.com> From: claudiu beznea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240717_004748_620067_6428E66A X-CRM114-Status: GOOD ( 16.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Krzysztof, On 16.07.2024 22:29, Krzysztof Kozlowski wrote: > On 16/07/2024 12:30, Claudiu wrote: >> From: Claudiu Beznea >> >> Renesas VBATTB IP has logic to control the RTC clock, tamper detection >> and a small 128B memory. Add a MFD driver to do the basic initialization >> of the VBATTB IP for the inner components to work. >> >> Signed-off-by: Claudiu Beznea >> --- > > >> + >> +static struct platform_driver vbattb_driver = { >> + .probe = vbattb_probe, >> + .remove_new = vbattb_remove, >> + .driver = { >> + .name = "renesas-vbattb", >> + .of_match_table = vbattb_match, >> + }, >> +}; >> +module_platform_driver(vbattb_driver); >> + >> +MODULE_ALIAS("platform:renesas-vbattb"); > > You should not need MODULE_ALIAS() in normal cases. If you need it, > usually it means your device ID table is wrong (e.g. misses either > entries or MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute > for incomplete ID table. It's not needed. I took another driver as reference and missed to removed it from here in the end. Thank you for your review, Claudiu Beznea > > >> +MODULE_AUTHOR("Claudiu Beznea "); >> +MODULE_DESCRIPTION("Renesas VBATTB driver"); >> +MODULE_LICENSE("GPL"); > > Best regards, > Krzysztof >