From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8115AC433EF for ; Thu, 7 Apr 2022 09:48:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=70gwlzHl9wBuS7bxiTNpbSpCmzbHqJoywsLBK7eH14E=; b=ebJYJcQ5Pr6iI2 G5vo/ugwzUPFRXsd4Umk08Q8DYUvZoN3Wei8dyJt9zwHtMsi725PkCu0ufXaTbmtD46XKRbJmw0ZF M79A1G5gPPq28u4yB1xWGfcrUrCAuqGIQv6erRsRpFdQIhlsQgmu3eiepgDcDW/Tbww7+Mah7zNqw Di1Y+HRtRVYEP0QmvmIlCKoughu2tWlulLVZeBMuEkUXfTHpeOFx4X46gSzLcQ0WkPJhRbTf/eHC/ R8XpmN6emWPRzSaatXcDN9TpmwLxdNwQcf2EF2hDpvXeVpHBLkzN2CXRa9XFJdR3eyzpyEW1FL155 zdcFFjNV6d57rr2mIWOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncOjG-00AzRe-Pn; Thu, 07 Apr 2022 09:47:04 +0000 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncOIv-00AnF5-7L for linux-arm-kernel@lists.infradead.org; Thu, 07 Apr 2022 09:19:50 +0000 Received: by mail-ej1-x62f.google.com with SMTP id l7so4112360ejn.2 for ; Thu, 07 Apr 2022 02:19:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=OhZn55oqpDXIvKLvKoNusLeA/Le7lGuQ4Qseb8DPsUQ=; b=o4mWa8llyJhR0hXytKXYg8Jm7+j7FbG2XIo9m1ek+brBno+uQo2HZZWkbmW5W/9QcG c9Py20S5rz3TcDCjRoQnwxvRO8Pkrhkzh4ftv0afwjRkBsyuHD5Vw70dKpJ84c8wdxnO WXI4ShYaC9NoYd9QFGcYQRCek9oQ5gLfsybO/i8ECbYTP1uaaZ6ak7bZ4nXz2PPHNC5S j+glrsqr34TjNHReLgx1ujxSXbR82hJgdwJbkae2lxWzi+cz8tIm+kVPdBoGMyS+mCk6 dUp0UjvY9vxal/bAIH62k2ihxs6F5Ge99WJ7y2gJUnump2hDZi2/9Gv6/qM72qx9usWL 08rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=OhZn55oqpDXIvKLvKoNusLeA/Le7lGuQ4Qseb8DPsUQ=; b=o+oRDKOjzLZaIhBQ/vg8PVfhYMEDLgdqqdM1oyw5Oz5jNl/KrfxC5TGjrVG7XB6kOr oX61HmICmzOSf2cMZvUeymCG2I9PlSdi4BZFCjWovFrPJSu67EKRuu0fDSmb9YzgkEu1 g/v8nnkhg/t9qgZw6G/yyH1JFfD0C4OdorYVf4HcwyusCBhiFO3tPRGI0qoUbOMN3Crk arXi06tE2DBybAORJCfCZONGgGLiWcaO+Mpfixwa7CeEGQvCCFF2mDqV5/QHx+FwRny7 lp8iCSCvVu0fIK/bmlSg7brdMKNar2fFjlQPaQIYcTvXqNMAFwMOtCIR6eAqNVEZ9p2K 3cRQ== X-Gm-Message-State: AOAM533pr06rF9GSmkW79oSeJELTxCeQ8fRY/vQtTSbobOFx96lNfr5G xXg1P7IG5JSwGy3WW3JZbpyUcQ== X-Google-Smtp-Source: ABdhPJwrfOj4aHp2YqJnDOzcr0lhU3Ho+3z/I+Snr1r/9J1rjLJks+IfGB/rZ/rf9fpkMv+YT4ttzA== X-Received: by 2002:a17:907:608c:b0:6e7:fc15:2db9 with SMTP id ht12-20020a170907608c00b006e7fc152db9mr12144063ejc.344.1649323187671; Thu, 07 Apr 2022 02:19:47 -0700 (PDT) Received: from [192.168.0.185] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id f15-20020a50e08f000000b004134a121ed2sm9146929edl.82.2022.04.07.02.19.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Apr 2022 02:19:47 -0700 (PDT) Message-ID: <7da30fdc-cef7-879a-69ef-6993e05beda5@linaro.org> Date: Thu, 7 Apr 2022 11:19:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [RESEND PATCH 2/2] phy: samsung: exynos5250-sata: fix missing device put in probe error paths Content-Language: en-US To: Kishon Vijay Abraham I , Vinod Koul , Alim Akhtar , Girish K S , Yuvaraj Kumar C D , Vasanth Ananthan , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220407091857.230386-1-krzysztof.kozlowski@linaro.org> <20220407091857.230386-2-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20220407091857.230386-2-krzysztof.kozlowski@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220407_021949_290375_A571C90E X-CRM114-Status: GOOD ( 10.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07/04/2022 11:18, Krzysztof Kozlowski wrote: > The actions of of_find_i2c_device_by_node() in probe function should be > reversed in error paths by putting the reference to obtained device. > > Fixes: bcff4cba41bc ("PHY: Exynos: Add Exynos5250 SATA PHY driver") > Signed-off-by: Krzysztof Kozlowski > --- > drivers/phy/samsung/phy-exynos5250-sata.c | 20 ++++++++++++++------ > 1 file changed, 14 insertions(+), 6 deletions(-) I forgot: Reviewed-by: Alim Akhtar https://lore.kernel.org/all/018501d834eb$01e62ad0$05b28070$@samsung.com/ Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel