Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Hawkins, Nick" <nick.hawkins@hpe.com>
Cc: "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"will@kernel.org" <will@kernel.org>,
	"robh@kernel.org" <robh@kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/3] dt-bindings: arm: hpe,gxp: Add HPE GSC platform compatible
Date: Mon, 30 Mar 2026 16:57:42 +0200	[thread overview]
Message-ID: <7dd70ef5-f8d2-444c-9e42-2c6d8d976e90@kernel.org> (raw)
In-Reply-To: <DM4PR84MB192724F4949F614E3965E60A8852A@DM4PR84MB1927.NAMPRD84.PROD.OUTLOOK.COM>

On 30/03/2026 16:53, Hawkins, Nick wrote:
> Hi Krzysztof Kozlowski,
> 
>>>  maintainers:
>>>    - Nick Hawkins <nick.hawkins@hpe.com>
>>> @@ -18,6 +18,11 @@ properties:
>>>            - enum:
>>>                - hpe,gxp-dl360gen10
>>>            - const: hpe,gxp
>>> +      - description: GSC Based Boards
>>> +        items:
>>> +          - enum:
>>> +              - hpe,gsc-dl340gen12
>>> +          - const: hpe,gsc
> 
>> What sort of ordering are you going to use in this file? Usual choice is
>> the fallback compatible, but I see you have chosen something else. That
>> is fine, just keep that else sorting in the future instead of adding to
>> the end.
> 
> Thank you for the feedback, just to confirm are you looking for me
> to do something like this?:
> 
> - description: GSC Based Boards
>         items:
>           - enum:
>               - hpe,gsc-dl340gen12
>           - const: hpe,gsc
> - description: GXP Based Boards
>         items:
>           - enum:
>               - hpe,gxp-dl360gen10
>           - const: hpe,gxp

Yes, that's the typical/usual way.

> 
> That way we have the newest first and going forward if there is

Usual order is the alphanumerical.

> something newer we add it to the top of the list rather than
> the bottom?

If you want to order by date of release of the SoC, that's fine. I think
Allwinner does it. It's pretty non obvious because the chips are
upstreamed different time than released, so it is difficult for people
knot knowing the release dates. Just don't use the rule of "add at the
beginning" or "at the end".

Best regards,
Krzysztof


  reply	other threads:[~2026-03-30 14:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-27 17:44 [PATCH v3 0/3] arm64: Add HPE GSC platform support nick.hawkins
2026-03-27 17:44 ` [PATCH v3 1/3] dt-bindings: arm: hpe,gxp: Add HPE GSC platform compatible nick.hawkins
2026-03-28 14:00   ` Krzysztof Kozlowski
2026-03-30 14:53     ` Hawkins, Nick
2026-03-30 14:57       ` Krzysztof Kozlowski [this message]
2026-03-27 17:44 ` [PATCH v3 2/3] arm64: Kconfig: Add ARCH_HPE platform nick.hawkins
2026-03-28 14:00   ` Krzysztof Kozlowski
2026-03-27 17:44 ` [PATCH v3 3/3] arm64: dts: hpe: Add HPE GSC SoC and DL340 Gen12 board DTS nick.hawkins
2026-03-28 14:03   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7dd70ef5-f8d2-444c-9e42-2c6d8d976e90@kernel.org \
    --to=krzk@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nick.hawkins@hpe.com \
    --cc=robh@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox