From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C8AEC001DE for ; Fri, 28 Jul 2023 08:19:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jD9pbp2MiS6chChcVPDAXsY1lg/zCQOQ8klpeWquNV4=; b=rtgAqfRH8WeqM7 UGwUVeMu/1z2uTlupFPXUIjCUF/id4F6wzzqgcaO8+u2wvBELpqLDtfJ+AKRjneP++oGq3zSBl7x6 gY2OYHhxz3zwi1c5pgcUa3OWF35z3zId/K8ZWxTPDSt9r4Y0SYoNRixsPSTPHzxiYCt7yxnw9c54o xN7It38p1zQ5wG0ELQ8uT6PLtlpvA7NDyIuoQBx01Muwr/ywD1MdP+QSP0cmXekDk3kL17DbWkxbo n9JGKPpEgy+tGXhiwXWdgSXMDQqIQOsbZdenjgo0EesPSwC/9lu6pgVRccyLtEhEqORy0BUfA4ZVr WXAvJwJxJpEHJGLgGb5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qPIgk-002N6d-0H; Fri, 28 Jul 2023 08:19:06 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qPIgg-002N56-2g for linux-arm-kernel@lists.infradead.org; Fri, 28 Jul 2023 08:19:04 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 016146203F; Fri, 28 Jul 2023 08:19:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BCACC433C8; Fri, 28 Jul 2023 08:18:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690532341; bh=fi+a2t7tNdwyL0bBeVh7ZcTqwoG6vf1Wbk6bUaq+pLc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=AtjGgYEAp+/8NgBK9Vt9i/NstWExo712ZM4PRxLAXz+yMXci14VaBM555GppP8SWM nSnm8b+KUfTZcEeZEg69EpQqnbfKRCiU0D65eygmQSlyyDWFZFWuT+Iy37SmWFCneN xlsHeRiip7ODldMLdmA6E1goHgoLp+zKTqSRAIdG7u0oKUe7O2butxJ3paF/d05tVN xzjARnEXcifNHk7SdOG+IAFPW/8xdtzKjXYL9rw7J4R4QL051WLdwaUiyHgIInzqqu GOqqKjgolWMNzTojYe+LTdEttPWoEcR4PSU0Z4MCpu2ilkrwLYpf0ECDZCsOitNjQs 9jvMF3qAmrzLA== Message-ID: <7dea9abf-4ab4-55ec-5a00-829840b221c2@kernel.org> Date: Fri, 28 Jul 2023 10:18:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/2] media: dt-bindings: imx519: Add IMX519 DT bindings Content-Language: en-US To: Umang Jain , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Lee Jackson , Mauro Carvalho Chehab , Sakari Ailus , Laurent Pinchart , Hans Verkuil , Shawn Tu , Nicholas Roth , Mikhail Rudenko , kieran.bingham@ideasonboard.com, Marco Felsch , jacopo.mondi@ideasonboard.com References: <20230727154108.308320-1-umang.jain@ideasonboard.com> <20230727154108.308320-2-umang.jain@ideasonboard.com> From: Krzysztof Kozlowski In-Reply-To: <20230727154108.308320-2-umang.jain@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230728_011902_979602_AB806C55 X-CRM114-Status: GOOD ( 22.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27/07/2023 17:41, Umang Jain wrote: > From: Lee Jackson > > Add YAML device tree binding documentation for IMX519 CMOS > image sensor. Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC (and consider --no-git-fallback argument). It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. > > Signed-off-by: Umang Jain > --- > .../bindings/media/i2c/sony,imx519.yaml | 113 ++++++++++++++++++ A nit, subject: drop second/last, redundant "DT bindings". The "dt-bindings" prefix is already stating that these are bindings. > 1 file changed, 113 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml > > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml > new file mode 100644 > index 000000000000..6f38b09890d2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml > @@ -0,0 +1,113 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/i2c/imx519.yaml# Please test. > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sony 1/2.5-Inch 16Mpixel CMOS Digital Image Sensor > + > +maintainers: > + - Lee Jackson > + > +description: |- > + The Sony IMX519 is a 1/2.5-inch CMOS active pixel digital image sensor > + with an active array size of 4656H x 3496V. It is programmable through > + I2C interface. The I2C address is fixed to 0x1A as per sensor data sheet. > + Image data is sent through MIPI CSI-2, which is configured as either 2 or > + 4 data lanes. > + > +properties: > + compatible: > + const: sony,imx519 > + > + reg: > + description: I2C device address Drop description, it's obvious. > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + VDIG-supply: lowercase > + description: > + Digital I/O voltage supply, 1.05 volts > + > + VANA-supply: lowercase > + description: > + Analog voltage supply, 2.8 volts > + > + VDDL-supply: lowercase > + description: > + Digital core voltage supply, 1.8 volts > + > + reset-gpios: > + description: |- > + Reference to the GPIO connected to the xclr pin, if any. > + Must be released (set high) after all supplies and INCK are applied. > + > + # See ../video-interfaces.txt for more details > + port: That's not how this is done. Open existing bindings, e.g. imx219, 258 or any other and look. Please, do not write patches entirely different than all other drivers/bindings. There is a reason why some things work but other don't > + type: object > + properties: > + endpoint: > + type: object > + properties: > + data-lanes: > + description: |- > + The sensor supports either two-lane, or four-lane operation. > + For two-lane operation the property must be set to <1 2>. > + items: > + - const: 1 > + - const: 2 > + > + clock-noncontinuous: > + type: boolean > + description: |- > + MIPI CSI-2 clock is non-continuous if this property is present, > + otherwise it's continuous. > + > + link-frequencies: > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint64-array > + description: > + Allowed data bus frequencies. > + > + required: > + - link-frequencies > + > +required: > + - compatible > + - reg > + - clocks > + - VANA-supply > + - VDIG-supply > + - VDDL-supply > + - port > + > +additionalProperties: false > + > +examples: > + - | > + i2c0 { i2c > + #address-cells = <1>; > + #size-cells = <0>; > + > + imx519: sensor@1a { drop the label imx519. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel