Re: [PATCH RESEND v4 4/4] drm/rockchip: dw_hdmi_qp: Do not send HPD events for all connectors

[Cristian Ciocaltea <cristian.ciocaltea@collabora.com>]

On 3/30/26 7:56 PM, Heiko Stuebner wrote:
> Am Montag, 23. März 2026, 18:45:30 Mitteleuropäische Sommerzeit schrieb Cristian Ciocaltea:
>> In order to optimize the HPD event handling and run the detect cycle on
>> the affected connector only, make use of
>> drm_connector_helper_hpd_irq_event() instead of
>> drm_helper_hpd_irq_event().
>>
>> Additionally, move devm_request_threaded_irq() after bridge connector
>> initialization.
> 
> nit: Using "and", "additionally", etc in commit messages, is a strong
> indicator, things should be separate commits.
> 
> Especially as the sentence above just explains the "what" but not the
> why (interrupt firing, before the device is actually there probably).
> 
> If there are no other changes requested, they can stay together though,
> the "why" is somewhat obvious here.

Ack, will split this up in case a new revision is needed.

> 
> 
> Both changes themself look fine, so
> 
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>

Thanks for the review!

Regards,
Cristian