From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E24C9C3DA4A for ; Fri, 2 Aug 2024 19:16:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nuMZQLG+k7tqWNRdKUj/uVwRkDzgvYcOELnZoHgbJTo=; b=0W4eCxPwb7xa0KerAEt2ZuqNWh bi/iEY/qCLYaHa/nk3Ss6FZ/NJ7tzN1GIuFumM9PpmyWSpmAWXVh7kHEOIIIvbXgnTyEy4I//kC/A 86azYZS7jAkbjXz5gfUyP+h1JoNyGXvqqhDdeJPkLDH1NqxXWsPZGePnc6J6pxXx5nm+aXdwjonve eWSktRCSyUYkuZafusEZRvAoqyZoXdVoTQa7uR5GFeoRxL8SjNDTXdnOeZgHxoyk6oeJa7SZ8/w5I 8PaDN+3xZ8/k5MyaDPkIzN5FMNKaFDYPogD/KJoWQyYfRslHfhTmN0ce/doIEuO1Gelp/FfTb3TOe Uy1tKvyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZxld-00000009q2r-2FMg; Fri, 02 Aug 2024 19:16:45 +0000 Received: from mout.gmx.net ([212.227.17.21]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZxl8-00000009pxT-0fzp for linux-arm-kernel@lists.infradead.org; Fri, 02 Aug 2024 19:16:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1722626170; x=1723230970; i=wahrenst@gmx.net; bh=nuMZQLG+k7tqWNRdKUj/uVwRkDzgvYcOELnZoHgbJTo=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=RwUhhNcVlU69Mo+z5cNCqQ7dfYj2IrWTc/zKM3ganhV0WoqM1vxaz1nPwG6g+qRb gkBFvDTTqUhtb0gw3tQDiu+XqCCGlj/A5St9BgMNPvDoaDNkKY2ZEk3NgvxH6f2JC ZJgyTlniF/bfRhtnLXc5RttDM28Ypxls7keBYjnl/MsvTW/3JsNqVG7wQ/gPL478X USqWUexa04XOiILQFoPsjf1DOsaV/PuMMTxmH62XG/ISx7a4ZgZbSfURvLRaimMBA qY7DpK3FJmZgG6eoTCw1pZo7hxhbDsq/vS0EQPM52Am8vDzl8RObMxCJm9fJeAs+s +iDx2Zt/koWd12ty6A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.127] ([37.4.248.43]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MYNJq-1snjND3re6-00JLEE; Fri, 02 Aug 2024 21:16:10 +0200 Message-ID: <7e4031c8-5192-40c1-bd11-9101e98a8612@gmx.net> Date: Fri, 2 Aug 2024 21:16:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/7] arm64: dts: broadcom: bcm2712: Add pin controller nodes To: "Ivan T. Ivanov" , linus.walleij@linaro.org, robh@kernel.org, krzk+dt@kernel.org Cc: conor+dt@kernel.org, florian.fainelli@broadcom.com, andrea.porta@suse.com, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20240731062814.215833-1-iivanov@suse.de> <20240731062814.215833-5-iivanov@suse.de> Content-Language: en-US From: Stefan Wahren In-Reply-To: <20240731062814.215833-5-iivanov@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:ywLruciPJhyfNk/9frrJo/ZeOMJR5Zip1gagCKq4GvAt2Yf1Rjh KXVT9evHNSRXYqPbam9IrPPzoaSbIiqVa5UQvF3gNkpHTV6noZRi13OtywGdJcOcOgH7vCq 5GEDgChdXstDP4EJjzlj9c80E2WvHDDVLx5fWtaj3HOlwAU70KBwtajOz3qtcU0IruxksqV lDeYFK7XAdWTnL+padUWQ== UI-OutboundReport: notjunk:1;M01:P0:MqI8FP61bAM=;Kg/kzJ92XgR+hYD7I6YUVv9Fm85 pRTJ3vqoqYV+Cijys9YmsqniaWxJ3Z0zhil6PSQmbk8vMjsQ1aWuI7PPbdgJLjkNVfpXTQ1+I LfK6WPNhq7G2NXWm38Qrd5Eyg55nhN0VbqyGIvlG2KAgFluHL8Qt1VkNci8VKBHT7lrugN0Ny jg2GLi5P+K8KjkF3gNmkbaB9ZQNH2CbJb9zO7gwQsIl+ZkepQqLweOslgsUyp8ygAZwix5P73 WGkJK9ry2FBEXshsAflAmBwLMZT5xm8qfWArY6pB7NjvUGgp3IA0A4tslymM+lpVjkLmTUk6V XJnkLJJ45kbsdSCDyVmZlmhBlTgtButIgJG7m0NzxsLA5MjUbdESnUfb8PafSPRQYhUiJ6ExB HQ6LKX4LskIdHHAAcaGM6oDNE0vocHPl8uTHDqbFGIH5TDd9Ywp/wXtHgfhzwSSWhOX6TvQnc e9MCHq16X4fmnJPSJgs2xGl58SzyQxBQUZ9Me75kKJhOSfCGmGv8NGg+UK+CrllCzA100fXau vlQztVXRtPJq+ku8DzG7F5R8GMOp+Fo4yPt7L0v+7ky1ETLbShSZRffQ9453hQNSaz+Obx+UA kJZvYM+MTcL1Ouioxdgyje5871Ur5LHHMdUTjQDVrA9gy0rO8u5zSwc41TRO+bA3J0DqHzUwT E2NAVVjPF67lhkyngszCeAGRSwWx4xRCW/CGo11Jst2RgZuwqbYxMBXCltwo298KoNnOVquVv mb8VQp+bNeWLUmYblpjGa8JMYHFOGAO8MJ+JW2xW6P+BW+JkAOCjVrALTAeJnxmlRrkYLUoVc kmFzaNxoulVWFWvYlnalwJBg== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240802_121614_515619_64E88118 X-CRM114-Status: GOOD ( 11.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am 31.07.24 um 08:28 schrieb Ivan T. Ivanov: > Add pin-control devicetree nodes and used them to > explicitly define uSD card interface pin configuration. > > Signed-off-by: Ivan T. Ivanov > --- > .../boot/dts/broadcom/bcm2712-rpi-5-b.dts | 20 +++++++++++++++++++ > arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 10 ++++++++++ > 2 files changed, 30 insertions(+) > > diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts b/arch/arm= 64/boot/dts/broadcom/bcm2712-rpi-5-b.dts > index b5921437e09f..8a0d20afebfe 100644 > --- a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts > +++ b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts > @@ -53,10 +53,30 @@ &uart0 { > > /* SDIO1 is used to drive the SD card */ > &sdio1 { > + pinctrl-0 =3D <&emmc_sd_pulls>, <&emmc_aon_cd_pins>; > + pinctrl-names =3D "default"; > vqmmc-supply =3D <&sd_io_1v8_reg>; > vmmc-supply =3D <&sd_vcc_reg>; > bus-width =3D <4>; > sd-uhs-sdr50; > sd-uhs-ddr50; > sd-uhs-sdr104; > + cd-gpios =3D <&gio_aon 5 GPIO_ACTIVE_LOW>; > +}; > + > +&pinctrl_aon { > + emmc_aon_cd_pins: emmc-aon-cd-pins { > + function =3D "sd_card_g"; > + pins =3D "aon_gpio5"; > + bias-pull-up; > + }; > +}; > + > +&pinctrl { > + > + emmc_sd_pulls: emmc-sd-pulls { > + pins =3D "emmc_cmd", "emmc_dat0", "emmc_dat1", "emmc_dat2", "emmc_dat= 3"; > + bias-pull-up; > + }; > + > }; Please keep the references in alphabetical order (pinctrl comes before sdio). Except of this: Reviewed-by: Stefan Wahren > diff --git a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi b/arch/arm64/boot= /dts/broadcom/bcm2712.dtsi > index 398df13148bd..1099171cd435 100644 > --- a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi > +++ b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi > @@ -266,6 +266,16 @@ uart0: serial@7d001000 { > status =3D "disabled"; > }; > > + pinctrl: pinctrl@7d504100 { > + compatible =3D "brcm,bcm2712-pinctrl"; > + reg =3D <0x7d504100 0x30>; > + }; > + > + pinctrl_aon: pinctrl@7d510700 { > + compatible =3D "brcm,bcm2712-aon-pinctrl"; > + reg =3D <0x7d510700 0x20>; > + }; > + > interrupt-controller@7d517000 { > compatible =3D "brcm,bcm7271-l2-intc"; > reg =3D <0x7d517000 0x10>;