Re: [PATCH v3 17/18] media: venus: Refactor hfi_session_fill_buffer_pkt

[Vikash Garodia <quic_vgarodia@quicinc.com>]

On 5/28/2024 2:39 AM, Ricardo Ribalda wrote:
> The single data array data[1] is only used to save the extradata_size.
> Replace it with a single element field.
> 
> This fixes the following cocci warning:
> drivers/media/platform/qcom/venus/hfi_cmds.h:175:5-9: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
> 
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
>  drivers/media/platform/qcom/venus/hfi_cmds.c | 2 +-
>  drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.c b/drivers/media/platform/qcom/venus/hfi_cmds.c
> index 0a4de8ca1df5..3ae063094e3e 100644
> --- a/drivers/media/platform/qcom/venus/hfi_cmds.c
> +++ b/drivers/media/platform/qcom/venus/hfi_cmds.c
> @@ -331,7 +331,7 @@ int pkt_session_ftb(struct hfi_session_fill_buffer_pkt *pkt, void *cookie,
>  	pkt->alloc_len = out_frame->alloc_len;
>  	pkt->filled_len = out_frame->filled_len;
>  	pkt->offset = out_frame->offset;
> -	pkt->data[0] = out_frame->extradata_size;
> +	pkt->data = out_frame->extradata_size;
>  
>  	return 0;
>  }
> diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/platform/qcom/venus/hfi_cmds.h
> index f91bc9087643..daba45720ddc 100644
> --- a/drivers/media/platform/qcom/venus/hfi_cmds.h
> +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h
> @@ -172,7 +172,7 @@ struct hfi_session_fill_buffer_pkt {
>  	u32 output_tag;
>  	u32 packet_buffer;
>  	u32 extradata_buffer;
> -	u32 data[1];
> +	u32 data;
>  };
>  
>  struct hfi_session_flush_pkt {
> 
Acked-by: Vikash Garodia <quic_vgarodia@quicinc.com>