Re: [PATCH 0/2] arm64: smp: Include smp_plat.h from smp.h

Florian Fainelli
2019-05-30T23:20:57Z

On 5/30/19 4:17 PM, Russell King - ARM Linux admin wrote:
> On Thu, May 30, 2019 at 04:14:28PM -0700, Florian Fainelli wrote:
>> On 5/30/19 4:05 PM, Florian Fainelli wrote:
>>> Hi ARM64 maintainers,
>>>
>>> This patch series aims at enabling irq-bcm7038-l1.c on
>>> ARM64/ARCH_BRCMSTB, this driver makes use of cpu_logical_map[] and in
>>> order to avoid adding a CONFIG_ARM64 conditional inclusion of
>>> smp_plat.h, instead smp.h includes smp_plat.h, which is in turn included
>>> by linux/smp.h.
>>>
>>> If you like the approach, I would suggest to carry that through the
>>> Broadcom ARM64 SoC pull request for 5.3.
>>
>> ARM (32-bit) needs the same thing kind of thing so a conditional include
>> may be appropriate after all...
>
> The whole idea of the smp_plat.h vs smp.h separation is to avoid
> including lots of arch-private stuff in the rest of the kernel
> build, thereby exposing arch-private stuff to the world. I'm be
> opposed to that.

I was on the fence, sent it just in case, but ended up doing this:

https://lore.kernel.org/patchwork/patch/1082410/

will take patch #2 through the Broadcom ARM64 SoC tree once this patch
above gets accepted.
--
Florian