From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82421CD4F39 for ; Thu, 14 May 2026 12:52:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:Date:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Bc8V6/bs+HTXOBlN7h+U1C4FS7zyRn51Jy32DFGr7aU=; b=1xPtZ33dsUaxK9CMLFm6RzyTqo IToVasILpLhy0F2Mi70gpaZ0li1r5LuZQGwgiCAKrAr8x6VWLC9o2Jpkbhq/Mny8oYufON4cWTvhm T0ZsK2yHx172sojSbGD07OGze1fOZp9sWF7TKcpcsPYm5PWJWJ+dUnn55P6Tn6p3RfnxwFSgux18l P7XGewlHuMR4bsBirXOVfxjxpraOhy+smT3GxLbS6394UUJfm0sNAuvjyr2POdmZHK7cw/6E6xEPk nbLWYN35XH/Ln5bMKwltByV3tqrzOEJIhk/M5pEBp5IywYDqKclQl0dPwlcWZjvg97wLndDX0kJuJ tGDKQ2qQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wNVYM-00000005WBV-39tI; Thu, 14 May 2026 12:52:38 +0000 Received: from mail-westus2azlp170100005.outbound.protection.outlook.com ([2a01:111:f403:c005::5] helo=CO1PR03CU002.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wNVYK-00000005WAR-0Ioa for linux-arm-kernel@lists.infradead.org; Thu, 14 May 2026 12:52:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cvikDp6fn53rx8x66QrPrymtlizBuQ0yfwRPNwgmNTwjCP43wzI2bqRrbiPjQw7nTAdZDUn0/uBxDKtNU5OQDL4kpIY9nIZVpd1Zr2ggZhk+0rug6r4o0t/sn1kkZwUY+L0S0NhVXNgJUMj9AXWAJsUDIns3fzJUZ3NPCIjKZy//+gC3cnK6+8XvcODurg4RSWuEQ2A5bvTEAy1/Nd4CaEuxeWaSytzVdPuX3BtSGBQNKDe4qqFLcIFZ/vZXAQC/3sCDB+2H0R+XBQtH2TyrQ3ehIor8gv7M91zSMcMMz7thXv6/oTiAjrda3ZrkhoXSG4TS1bbEqWC5Tr2X//2IiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bc8V6/bs+HTXOBlN7h+U1C4FS7zyRn51Jy32DFGr7aU=; b=Mtk8pgOY8vN9IVWT3A5EH0ZCMK8wMbbfIukXwjxYI+6ijfbS/sq1DCWVHOOmnRuMV+/cx9/vNfb0ZJVqixg+i4WCs/3vO69Vyoh9Rb7HpwQp08q2jXpArIdiEkIGQYiw02ZHQ3AoWJgYpbp6tDpeS03E/Q0C5yjwzTQZfTsRuQBOwlpfdlKJjFFDBydoOe7QtPjrcATDv/jozn54ukw6ONtn7eWVzl2t03IXhPMnmkzGn4roN95msclVAHBf0EHSUu2bfE+HP4StGxeVAMf9EutEEyuvNaLZKTCDarlE7EtqGIjVke3S8t/OMZSQPuSU37utDnj9Z2pUeOhBTA8XeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bc8V6/bs+HTXOBlN7h+U1C4FS7zyRn51Jy32DFGr7aU=; b=RfWEDwpSU9R9glSyWfB6kxcAWS0DL6EdjGF+Te8jJQrCaMeYcwrONqpVv+pjlBZNbVaKLBzG9Bujt7LUa+Zj5iCYfwW/5yy61a8ls/mht5/KSDuEStXhUXiWAg/HMVxKeBGIsF1IUNfQGX/xRNhbJrgjSO5fFHdFHd+nlctPd90= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CY1PR12MB9697.namprd12.prod.outlook.com (2603:10b6:930:107::6) by DS7PR12MB5885.namprd12.prod.outlook.com (2603:10b6:8:78::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.18; Thu, 14 May 2026 12:52:26 +0000 Received: from CY1PR12MB9697.namprd12.prod.outlook.com ([fe80::3a41:55a0:8203:596d]) by CY1PR12MB9697.namprd12.prod.outlook.com ([fe80::3a41:55a0:8203:596d%5]) with mapi id 15.20.9913.009; Thu, 14 May 2026 12:52:26 +0000 Message-ID: <7eca29f8-9847-4ee1-ae3c-8c507bc295c7@amd.com> Date: Thu, 14 May 2026 18:22:18 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] usb: dwc3: xilinx: fix error handling in zynqmp init error paths To: Thinh Nguyen , Radhey Shyam Pandey Cc: "gregkh@linuxfoundation.org" , "michal.simek@amd.com" , "p.zabel@pengutronix.de" , "linux-usb@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "git@amd.com" , "stable@vger.kernel.org" References: <20260511160814.2904882-1-radhey.shyam.pandey@amd.com> <20260511160814.2904882-4-radhey.shyam.pandey@amd.com> Content-Language: en-US From: "Pandey, Radhey Shyam" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN4P287CA0059.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:270::10) To CY1PR12MB9697.namprd12.prod.outlook.com (2603:10b6:930:107::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY1PR12MB9697:EE_|DS7PR12MB5885:EE_ X-MS-Office365-Filtering-Correlation-Id: 27d9fd36-cd9b-4ff6-3ed7-08deb1b7a655 X-LD-Processed: 3dd8961f-e488-4e60-8e11-a82d994e183d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|56012099003|18002099003|22082099003|4143699003|11063799003; X-Microsoft-Antispam-Message-Info: 4jb32SzUNworv0c1kvjsp3aLH+y1A4aWuIfCUvxMNQHKvgo+a+km8w8qAqQrutaIQAR2QCc1ObVnfPzRWtMrXSDU7Z5DSoLBgJS8GE4JA4SRtINgfocPxedRDBs7FTfl+7knwKwQHnsJnPA3ui4C2jLfT9KNzxeBLXtyI4+t5LUjmkAthUnnKtAWwOtAo0Mh8Bhk4wi17mj0BdUXxwkaMv/pjmYTEWk1sZozlP6F4WptRJdmdlkaYMhzW3ThJYVqddrie1AMKW6FsizVRp8AO9DoDoy6RN/t5y/KKGzb1ywTdtk+DAnXCeBlqP2uzbm2JuXHq2bZ037a0ngEGQ1fsbaLOvy8ZmgjPfwAcX+RFUT2PeoKjIIWcwQL0/rxjcqNIy+ceOesMC/y//RCeSh1lJY67IAIW4h5Ok/2nk1/52XYy6oSbn8sEZb07CXLONLY6LVsh7Ddgr4HtXE1OK32Ltkk+FgxN0v4QjjdZwrQSEN5q8nheaoT3ttfgVQn6DabrCTG+KoFuApaWbPWLqOE9iX+lljXEnm/CcnFHsR8cuoDNlKBls0ZbKKKmqylD5InL4tFhLEkmu+Ki1VTYeFzZ+0E/DGhW7nAuPJOSMpI10og1YLtRRt/GOCW3uCBdDHVfsw66lJqmi3dAZnQDlkJJI2WS8ktTBwIhSF+hrJAv4LKb00c120f1ur16tP2HIRu X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY1PR12MB9697.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(56012099003)(18002099003)(22082099003)(4143699003)(11063799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGE2VjdjRUo5TFoyVmM5cFc1WFIyVDh4azMvN0JvSUtIK09SRFBHSVlnZlY2?= =?utf-8?B?N1ZSWEQ5dmdHUC9Pd0hyOWFXanZ1eG9TQmFBazJldkU1WXkwcTJjcG82cWtx?= =?utf-8?B?U3JhNGNoME40UzdpQmxMcDZBNWpSQ1U0YnMrU0QyRTJPWjZ4RkJrZFJWMCtO?= =?utf-8?B?OFFtK1o2ZkU0aHNzdGFFTGtGMzNRYXZHV1JVT293VlJuY3dwdkJHczZCcHMr?= =?utf-8?B?ME54bFF5QXRrMHhlVS9sUTM4U055UVpkM1o0bWM0TVg0QTRLQ1hqSXU4clBE?= =?utf-8?B?TUZ0ZlBTL1pUbjFUV0QxQlFKODl4c1YzbGVUYWZVdSt1MUlLTlFreW5uQWxy?= =?utf-8?B?T0xyMEpyU1hOc0FqcFNva05nQVZoaVhBM3RTUUszaTN0S3VDSVpOY0pTSjdW?= =?utf-8?B?dFM4SG9hSHd5dzNCVlh5NHZwcWFuWkdDbjhJazBMY2lFR1J2ZEgwN2d4L3ZV?= =?utf-8?B?K21HZWlTWENYRkJnQlZKdXFWQmwyQTBUazUrckNJNDNWTEpHWVV0cGRjcXd6?= =?utf-8?B?MCtnWDdlaTRIK3JXMlF4cVpSK3dDUUN2ZFJsUDdXVGRHVVM4UEU1NVhMTzBq?= =?utf-8?B?TERyUGp1bTFFdnByS3JsUWNzOWRFMzVNcmcrUUJja0c4M00vS041ZzhRbVc1?= =?utf-8?B?ZFFEWC82VWhIbzlnNkJjUkoxcjJpVmI2QXdReWloeGlDcS9Cb0FSbW9yL2lV?= =?utf-8?B?SkNMRXlIVWpXZVNrSUFmQjB5elZaUGtKMVdKdVp3V3V5eUpKUks2S1JydlE0?= =?utf-8?B?TDMvWWZTMWdhTFl5QkZVTEhoN256aW84cWN4b201eGdsQkdvQ1JTRW5TZk5L?= =?utf-8?B?V3dIbzRWbi9LVVVMMEs1cXlyeVdPZW8yTTJNMWFlV3E5bGdZQWpESVpqVUxn?= =?utf-8?B?aGRjVmFTZXdIdGtrWWgyWjJvbk1ZZlFPbjFqZ2JPZDZhTDIzbFJpNjAxQ0pM?= =?utf-8?B?ZU5zZ1NQL0ZiUGI1SjA5MWxwZ1l2TVVCQ3VXMFExaG0xa3BRbTlJclJndEph?= =?utf-8?B?OHlNQVBHRSs1V0ozTW8wRi8zLzhUVlJTRkpHbkU2b0ZkSmRadTQ0aXVtVDAv?= =?utf-8?B?eDF3QVJZMlBjci9uNGpLWER1ZEtPWW9mcmsxZmdUdTdwUFkvdVUyUnA2TXNO?= =?utf-8?B?MlY1NXBsR045SHgrbUVaZG5rMUgvMmxqQ29FVmVhQjFxaUtEUEw2a2Z2UDhI?= =?utf-8?B?ckJPNWRSOEg2d3NiOEtyTkpFVWRUQm9xQ0k0MHA2KzFycnBEaVdqb2dIVkpG?= =?utf-8?B?c2JVUEQvVHpOb3Qxd0VOWGVlUGpzWDZnK0VUbnBkMHAwS0dkNmRvN09CbHVr?= =?utf-8?B?Ly95Ni8yZDdLZ28vKzVqQzdHbmIrdGE4YnZCZ1BtVk55c0ZEWTFjaTBtZmtO?= =?utf-8?B?OXRrWGtyWHkyUUdaQ3BReUR2amhJRjlSNDVpQ2lmY2J3T3lmZzdNU2JWZmp3?= =?utf-8?B?cFRDNGgrUE1TVDNodSs2QkloRmxjNytFR01nSWVCUXRxN0w4bnlVM0NPOVln?= =?utf-8?B?S084TSthUDZDRlZJUjJ0U1N5SDRqbUdJVktJbUp6SC9GTUhlaVh5K0xrRUdG?= =?utf-8?B?V0pJTnRRd3FJWGZlcVVHbUVTdm10a1ZOQ1o3eE91MmlVNWkwTWF5WXArWnVI?= =?utf-8?B?bC9GbFJBOU85V3FVaWdWL2tuVzFISWxlemFlU2xhVURZUmZ3eEpWek5FMmlQ?= =?utf-8?B?VlFHMEo4VHBvdXlwZFRsdHJyajV5ZGcxMWxEVVMrOFpZV1EvbkhzUy83bDFq?= =?utf-8?B?akpvUjRaM09zU3VXcWhMV3dXRTZVckdoYXBsMktSbm1qVi9FMGN3WjBncW9U?= =?utf-8?B?MFplNDM2dCtpYzYzUVBUV3M0OWlTSittSG14VW1ZQmQ5RjZkc3BiTnBRZWN4?= =?utf-8?B?ZWwxZDBVNE5QY1JadjJlcUllQUxuNlV1UzFEZXJyaStrNEp2QjVycVdOWCt0?= =?utf-8?B?RjI2VkpEZG9ITHFQdXhjSGNTMlJNWmxDZjU0WXVERkYyWUE3UWlmS1RUMjUx?= =?utf-8?B?azBncUJlSGphMXFpSXZKVEVDNnJBZDcyalFxUWpXS09JWnV3dmZ0SzJ5OGdX?= =?utf-8?B?VExWT01YQ1Z0MkJXYjNvbVRxQnJXUnpoT3JJa0c1U0JrUHAxUFdicUhFblpp?= =?utf-8?B?b1BnMjZKRHdBdVQwdVVRN0tBTit3NnZVL1hBdGZUSlJqYTJaUm1JK1lKUmJ4?= =?utf-8?B?S0RqWVdFSURDbm9CaDBYYVc1Smtha0lPTlY0blhvSXgyaEEzQ2xudzBYaXBu?= =?utf-8?B?eUFYQUxKb1JPVE1vbmdyOG55a0tnTDZRS056TldIaDczbUdoSUJwT0VuN3U0?= =?utf-8?B?TktTc1R0dUFPVVJwREtaLzVwOUpJSFJBUXBlSTQ4bVpxNndNWURjUT09?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 27d9fd36-cd9b-4ff6-3ed7-08deb1b7a655 X-MS-Exchange-CrossTenant-AuthSource: CY1PR12MB9697.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2026 12:52:26.4147 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FpDOEav3jtCb/r3okzvXPHHAoDR8afHq8W3JxH6evlSj3MQsgLZ7aHIG1675eO7k X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5885 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260514_055236_260293_587A9D11 X-CRM114-Status: GOOD ( 17.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/14/2026 7:13 AM, Thinh Nguyen wrote: > On Mon, May 11, 2026, Radhey Shyam Pandey wrote: >> Fix error handling and resource cleanup i.e remove invalid >> phy_exit() after failed phy_init(), route failures through >> proper cleanup paths and return 0 explicitly on success. >> >> Fixes: 84770f028fab ("usb: dwc3: Add driver for Xilinx platforms") >> Cc: stable@vger.kernel.org >> Signed-off-by: Radhey Shyam Pandey >> --- >> drivers/usb/dwc3/dwc3-xilinx.c | 27 +++++++++++++++------------ >> 1 file changed, 15 insertions(+), 12 deletions(-) >> >> diff --git a/drivers/usb/dwc3/dwc3-xilinx.c b/drivers/usb/dwc3/dwc3-xilinx.c >> index 94458b3da1a0..b832505e1b04 100644 >> --- a/drivers/usb/dwc3/dwc3-xilinx.c >> +++ b/drivers/usb/dwc3/dwc3-xilinx.c >> @@ -176,15 +176,13 @@ static int dwc3_xlnx_init_zynqmp(struct dwc3_xlnx *priv_data) >> } >> >> ret = phy_init(priv_data->usb3_phy); >> - if (ret < 0) { >> - phy_exit(priv_data->usb3_phy); >> + if (ret < 0) >> goto err; >> - } >> >> ret = reset_control_deassert(apbrst); >> if (ret < 0) { >> dev_err(dev, "Failed to release APB reset\n"); >> - goto err; >> + goto err_phy_exit; >> } >> >> if (priv_data->usb3_phy) { >> @@ -200,26 +198,24 @@ static int dwc3_xlnx_init_zynqmp(struct dwc3_xlnx *priv_data) >> ret = reset_control_deassert(crst); >> if (ret < 0) { >> dev_err(dev, "Failed to release core reset\n"); >> - goto err; >> + goto err_phy_exit; >> } >> >> ret = reset_control_deassert(hibrst); >> if (ret < 0) { >> dev_err(dev, "Failed to release hibernation reset\n"); >> - goto err; >> + goto err_phy_exit; >> } >> >> ret = phy_power_on(priv_data->usb3_phy); >> - if (ret < 0) { >> - phy_exit(priv_data->usb3_phy); >> - goto err; >> - } >> + if (ret < 0) >> + goto err_phy_exit; >> >> /* ulpi reset via gpio-modepin or gpio-framework driver */ >> reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); >> if (IS_ERR(reset_gpio)) { >> - return dev_err_probe(dev, PTR_ERR(reset_gpio), >> - "Failed to request reset GPIO\n"); >> + ret = PTR_ERR(reset_gpio); >> + goto err_phy_power_off; >> } >> >> if (reset_gpio) { >> @@ -229,6 +225,13 @@ static int dwc3_xlnx_init_zynqmp(struct dwc3_xlnx *priv_data) >> } >> >> dwc3_xlnx_set_coherency(priv_data, XLNX_USB_TRAFFIC_ROUTE_CONFIG); >> + >> + return 0; >> + >> +err_phy_power_off: >> + phy_power_off(priv_data->usb3_phy); >> +err_phy_exit: >> + phy_exit(priv_data->usb3_phy); >> err: >> return ret; >> } >> -- >> 2.44.4 >> > > This fix should be a separate patch from this cleanup series. > Sure, will split it into a separate patch. Does this patch look fine? If so i can add the Reviewed-by tag in v2 or address any further comments if needed. Thanks, Radhey