From: frieder.schrempf@exceet.de (Frieder Schrempf)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: rockchip: Enable SPI NOR flash on Rock64
Date: Wed, 26 Sep 2018 09:10:17 +0200 [thread overview]
Message-ID: <7ecb43c3-1693-005b-b547-03ca361bd843@exceet.de> (raw)
In-Reply-To: <20180926045357.20722-1-wens@csie.org>
On 26.09.2018 06:53, Chen-Yu Tsai wrote:
> The Pine64 Rock64 board comes with a GigaDevice GD25Q128CSIG
> or GD25Q127CSIG chip, which is a 128 Mbit SPI NOR flash chip
> that supports the JEDEC read-ID command.
>
> This patch enables the SPI controller and adds a device node
> for the flash chip using the generic "jedec,spi-nor" comaptible.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
>
> This was working on linux-next 20180910, but now fails on linux-next
> 20180925, with the following error messages:
>
> m25p80 spi0.0: error -22 reading 9f
> m25p80: probe of spi0.0 failed with error -2
>
> Reverting the spi/for-next branch makes it work again:
>
> m25p80 spi0.0: gd25q128 (16384 Kbytes)
>
> Not sure what's up.
The reason is probably an issue that was introduced here: [1], and it
was fixed here: [2].
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/spi?id=380583227c0c7f52383b0cd5c0e2de93ed31d553
[2]
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/spi?id=4c53f98555fdbf1cc291cab8ffa5e1507a4f25d9
>
> ---
> arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> index 9ee4f57557f3..2170cf63845e 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> @@ -290,6 +290,18 @@
> };
> };
>
> +&spi0 {
> + status = "okay";
> +
> + spiflash at 0 {
> + compatible = "jedec,spi-nor";
> + reg = <0>;
> +
> + /* maximum speed for Rockchip SPI */
> + spi-max-frequency = <50000000>;
> + };
> +};
> +
> &tsadc {
> rockchip,hw-tshut-mode = <0>;
> rockchip,hw-tshut-polarity = <0>;
>
next prev parent reply other threads:[~2018-09-26 7:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 4:53 [PATCH] arm64: dts: rockchip: Enable SPI NOR flash on Rock64 Chen-Yu Tsai
2018-09-26 7:10 ` Frieder Schrempf [this message]
2018-09-26 11:38 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ecb43c3-1693-005b-b547-03ca361bd843@exceet.de \
--to=frieder.schrempf@exceet.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox