From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 314F8CEBF91 for ; Fri, 27 Sep 2024 10:51:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0Cm/CaH+7rnCuQElMA0wHSDFr0ElI/GNiHs3+I9HxOc=; b=0xZxHBGLCm39dVmVDPfI2ZkP5K lTdw5Ykfl/r+QXgYC6sN/JJaty/0YN/YA4IuiADTjd1T/9XNX/Xbbo5Eyjotio3uyyW7/uq6mE//Z LlzOMDtodOYpjKpSbht68lgTrAJUoivY++3gec4XVl72QLzWZXoj4hwIQss/OumyX9A/BBtjb4Q+s R6UzN39b/FbB69PEMeuNAvF1q6caj34soTQaAkzDeKV/yw2+GwmUqFfDfDPz1d3D/fYt+vdmADPyD HV7aLR4Eff0RwXrBTC3zKUvFhEk1mzvzNZ8FWc11si5de4sGzuJZXGFkjrAvUtQ9mJwssZyaftHTG 9q1Vqo2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1su8ZE-0000000AszH-0UPN; Fri, 27 Sep 2024 10:51:20 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1su8Y1-0000000AskE-1h7b; Fri, 27 Sep 2024 10:50:07 +0000 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-20b0c5895aaso2143555ad.1; Fri, 27 Sep 2024 03:50:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727434204; x=1728039004; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0Cm/CaH+7rnCuQElMA0wHSDFr0ElI/GNiHs3+I9HxOc=; b=h+pbkia1DS4iDjuqKylsWa6RhoQe4qxFuQG4ZYl4f1m99h7jGhJu22f5bSVIgQYhP6 dx/iucShP0VZLK0MQ+4V3scZpxGO0398/oDi2a5wyBvl+X7iwfLEom2O3E4242CEYexZ 3NfwqzGIzx/CNPkd3dNEduC9d02nptb9uGrmdin4n/PU/psM2aR5reR4KRvp8QtXxPAV o2mjvNpPjiKdUT5RvT6BZI4Gz2ut+tFuKnyRi1vHNLpc2nMs9zc7/VMgVxpNfDRYPCXK M6rWGioUK0EDCI9Dfn81zVsgfsowZus0YV285ex7/HcTBp8z9wZClOav1KpICaMno4n1 xn5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727434204; x=1728039004; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0Cm/CaH+7rnCuQElMA0wHSDFr0ElI/GNiHs3+I9HxOc=; b=TaKhOZfPeAQ2LNmGD/zh0/pT5oYt3M1VjIoHAAwS75FAkbOIW5AFNqnXmsvU80TFIB UdSYUtuGUHgzk/wciCmTuoMthN92GFvdUVdqeXo8gFxCmS+z7JHQIEz0mLA2+b7IgV9F Etkv7qhuqTk0Ko7fgW4QjINEvoMXI7Rdoj5NnueRZI870uUaH4EeRXHiU2woTfpVo9oI g/hmY7Zca50XaYXuITJLJN63lqBQRmTm8GYzkiApioqy8vAEDkvohn4XaweSQDP2iGAY nqX/xDDP63SP5ia24C8ymL7hXf/1TxTFys9L71Ixs9Vx8w6N0OTm644O45OBy0UkIPzj U5wg== X-Forwarded-Encrypted: i=1; AJvYcCUoLgQlpxnRvxSuw/OKBLAmA+/UrfRS21rNluu3Zmt0b0XB9Gdt4KWRljqdeIdz+5lzcyG/umX3Hc5Bs/+E2gE=@lists.infradead.org, AJvYcCXMHxcxbPuP4nfJKfdRRZmjoHlEvr60R8021FPteDFwZy3ZxcoJBPj4q/zjvJGjmVttcJOr0NheZRDFs7/YQRBX@lists.infradead.org X-Gm-Message-State: AOJu0Yw3mbcYK4buo2rLM8DMG/BKwY8f66j1glfw7W8kFaYs5+JSch0j oOt90s9a401U2MxnxqbvPCwKtF8Cglwd8I5e+I8MGuZOlMY4fHW1 X-Google-Smtp-Source: AGHT+IHSYMyuGVO/gtIn+YKc6BCcgImGwsAagdTinej2ygKLLnFEyRNG87k8Y5G0jBj0H9zg6u8HXA== X-Received: by 2002:a05:6a20:1590:b0:1cf:2be2:8dd1 with SMTP id adf61e73a8af0-1d4fa7adf82mr1868218637.10.1727434203743; Fri, 27 Sep 2024 03:50:03 -0700 (PDT) Received: from [192.168.60.56] ([103.29.142.67]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71b2653726csm1315488b3a.205.2024.09.27.03.49.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Sep 2024 03:50:03 -0700 (PDT) Message-ID: <7eead817-fe37-472d-ab5a-f46133031e18@gmail.com> Date: Fri, 27 Sep 2024 18:49:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] dt-bindings: phy: rockchip,inno-usb2phy: add rk3576 To: Krzysztof Kozlowski , vkoul@kernel.org, kishon@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, heiko@sntech.de Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, william.wu@rock-chips.com, tim.chen@rock-chips.com, frank.wang@rock-chips.com References: <20240926103223.29538-1-frawang.cn@gmail.com> <7944f4dd-96f0-40df-8c91-523409e3cb20@gmail.com> <4b98196a-c898-4d08-9101-31feb4e59b5c@kernel.org> <2815219e-3a20-4a5b-8573-d8a4ad2df1c9@kernel.org> Content-Language: en-US From: Frank Wang In-Reply-To: <2815219e-3a20-4a5b-8573-d8a4ad2df1c9@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240927_035005_470922_89BD8FFE X-CRM114-Status: GOOD ( 12.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, On 2024/9/27 17:52, Krzysztof Kozlowski wrote: > On 27/09/2024 09:59, Frank Wang wrote: >>>> -  clocks: >>>> -    maxItems: 1 >>>> +  clocks: true >>>> >>>> -  clock-names: >>>> -    const: phyclk >>>> +  clock-names: true >>> For the third time, read the code I gave you. Do you see something like >>> this there? Why doing all the time something different than existing code? >> Refer to the link you sent me that I must add minItems property for >> clocks, just like the below codes: >> >> @@ -35,7 +35,8 @@ properties: >>      const: 0 >> >>    clocks: >> -    maxItems: 1 >> +    minItems: 1 >> +    maxItems: 3 > Yes, for all variable properties, so also names. > >> That can pass dt_binding and dtb checking, however, "clocks" is the >> optional property for some old Rockchip PHYs,  I am not sure is it right >> to force set  minItems as 1 . >> If just keep maxItems, the dt_binding checking is failure. > Please specify the question you want to ask. > Q1: The "clocks" is an optional property for some old Rockchip PHYs, so set "minItems: 1" likes the below, is this a suitable setting?    clocks: -    maxItems: 1 +    minItems: 1 +    maxItems: 3Q2: Do you want me to amend the code to like this? clocks: minItems: 1 maxItems: 3 clock-names: minItems: 1 maxItems: 3 allOf: [...] - if: properties: compatible: contains: enum: - rockchip,px30-usb2phy - rockchip,rk3128-usb2phy - rockchip,rk3228-usb2phy - rockchip,rk3308-usb2phy - rockchip,rk3328-usb2phy - rockchip,rk3366-usb2phy - rockchip,rk3399-usb2phy - rockchip,rk3568-usb2phy - rockchip,rk3588-usb2phy - rockchip,rv1108-usb2phy then: properties: clocks: maxItems: 1 clock-names: const: phyclk - if: properties: compatible: contains: enum: - rockchip,rk3576-usb2phy then: properties: clocks: minItems: 3 maxItems: 3 clock-names: items: - const: phyclk - const: aclk - const: aclk_slv Best regards, Frank > Best regards, > Krzysztof >