From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "Rob Herring (Arm)" <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Phil Elwell <phil@raspberrypi.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Conor Dooley <conor+dt@kernel.org>,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Andrea della Porta <andrea.porta@suse.com>
Subject: Re: [RFC PATCH] arm64: broadcom: bcm2712: Rework rp1 overlay handling
Date: Fri, 5 Dec 2025 08:41:38 -0800 [thread overview]
Message-ID: <7f051318-0aaf-454d-8a85-b6d16fa10d2b@broadcom.com> (raw)
In-Reply-To: <ae5d1a37-9af9-46a2-9ca0-83c276248931@kernel.org>
On 12/5/25 00:08, Krzysztof Kozlowski wrote:
> On 17/11/2025 22:15, Rob Herring (Arm) wrote:
>> It's a requirement that DT overlays be applied at build time in order to
>> validate them as overlays are not validated on their own.
>>
>> Simply adding a build time target is possible, but it's also not desirable
>> to have targets which include the overlay contents and apply the same
>> overlay.
>>
>> Rework the targets such that there are 2 overlays: the existing RP1 overlay
>> and the board specific configuration of the RP1 (bcm2712-rpi-5-b.dtso).
>>
>> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
>> ---
>> The missing applying of rp1.dtbo will soon be a warning[1].
>>
>> The comment in bcm2712-rpi-5-b.dts(o) needs updating or removing. The RP1
>> driver or userspace handling of the overlay probably needs updating to
>> handle the 2 overlays. IIRC, I think we can apply overlays to overlays
>> which may be useful here. If not, adding that to the tools should be
>> possible.
>>
>> [1] https://lore.kernel.org/all/20251114222759.4181152-1-robh@kernel.org/
>> ---
>> arch/arm64/boot/dts/broadcom/Makefile | 10 ++++++++--
>> ...m2712-d-rpi-5-b.dts => bcm2712-d-rpi-5-b-base.dts} | 2 +-
>> .../{bcm2712-rpi-5-b.dts => bcm2712-rpi-5-b.dtso} | 11 +++++------
>
>
> So now Linus' tree has warnings. Can this be applied by anyone around
> Broadcom and sent as fixes?
It's an RFC and I was hoping to get Andrea to comment on this patch
before applying.
--
Florian
next prev parent reply other threads:[~2025-12-05 16:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 21:15 [RFC PATCH] arm64: broadcom: bcm2712: Rework rp1 overlay handling Rob Herring (Arm)
2025-12-05 8:08 ` Krzysztof Kozlowski
2025-12-05 16:41 ` Florian Fainelli [this message]
2025-12-09 13:58 ` Andrea della Porta
2025-12-18 13:43 ` Andrea della Porta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f051318-0aaf-454d-8a85-b6d16fa10d2b@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=andrea.porta@suse.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=phil@raspberrypi.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).