From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC124C27C53 for ; Sun, 16 Jun 2024 11:55:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=o/mVBey1pUUAnezlicmXpXgXj8Qwj9yoReY/ospObPs=; b=5EvI3pyffyiALwdZ1wY4WzKc54 xmbJAEzh84CJ4ctJWVlP5UhEczKI/Zmc3i6OPhZ81E3xT/69m2xAkxCWOQxwQ01eMQJJ9BX+SJQnb vzjS4+lRnauvwwki8KY/+HJ3AcRpw5qAh2NtAW1qHX1ydf8oaJYKnFv/vDerEVPA+ury2oMaNVkXt Pgtnr0HKrrWTPCP94J+/BT60XazFDt2DnCrkKGckDp79TyguqEZCwtGUnht6MGxbJ+7y47ln5HFyp JQ7UDgJeMIgoAiZ1XieoMck6Px1X9dLdwhTF6L5S2XOGjZis1pcC1q7GPsnvRHvtaTvrlL4i6c0XI sGOYV/Zg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sIoTr-00000007RoK-1Kxk; Sun, 16 Jun 2024 11:55:31 +0000 Received: from mail.manjaro.org ([2a01:4f8:c0c:51f3::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sIoTm-00000007Rnf-2lqM; Sun, 16 Jun 2024 11:55:28 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1718538921; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o/mVBey1pUUAnezlicmXpXgXj8Qwj9yoReY/ospObPs=; b=lp8NiBCnAttf4fU8LXw3j5OaeEoGWaQYQsnjPLe/cvcoGDXEQvIKZkK9oyjD352fcL9zhl R4ihgLmZMENLAFKITuFMnXgPHWKmTwmRodzzs8ciZnOGUD5OuQHvH+ShL+6z/qW6nOH0Jt hydAKz4ELF8p5g+r2u8aDTZQk/O46NG5IyxGIIPdMhuXa4/naOcq9MTkPj/5++TwoOwqOd VsOBszOE3gkpAq37w1+vJ3CWsR9PsH2UCBpDlIDcGj5egvKjv7uCXolPHYy3WUDq6NESro IExMsXqfAZz3U1dW/VohVUj6Zny5g9m1DotU38/6yBgyP2gQun9o9FCebHRsig== Date: Sun, 16 Jun 2024 13:55:19 +0200 From: Dragan Simic To: Jonas Karlman Cc: Detlev Casanova , linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Greg Kroah-Hartman , Sebastian Reichel , Alexey Charkov , Cristian Ciocaltea , Diederik de Haas , Andy Yan , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 3/3] arm64: dts: rockchip: Add rkvdec2 Video Decoder on rk3588(s) In-Reply-To: References: <20240615015734.1612108-1-detlev.casanova@collabora.com> <20240615015734.1612108-4-detlev.casanova@collabora.com> <944c4296-8dd2-4ffd-b430-1839ff3a3ed2@kwiboo.se> <3666279.iZASKD2KPV@arisu> Message-ID: <7f649d79666a175da7c9d9fd9377a687@manjaro.org> X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240616_045527_275680_BB6F3F8C X-CRM114-Status: GOOD ( 13.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello all, On 2024-06-16 11:17, Jonas Karlman wrote: > On 2024-06-15 21:55, Detlev Casanova wrote: >> On Saturday, June 15, 2024 4:25:27 A.M. EDT Jonas Karlman wrote: >>> On 2024-06-15 03:56, Detlev Casanova wrote: >>>> Add the rkvdec2 Video Decoder to the RK3588s devicetree. >>>> >>>> Signed-off-by: Detlev Casanova >>>> --- >>>> >>>> .../boot/dts/rockchip/rk3588-rock-5b.dts | 4 ++++ >>>> .../boot/dts/rockchip/rk3588s-orangepi-5.dts | 4 ++++ >>>> arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 19 >>>> +++++++++++++++++++ >>>> 3 files changed, 27 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts >>>> b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts index >>>> c551b676860c..965322c24a65 100644 >>>> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts >>>> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts >>>> @@ -503,6 +503,10 @@ &pwm1 { >>>> >>>> status = "okay"; >>>> >>>> }; >>>> >>>> +&rkvdec0 { >>>> + status = "okay"; >>>> +}; >>> >>> Enable of rkvdec0 should probably be split out from the patch that >>> adds >>> the rkvdec0 node to soc dtsi. >> >> Ack >> >>> Also why is rkvdec0 only enabled on rock-5b and orangepi-5? >> >> I only could test on those two but I can enable it on all rk3588 >> devices. > > Because the decoder is an integrated part of the SoC the default should > probably be that the IP is enabled, i.e. no status prop required for > the > vdec and related mmu nodes in rk3588s.dtsi. Agreed, the decoder is a SoC feature. As such, it should be enabled on the SoC level, instead of having it enabled on the board level.