From: Krzysztof Kozlowski <krzk@kernel.org>
To: Henry Martin <bsdhenrymartin@gmail.com>, djakov@kernel.org
Cc: s.nawrocki@samsung.com, a.swigon@samsung.com,
alim.akhtar@samsung.com, linux-pm@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] interconnect: Add NULL check in exynos_generic_icc_probe
Date: Mon, 31 Mar 2025 13:32:30 +0200 [thread overview]
Message-ID: <7f8a3f75-f66f-4380-ae60-b84f6752da0b@kernel.org> (raw)
In-Reply-To: <20250331110802.9658-1-bsdhenrymartin@gmail.com>
On 31/03/2025 13:08, Henry Martin wrote:
> When devm_kasprintf() fails, it returns a NULL pointer. However, this return value is not properly checked in the function exynos_generic_icc_probe.
Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.
>
> A NULL check should be added after the devm_kasprintf() to prevent potential NULL pointer dereference error.
> This is similar to the commit 050b23d081da.
Not related. These are different drivers, so drop.
These apply to all your patches.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-31 11:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 11:08 [PATCH] interconnect: Add NULL check in exynos_generic_icc_probe Henry Martin
2025-03-31 11:32 ` Krzysztof Kozlowski [this message]
2025-03-31 11:34 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f8a3f75-f66f-4380-ae60-b84f6752da0b@kernel.org \
--to=krzk@kernel.org \
--cc=a.swigon@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=bsdhenrymartin@gmail.com \
--cc=djakov@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox