From: Florian Fainelli <f.fainelli@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Mark Brown" <broonie@kernel.org>, "Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>
Cc: Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
linux-spi@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH 09/87] spi: bcm2835: Convert to platform remove callback returning void
Date: Fri, 3 Mar 2023 09:23:41 -0800 [thread overview]
Message-ID: <7f8ae2e7-6700-f7c8-932a-78cbe5b1e0e1@gmail.com> (raw)
In-Reply-To: <20230303172041.2103336-10-u.kleine-koenig@pengutronix.de>
On 3/3/23 09:19, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-03 17:37 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230303172041.2103336-1-u.kleine-koenig@pengutronix.de>
2023-03-03 17:19 ` [PATCH 03/87] spi: aspeed-smc: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-03 21:52 ` Cédric Le Goater
2023-03-03 17:19 ` [PATCH 04/87] spi: at91-usart: " Uwe Kleine-König
2023-03-06 11:57 ` Claudiu.Beznea
2023-03-03 17:19 ` [PATCH 06/87] spi: atmel: " Uwe Kleine-König
2023-03-06 11:57 ` Claudiu.Beznea
2023-03-03 17:19 ` [PATCH 09/87] spi: bcm2835: " Uwe Kleine-König
2023-03-03 17:23 ` Florian Fainelli [this message]
2023-03-06 7:04 ` Uwe Kleine-König
2023-03-06 12:26 ` Mark Brown
2023-03-03 17:19 ` [PATCH 10/87] spi: bcm2835aux: " Uwe Kleine-König
2023-03-03 17:23 ` Florian Fainelli
2023-03-03 17:19 ` [PATCH 13/87] spi: bcmbca-hsspi: " Uwe Kleine-König
2023-03-03 17:24 ` Florian Fainelli
2023-03-03 17:19 ` [PATCH 14/87] spi: brcmstb-qspi: " Uwe Kleine-König
2023-03-03 17:24 ` Florian Fainelli
2023-03-03 17:19 ` [PATCH 32/87] spi: iproc-qspi: " Uwe Kleine-König
2023-03-03 17:26 ` Florian Fainelli
2023-03-03 17:19 ` [PATCH 34/87] spi: meson-spicc: " Uwe Kleine-König
2023-03-04 21:43 ` Martin Blumenstingl
2023-03-03 17:19 ` [PATCH 35/87] spi: meson-spifc: " Uwe Kleine-König
2023-03-04 21:43 ` Martin Blumenstingl
2023-03-03 17:19 ` [PATCH 41/87] spi: mtk-nor: " Uwe Kleine-König
2023-03-03 17:19 ` [PATCH 42/87] spi: mtk-snfi: " Uwe Kleine-König
2023-03-03 17:19 ` [PATCH 44/87] spi: mxs: " Uwe Kleine-König
2023-03-03 17:20 ` [PATCH 55/87] spi: pxa2xx: " Uwe Kleine-König
2023-03-03 17:20 ` [PATCH 58/87] spi: rockchip-sfc: " Uwe Kleine-König
2023-03-03 17:20 ` [PATCH 59/87] spi: rockchip: " Uwe Kleine-König
2023-03-03 17:20 ` [PATCH 62/87] spi: s3c64xx: " Uwe Kleine-König
2023-03-03 17:20 ` [PATCH 68/87] spi: slave-mt27xx: " Uwe Kleine-König
2023-03-03 17:20 ` [PATCH 72/87] spi: stm32-qspi: " Uwe Kleine-König
2023-03-03 17:20 ` [PATCH 73/87] spi: stm32: " Uwe Kleine-König
2023-03-03 17:20 ` [PATCH 74/87] spi: sun4i: " Uwe Kleine-König
2023-03-03 17:29 ` Andre Przywara
2023-03-14 20:11 ` Jernej Škrabec
2023-03-03 17:20 ` [PATCH 75/87] spi: sun6i: " Uwe Kleine-König
2023-03-03 17:30 ` Andre Przywara
2023-03-14 20:12 ` Jernej Škrabec
2023-03-03 17:20 ` [PATCH 83/87] spi: uniphier: " Uwe Kleine-König
2023-03-03 17:20 ` [PATCH 84/87] spi: xilinx: " Uwe Kleine-König
2023-03-03 17:20 ` [PATCH 86/87] spi: zynq-qspi: " Uwe Kleine-König
2023-03-03 17:20 ` [PATCH 87/87] spi: zynqmp-gqspi: " Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f8ae2e7-6700-f7c8-932a-78cbe5b1e0e1@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox