From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38E5FC4360F for ; Thu, 4 Apr 2019 07:43:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08B5020882 for ; Thu, 4 Apr 2019 07:43:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QKxIGB5J"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="uUjYa2MP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08B5020882 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=M1VbPa2Dr/xb0exTIKRQJk0aeGTu4OCpJdKqtNpEa58=; b=QKxIGB5J44nXNH zB+pFXZ7bkOfRbtBn9VkkZtoE0L4Q1GjHlFFf9f+v49FRIE7CPDi9pPbXzEOtzVYZf2ZMb8ASQMWc HXC4waVJ4dLVxOhi/7+NWxeRkY4r0FqTvfQnHUfUOgPOTAWknxOpZoEPEsGjO8t1IbWX/z0dw2QJy pep99Gu9iGWoytsPKEg2StA7qIP0VoicpaUsCGjh1NfdgGQJo2y9Lm2tMMLCUBe4P9oc+cPdBM4bE D76PgD0fjPs/FIzhqEd/9JDQmEST1C8Dm8Kc2AQadgL5dPnk5p6/ze8y/3ybp3Jfz4/mykdRmob1A RWHQ/x/wni4eHzzCUkYA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBx2A-0008Vx-D6; Thu, 04 Apr 2019 07:43:38 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBx27-0008VY-Cy for linux-arm-kernel@lists.infradead.org; Thu, 04 Apr 2019 07:43:36 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x347hTGA064131; Thu, 4 Apr 2019 02:43:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1554363809; bh=j1tJfLJ9K3b+a/cwVN/Xnyt70KNgMDwu+dzIRENh08w=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=uUjYa2MPeVCkCRBNp1O27ggyqpInZg3T3NbKO9+UCG0hArheaKYxnCOm57joKdtlV o6pQjKu7wSihZo/5m5YxhnIPFFpifyYwsnqUOkbQP4T7+q7vWFHmgiVV0gPD4snO+c El8e0H40SCITMARyxG8BbhZspXtRV7bVrjXSi6jQ= Received: from DLEE114.ent.ti.com (dlee114.ent.ti.com [157.170.170.25]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x347hTWg010231 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 4 Apr 2019 02:43:29 -0500 Received: from DLEE113.ent.ti.com (157.170.170.24) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Thu, 4 Apr 2019 02:43:29 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Thu, 4 Apr 2019 02:43:28 -0500 Received: from [172.24.190.233] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id x347hOQ5113095; Thu, 4 Apr 2019 02:43:26 -0500 Subject: Re: [PATCH v5 8/8] PCI: dwc: Do not write to MSI control registers if the platform doesn't use it To: Lorenzo Pieralisi References: <20190321095927.7058-1-kishon@ti.com> <20190321095927.7058-9-kishon@ti.com> <20190403171902.GB3783@red-moon> From: Kishon Vijay Abraham I Message-ID: <7fb6436b-133b-0345-c8de-02fa77ebcf4d@ti.com> Date: Thu, 4 Apr 2019 13:12:27 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190403171902.GB3783@red-moon> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190404_004335_504660_E14FC745 X-CRM114-Status: GOOD ( 16.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marc Zyngier , Gustavo Pimentel , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Murali Karicheri , Jingoo Han , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Lorenzo, On 03/04/19 10:49 PM, Lorenzo Pieralisi wrote: > On Thu, Mar 21, 2019 at 03:29:27PM +0530, Kishon Vijay Abraham I wrote: >> Platforms which populate msi_host_init, has it's own MSI controller >> logic. Writing to MSI control registers on platforms which doesn't use >> Designware's MSI controller logic might have side effects. To >> be safe, do not write to MSI control registers if the platform uses >> it's own MSI controller logic instead of Designware's MSI controller >> logic. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> .../pci/controller/dwc/pcie-designware-host.c | 24 ++++++++++--------- >> 1 file changed, 13 insertions(+), 11 deletions(-) > > This patch is needed regardless of the rest of the series, correct ? > A.k.a. it is fixing an issue already in the mainline. That's correct. Thanks Kishon _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel