From: Neil Armstrong <neil.armstrong@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>,
linux-arm-kernel@lists.infradead.org, Da Xue <da@libre.computer>,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-spi@vger.kernel.org
Subject: Re: [PATCH] spi: meson-spicc: move wait completion in driver to take bursts delay in account
Date: Wed, 26 Oct 2022 14:48:07 +0200 [thread overview]
Message-ID: <7fb8e635-ef61-0773-eadc-7a5723740df6@linaro.org> (raw)
In-Reply-To: <Y1kql/WwAX+ZV8us@sirena.org.uk>
Hi,
On 26/10/2022 14:39, Mark Brown wrote:
> On Wed, Oct 26, 2022 at 09:58:28AM +0200, Neil Armstrong wrote:
>
>> - spi_finalize_current_transfer(spicc->master);
>> + complete(&spicc->done);
>
> No, you need to call spi_finalize_current_transfer() - you need to block
> inside the transfer function if you want to open code this stuff.
It's the case, I added a wait_for_completion_timeout() + return 0 in meson_spicc_transfer_one.
Neil
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-26 12:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 7:58 [PATCH] spi: meson-spicc: move wait completion in driver to take bursts delay in account Neil Armstrong
2022-10-26 12:39 ` Mark Brown
2022-10-26 12:48 ` Neil Armstrong [this message]
2022-10-26 12:51 ` Mark Brown
2022-10-26 17:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fb8e635-ef61-0773-eadc-7a5723740df6@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=broonie@kernel.org \
--cc=da@libre.computer \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox