From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8AD01C0015E for ; Tue, 15 Aug 2023 12:10:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xaYQr5I1e6SkneUabMuLhVImRTCtorgeVf8+22bXOiQ=; b=pCs7anQxjDbaCm K6Na4IyglH9KQeQSPmRJ6YAnwKtBUKCe1MCH8gog1QE7BRVtYxN4ig4riOKxBKU5dwuehj6Gsucy+ HZvAGKNPUnQbGlQfrQskNPNEJJ64fS62JgnNRgfIbCFhHmQ4MhIDl0KfoU6I6qH8JGW7pv0XFTJdS JVRIF3GoHe2gzOC5VAMYZTscW5dfee3beeXu6hvOT52varPchEJTDdkQD1pfEg0SmsobN95Lmc+PZ VgHl5WbFBCEd6K/bTXBStbOTYfs8z9nYlxzX4nbE5SizrZSosyGyAo3W44w+VEt8E63QRArz/aMcw XZ8G0LS9vvuWS1a1aAmQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qVssQ-001aHx-1F; Tue, 15 Aug 2023 12:10:22 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qVssN-001aHA-1Q for linux-arm-kernel@lists.infradead.org; Tue, 15 Aug 2023 12:10:20 +0000 Received: from [192.168.88.20] (91-154-35-171.elisa-laajakaista.fi [91.154.35.171]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3924E6BE; Tue, 15 Aug 2023 14:09:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1692101345; bh=KW0vx009AqO7xSRMMkK4x1+GAudFOgostRFnyNMAqJo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=uVe4fAAELF9vwDd8TqfvGsAazt+qzmiZcOwEtfckHzAQghbPHNTvUsCbC/x9cw4gT v+I0NyycM/SykUDa/PmQlZEcDYJJkSRGngKxAyb+cYb944vfFTOKj4nESUP/GkTgOo D6EEbwLf8XOYwgwA90uRjcvXqtPQYD0LNDDjdvgA= Message-ID: <7ffd3f08-ffb7-7c79-2cdd-ecbf740d204a@ideasonboard.com> Date: Tue, 15 Aug 2023 15:10:13 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v9 07/13] media: cadence: csi2rx: Soft reset the streams before starting capture Content-Language: en-US To: Jai Luthra , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sakari Ailus Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Laurent Pinchart , Mauro Carvalho Chehab , Maxime Ripard , niklas.soderlund+renesas@ragnatech.se, Benoit Parrot , Vaishnav Achath , Vignesh Raghavendra , nm@ti.com, devarsht@ti.com, a-bhatia1@ti.com, Martyn Welch , Julien Massot References: <20230811-upstream_csi-v9-0-8943f7a68a81@ti.com> <20230811-upstream_csi-v9-7-8943f7a68a81@ti.com> From: Tomi Valkeinen In-Reply-To: <20230811-upstream_csi-v9-7-8943f7a68a81@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230815_051019_648737_C3DC0673 X-CRM114-Status: GOOD ( 19.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/08/2023 13:47, Jai Luthra wrote: > From: Pratyush Yadav > > This resets the stream state machines and FIFOs, giving them a clean > slate. On J721E if the streams are not reset before starting the > capture, the captured frame gets wrapped around vertically on every run > after the first. > > Signed-off-by: Pratyush Yadav > Reviewed-by: Laurent Pinchart > Reviewed-by: Maxime Ripard > Signed-off-by: Jai Luthra > --- > Changes from v8: > - Simplify reset sequence, minimizing delays > > drivers/media/platform/cadence/cdns-csi2rx.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/cadence/cdns-csi2rx.c b/drivers/media/platform/cadence/cdns-csi2rx.c > index 933edec89520..b57e0c3b1944 100644 > --- a/drivers/media/platform/cadence/cdns-csi2rx.c > +++ b/drivers/media/platform/cadence/cdns-csi2rx.c > @@ -40,6 +40,7 @@ > #define CSI2RX_STREAM_BASE(n) (((n) + 1) * 0x100) > > #define CSI2RX_STREAM_CTRL_REG(n) (CSI2RX_STREAM_BASE(n) + 0x000) > +#define CSI2RX_STREAM_CTRL_SOFT_RST BIT(4) > #define CSI2RX_STREAM_CTRL_START BIT(0) > > #define CSI2RX_STREAM_DATA_CFG_REG(n) (CSI2RX_STREAM_BASE(n) + 0x008) > @@ -134,12 +135,23 @@ struct csi2rx_priv *v4l2_subdev_to_csi2rx(struct v4l2_subdev *subdev) > > static void csi2rx_reset(struct csi2rx_priv *csi2rx) > { > + unsigned int i; > + > + /* Reset module */ > writel(CSI2RX_SOFT_RESET_PROTOCOL | CSI2RX_SOFT_RESET_FRONT, > csi2rx->base + CSI2RX_SOFT_RESET_REG); > + /* Reset individual streams. */ > + for (i = 0; i < csi2rx->max_streams; i++) { > + writel(CSI2RX_STREAM_CTRL_SOFT_RST, > + csi2rx->base + CSI2RX_STREAM_CTRL_REG(i)); > + } > > - udelay(10); > + usleep_range(10, 20); > > + /* Clear resets */ > writel(0, csi2rx->base + CSI2RX_SOFT_RESET_REG); > + for (i = 0; i < csi2rx->max_streams; i++) > + writel(0, csi2rx->base + CSI2RX_STREAM_CTRL_REG(i)); > } > > static int csi2rx_configure_ext_dphy(struct csi2rx_priv *csi2rx) > Reviewed-by: Tomi Valkeinen Tomi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel