* [PATCH] ARM64: dts: meson-gxl: add internal ethernet PHY irq
@ 2017-12-18 10:27 Jerome Brunet
2018-01-06 0:54 ` Kevin Hilman
0 siblings, 1 reply; 2+ messages in thread
From: Jerome Brunet @ 2017-12-18 10:27 UTC (permalink / raw)
To: linux-arm-kernel
Add the interrupt of the internal ethernet PHY
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
Hi Kevin,
This changes depends on the net-next changes adding interrupt support [0].
It is really important that this change is not merged before its
dependency.
If it is merged before, instead of polling, the phy would wait for an
interrupt which has not been configured and will never fire.
Tested on the libretech-cc and khadas VIM.
Cheers
Jerome
https://lkml.kernel.org/r/20171218094446.31912-7-jbrunet at baylibre.com
arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
index 4a316a11a00e..8bc404508a4f 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
@@ -631,6 +631,7 @@
internal_phy: ethernet-phy at 8 {
compatible = "ethernet-phy-id0181.4400", "ethernet-phy-ieee802.3-c22";
+ interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>;
reg = <8>;
max-speed = <100>;
};
--
2.14.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ARM64: dts: meson-gxl: add internal ethernet PHY irq
2017-12-18 10:27 [PATCH] ARM64: dts: meson-gxl: add internal ethernet PHY irq Jerome Brunet
@ 2018-01-06 0:54 ` Kevin Hilman
0 siblings, 0 replies; 2+ messages in thread
From: Kevin Hilman @ 2018-01-06 0:54 UTC (permalink / raw)
To: linux-arm-kernel
Jerome Brunet <jbrunet@baylibre.com> writes:
> Add the interrupt of the internal ethernet PHY
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> Hi Kevin,
>
> This changes depends on the net-next changes adding interrupt support [0].
> It is really important that this change is not merged before its
> dependency.
>
> If it is merged before, instead of polling, the phy would wait for an
> interrupt which has not been configured and will never fire.
Thanks for the warning. I'll wait and merge these after -rc1 to be sure
of all dependencies.
Kevin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-06 0:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-18 10:27 [PATCH] ARM64: dts: meson-gxl: add internal ethernet PHY irq Jerome Brunet
2018-01-06 0:54 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).