From: khilman@kernel.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: mvebu: flag the crypto clk as CLK_IGNORE_UNUSED
Date: Tue, 16 Jun 2015 08:02:34 -0700 [thread overview]
Message-ID: <7h381r1yt1.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1434453721-24070-1-git-send-email-boris.brezillon@free-electrons.com> (Boris Brezillon's message of "Tue, 16 Jun 2015 13:22:01 +0200")
Boris Brezillon <boris.brezillon@free-electrons.com> writes:
> Fixes: 29e623475c50267ee3aaa49ebb6cbe107bce8d2a ("clk: mvebu: add
> missing CESA gate clk").
Which was:
Reported-by: Kevin Hilman <khilman@linaro.org>
> The crypto SRAM, used by the armada 370 cpuidle code to workaround a bug
> in the BootROM code, requires the crypto clk to be up and running.
> Flag the the crypto clk as IGNORE_UNUSED until we add the proper
> infrastructure to define the crypto SRAM in the DT and reference the crypto
> clk in this SRAM node.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Cc: <stable@vger.kernel.org> #4.1
> ---
> drivers/clk/mvebu/armada-370.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/mvebu/armada-370.c b/drivers/clk/mvebu/armada-370.c
> index c19fd77..7c2a58c 100644
> --- a/drivers/clk/mvebu/armada-370.c
> +++ b/drivers/clk/mvebu/armada-370.c
> @@ -163,7 +163,7 @@ static const struct clk_gating_soc_desc a370_gating_desc[] __initconst = {
> { "pex1", "pex1_en", 9, 0 },
> { "sata0", NULL, 15, 0 },
> { "sdio", NULL, 17, 0 },
> - { "crypto", NULL, 23, 0 },
> + { "crypto", NULL, 23, CLK_IGNORE_UNUSED }
Doesn't compile. Needs trailing ','
> { "tdm", NULL, 25, 0 },
> { "ddr", NULL, 28, CLK_IGNORE_UNUSED },
> { "sata1", NULL, 30, 0 },
With that fixed, I tested this on top of next-20150615 where mirabox was
previously broken and I confirm it's now working.
Tested-by: Kevin Hilman <khilman@linaro.org>
Kevin
prev parent reply other threads:[~2015-06-16 15:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 11:22 [PATCH] clk: mvebu: flag the crypto clk as CLK_IGNORE_UNUSED Boris Brezillon
2015-06-16 15:02 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7h381r1yt1.fsf@deeprootsystems.com \
--to=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).