From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55BD6FA3741 for ; Mon, 31 Oct 2022 16:41:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h/QdrZ/IesYXG1OY5So+19t0kw7ELVdCJ+zV++FASw0=; b=ENjhUqgZuhhn3b pIRPzNFlnUwv4taIe1DksNx4ArLFy3C2Y2bVhMGhsHZxt2q4m/f/6Mh43GV/9s8WMx0LQmfopRtM8 huFLWGNQs6o7YtODuyI3cOsUbH3Ljg8/etiWwDd0xdoQ+pPY66OQUnHe0tXpMRf5FSnt4Bf+ds75y C4ae6a1Y5gejiz5qcPSEka5VbXVt3yZQ/K7JVGfjW6+UN5tNDSf7oiWnmOct7HV8mbOZUH9gIPOeq e19SMQVqdUv4xfRjl+FSAHYz9laVrdOiahhMYygUsAASZi1RvuxCTmWod+IDm8opFDKd50OzH+/UP mNZ6IWaHN+LEokiBvU8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1opXpc-00D36j-R9; Mon, 31 Oct 2022 16:40:12 +0000 Received: from mail-pg1-f181.google.com ([209.85.215.181]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1opXpY-00D30l-Ro for linux-arm-kernel@lists.infradead.org; Mon, 31 Oct 2022 16:40:10 +0000 Received: by mail-pg1-f181.google.com with SMTP id s196so11172983pgs.3 for ; Mon, 31 Oct 2022 09:40:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G5iO8KHmbbjpD0edAAD18XYUlbSGy4UU+ld7nxMCDFQ=; b=gsh31zIltjDPuxXFB0cgl66s1xmIs5525fSRFFLAGoDbgO34neFGNAhmvnAsp3zWbf F5Gd6zeqtbOx5x4UL9dcOF1NBrceHahadrSN9y6lcXCeBdrcA++PsCZSFlBpFxWmDeQG xVtnILDlkLb3HfFFskmjcNtR86rVmCD1pP9Xuqdw2DNdq8fsAFTSAwj9JfYIKC2UmU90 WBxNS8jCS3wyOrAviEamJg7LNoXQoaFr5G7w0L3/H3Y5RGaB4or3K00YkW0Re/h39Wdm 9G/umUHT+OuUL2eKwXfpT62gflW2EbohbeBAbckUf1n3z6Fhp6fvRFP8rUkBxl3raaYy P2pA== X-Gm-Message-State: ACrzQf1UT+RiuLBal+aShHQofOAtQgsVfvKNL2Odb2wsTsip6ZMQiWrF BBLAMIxzN9TuNzjpGz/u4Ryhtw== X-Google-Smtp-Source: AMsMyM4wbIhY06SY2nUR74pUKGuIl5gTFPk+xpQFABfA9XZzwdh1qCxm1jXpjY9c4HML23XPnl7EdQ== X-Received: by 2002:a63:c146:0:b0:46f:c9e8:777d with SMTP id p6-20020a63c146000000b0046fc9e8777dmr4645744pgi.459.1667234405901; Mon, 31 Oct 2022 09:40:05 -0700 (PDT) Received: from localhost ([75.172.140.17]) by smtp.gmail.com with ESMTPSA id i63-20020a625442000000b0056be2a3c87csm4835445pfb.154.2022.10.31.09.40.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Oct 2022 09:40:05 -0700 (PDT) From: Kevin Hilman To: bchihi@baylibre.com, sean.wang@kernel.org, linus.walleij@linaro.org, matthias.bgg@gmail.com Cc: linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [v2, 0/2] Fix broken SET/CLR mode of a certain number of pins for MediaTek MT8385 SoC In-Reply-To: <20221021084708.1109986-1-bchihi@baylibre.com> References: <20221021084708.1109986-1-bchihi@baylibre.com> Date: Mon, 31 Oct 2022 09:40:04 -0700 Message-ID: <7h5yg02bh7.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221031_094008_910956_B0FD30E1 X-CRM114-Status: GOOD ( 12.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Balsam, bchihi@baylibre.com writes: > From: Balsam CHIHI > > On MT8365, the SET/CLR of the mode is broken and some pins won't set or clear the modes correctly. > To fix this issue, we add a specific callback mt8365_set_clr_mode() for this specific SoC. > This callback uses the main R/W register to read/update/write the modes instead of using the SET/CLR register. > > This is the original patch series proposed by Fabien Parent . > "https://lore.kernel.org/linux-arm-kernel/20220530123425.689459-1-fparent@baylibre.com/" > > Changelog: > Changes in v2 : > - Rebase on top of 6.1.0-rc1-next-20221020 > - Delete MTK_PINCTRL_MODE_SET_CLR_BROKEN quirk > - Add mt8365_set_clr_mode() callback nit: subject of cover letter should also include "pinctrl: mediatek:" prefix. Also note that you're missing the word "PATCH" in all of the subjects. Tip: If you use `git format-patch`, you can just pass `-v2` on the cmdline and it will create the prefixes for you automatically. Kevin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel