From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@baylibre.com (Kevin Hilman) Date: Tue, 26 Jan 2016 16:40:25 -0800 Subject: [RESEND PATCH v2] ARM: debug: add support for Palmchip BK-310x UART In-Reply-To: <569CA203.6050001@sigmadesigns.com> (Marc Gonzalez's message of "Mon, 18 Jan 2016 09:27:47 +0100") References: <569CA203.6050001@sigmadesigns.com> Message-ID: <7h60yfn9c6.fsf@baylibre.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Marc Gonzalez writes: > From: Mans Rullgard > > Some SoCs use a Palmchip BK-310x UART which is mostly 16550 compatible > but with a different register layout. ... because UART register layout is where we really need innovation. ;) > While this UART has previously > only been supported in MIPS based chips (Alchemy, Ralink), the ARM based > SMP87xx series from Sigma Designs also uses it. > > This patch allows the debug console to work with this type of UART. > > Signed-off-by: Mans Rullgard > Signed-off-by: Marc Gonzalez It appears this was previously acked by Arnd also? https://lkml.org/lkml/2015/11/9/116 > --- > Peter, this is the patch I've been using on Tango for earlyprintk support. > arm-soc, this is just the Nov 8 patch with my Signed-off-by tag. > --- > arch/arm/Kconfig.debug | 9 +++++++++ > arch/arm/include/debug/palmchip.S | 11 +++++++++++ > 2 files changed, 20 insertions(+) > create mode 100644 arch/arm/include/debug/palmchip.S > > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug > index 259c0ca9c99a..708aa9150c00 100644 > --- a/arch/arm/Kconfig.debug > +++ b/arch/arm/Kconfig.debug > @@ -1304,6 +1304,7 @@ config DEBUG_SIRFSOC_UART > config DEBUG_LL_INCLUDE > string > default "debug/sa1100.S" if DEBUG_SA1100 > + default "debug/palmchip.S" if DEBUG_UART_8250_PALMCHIP minor nit: We're trying (not always with great success) to keep various parts of this file sorted alphanumerically. Can you please insert the new entries accordingly? Otherwise looks good to me, Acked-by: Kevin Hilman Kevin