From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCF43C3A59E for ; Wed, 21 Aug 2019 18:02:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CC5F2082F for ; Wed, 21 Aug 2019 18:02:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BwPALIZK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="Rv35xrv1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CC5F2082F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DQih1AXCKEEJPRac50gR8Can+cwceklzSagbLW0brM4=; b=BwPALIZKfO+rEw ifTsYaUxcbR6IGfSrYIMEtXeXRx/Ege/2wCgJUhDV6rFyy4y/ZBdPqB9vnYDALlOZclapV5DFqKLD 9lXL3d/wdOW6hpFkF2/2v9Qu21n9zBisaipoXrLU/w/PYdsFNxvPaFi0zB+lOfG4Snr0hAYl8r4Cr Z3gK/a+bGkEtkIfmvp002G1+WqSGUezcE0g2nSd8hjmhzp9AcP/SZHT1bhsyVXu1D9hDCn7RnoFzp cyba3RAcFRsHdACuMA2guBgFKNnaLuXfP9g/hEN+8oZfKWu7IY4HX5eERafm+7Yo9hDbdvvoJ6PgY 4A5i7uWW6Xo1sZBeA6vw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i0Uw8-0000Mq-4h; Wed, 21 Aug 2019 18:02:20 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i0Uw4-0000Kx-Vn for linux-arm-kernel@lists.infradead.org; Wed, 21 Aug 2019 18:02:18 +0000 Received: by mail-pg1-x542.google.com with SMTP id u17so1751272pgi.6 for ; Wed, 21 Aug 2019 11:02:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=ubzr14D/m7NN4Gig+J49yEfObSCnRlFHpZMQCxBRrVE=; b=Rv35xrv1gcfayU9R+qpmA5rQGMwtfLgnRrLjmQlH51d9QkX0YDczI+50P0E1BoCsNr HXcgtPIvxKBSh9TZjiFurL+mwdWWx6RUI/yCQOaPlsFZ4yMkzqpaoRVEQcMeZk+qlGgI hRYTF+OmFOX22XlupG67mIr/N5Orwjlc3P5piwe45L2/wNqoXyFFu257j8F/TtFUm1EV qMKbbxF0xBV39nThclx3/qg+0roqn8ekes/qhsJMELrev+j0UtLh+Xu3tgMRwyk8ewle I+hr4KQ6nWsyHa5+3d4j9zi2TSDc8DN/sG0HkR3u0Kp3jZL10YcL3s5QRdgao2SZpWN8 GDVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=ubzr14D/m7NN4Gig+J49yEfObSCnRlFHpZMQCxBRrVE=; b=lH89AlPYgPcsbzoeHJaBdf4qY77L0BffMgAIydHOhSFGgGYLCRwABXeqBn4mEdvSnj adbKfvD5/SW7y1JgfPzJy0mv7cl2BFF43bwiepE/nunLhSG8coMmiO68h/s7enVf0rl2 eqnrL7/cdVAT86XOwXSmvcw6x94YJthVF0y7SyN8HDAUiXaAPhh41er8J+R5sGrCuAhF kys/chGuFTf+M4bb4ZR0RbUzGDw8MX3WQxjwAlhg88NI2HvdYooNQXciGfpuFE7YcaFM OEPA4aZQlirjlbeNtfxhlEsmt5J7c7SC/BTfCO9K5z3H6XMX0zvUbf8EVIgp+Kx1EfZZ 9sCw== X-Gm-Message-State: APjAAAWl5A05xf0qa7/XXEO2Tm2pAZsZ3DWDbMGTyRf7Q6BrWe2CZHBF KNqu57PUzcWoLCLPp0hurCLlUg== X-Google-Smtp-Source: APXvYqzlmjNDEJBXLF4y15j0jF5pl7SHAfLJmB9j2o+pnjNpIbZCoiTyxhWaFefXMOPZ/JAxPpq7qQ== X-Received: by 2002:aa7:8c57:: with SMTP id e23mr26690422pfd.48.1566410534247; Wed, 21 Aug 2019 11:02:14 -0700 (PDT) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id y16sm35101574pfc.36.2019.08.21.11.02.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 21 Aug 2019 11:02:13 -0700 (PDT) From: Kevin Hilman To: Neil Armstrong , balbi@kernel.org Subject: Re: [PATCH] usb: dwc3: meson-g12a: fix suspend resume regulator unbalanced disables In-Reply-To: <20190821133518.9671-1-narmstrong@baylibre.com> References: <20190821133518.9671-1-narmstrong@baylibre.com> Date: Wed, 21 Aug 2019 11:02:12 -0700 Message-ID: <7h7e76bdnf.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190821_110217_021254_7B37EA96 X-CRM114-Status: UNSURE ( 8.93 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Neil Armstrong Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Neil Armstrong writes: > When going in suspend, in Device mode, then resuming back leads > to the following: > > unbalanced disables for USB_PWR_EN > WARNING: CPU: 0 PID: 163 at ../drivers/regulator/core.c:2590 _regulator_disable+0x104/0x180 > Hardware name: Amlogic Meson G12A U200 Development Board (DT) > [...] > pc : _regulator_disable+0x104/0x180 > lr : _regulator_disable+0x104/0x180 > [...] > Call trace: > _regulator_disable+0x104/0x180 > regulator_disable+0x40/0x78 > dwc3_meson_g12a_otg_mode_set+0x84/0xb0 > dwc3_meson_g12a_irq_thread+0x58/0xb8 > irq_thread_fn+0x28/0x80 > irq_thread+0x118/0x1b8 > kthread+0xf4/0x120 > ret_from_fork+0x10/0x18 > > This disables the regulator if enabled on suspend, and the reverse on > resume. > > Fixes: c99993376f72 ("usb: dwc3: Add Amlogic G12A DWC3 glue") > Reported-by: Kevin Hilman > Signed-off-by: Neil Armstrong Tested-by: Kevin Hilman _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel