From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@kernel.org (Kevin Hilman) Date: Wed, 18 Nov 2015 10:04:36 -0800 Subject: [PATCH v9 2/2] arm-soc: Add support for tango4 platforms In-Reply-To: <564C9558.4020100@sigmadesigns.com> (Marc Gonzalez's message of "Wed, 18 Nov 2015 16:12:24 +0100") References: <564C94A5.4060301@sigmadesigns.com> <564C9558.4020100@sigmadesigns.com> Message-ID: <7ha8qbyyiz.fsf@deeprootsystems.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Marc Gonzalez writes: > Add support for Sigma Designs ARM-based Tango4 "Secure Media Processor" > platforms (i.e. smp8734, smp8756, smp8758, smp8759) built around the > Cortex-A9 MPCore r3p0 (all dual-core, except the 8756). > > Support for older MIPS-based platforms can be found elsewhere: > https://github.com/mansr/linux-tangox > > Signed-off-by: Marc Gonzalez > --- > arch/arm/Kconfig | 2 ++ > arch/arm/Makefile | 1 + > arch/arm/mach-tangox/Kconfig | 12 ++++++++++++ > arch/arm/mach-tangox/Makefile | 2 ++ > arch/arm/mach-tangox/setup.c | 32 ++++++++++++++++++++++++++++++++ > arch/arm/mach-tangox/smc.S | 9 +++++++++ > arch/arm/mach-tangox/smc.h | 5 +++++ Potential bike-shed fodder, but, a dumb question: is the family name actually "tangox" or is the "x" for the number (tango3, tango4, etc.) Assuming it's the later based on usage throughout the patch, I think it'd be better to just use "tango" throughout instead of tangox. Also a MAINTAINERS file entry is appropriate for this new platform support (as scripts/checkpatch.pl should have told you.) Kevin