From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 171BFC3DA7F for ; Mon, 12 Aug 2024 21:18:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=glRHgM8xhwoYlcjgNLA4lJhSJgddsN6N7UUXGoa9228=; b=eSrZD74kzbllFk5HrNp9mgSpRp WGcHckUUOOFDSoxMfFGDRX4z4b0w1DG+V1uk0SBVgJtlM/6L0I0JMHbbFi7i8TzkrgN/ACEnAVYXP 2bi3cGAGbb+tzmWVDY9ZhCaewL3aN4Az5VZX5/y91gRzH1AAtkJ64ycUGGkArTSkwwH+1Gf/pQnVS HrNNfq8zsVl+w58jolz95TnjwvZsl3K+TDwvNpXq1Lf4o7VeiapGQ9+Hflo/Q253eBofsP4rp9sQR GGegL3MraiR88VOd/ghMW67+ufiBwR/xJf9Z72iwWHx5+/tnaLnj/196b4zRyoHhkb9DqLevWpqwU pQCn27yw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdcQF-00000001bJu-2q9Q; Mon, 12 Aug 2024 21:17:47 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdcPI-00000001b7r-386e for linux-arm-kernel@lists.infradead.org; Mon, 12 Aug 2024 21:17:11 +0000 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-1fc6ee64512so34121745ad.0 for ; Mon, 12 Aug 2024 14:16:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1723497407; x=1724102207; darn=lists.infradead.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=glRHgM8xhwoYlcjgNLA4lJhSJgddsN6N7UUXGoa9228=; b=2/HfAJfphODLD8L9yKMjK29K4WpZqK9k4rnnbcKMbsf8Lqoh4MYp2BqUUz2cJRKy6u XfRaqyq+YCjoEn87dFMPYgZ/ZHie1SaLLhu5EZdk0ondLQLXoO3R8QL2rbwWNZu8DN6X sz3gALWCjiCXN6RtLz2XRm4nScmoxMjDUkL5BjPcfGW5nAMblaSoie38Rt0sWSVoojo8 FiRHoA5uqyXENsUAjJadi61BdaPYbE8VwxF3iHSpFzFW/z7UNwwOPl3OtjKny1Oz6X7h h4YQkFz9FO4ZKc8Q9EDyCEYcCwUSeC3Zqmr7ei8hqrzAmij1Mh4maFev7abiShSeBQmJ MDfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723497407; x=1724102207; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=glRHgM8xhwoYlcjgNLA4lJhSJgddsN6N7UUXGoa9228=; b=Nh/9ccvy1FlCCofrnsxDLUAKTbqPID11dZsrzZfMH7WVJGfSjhHyNc5kEjixZBSI1b /oviwlEDCZRw6MZhBgxMGx1IbbcRsaRG1N2hnceUpTRaBCB1REEbiLI+i5dGtnqbuaWP xDvLMhh3UvwqHLSVsWuIVW/TD9IS1LF7t2R6N6fQQNnBR9XOoO0URxZSJwnu8Fahbs4p RndVTuuqYPalBflTL9p70FTrni6WnClxfYY0HJH1VHbGjFHVJNOThKqG1D9vdItz5Xz2 UkKeqwtuCWMoQfE5Q+o+YugTqWyX49/XDL9PQW/baU4UGrr7VFZsimto2aD0cM1KD1Z9 7ACg== X-Forwarded-Encrypted: i=1; AJvYcCUfvN70m3+0QtzXQ1Z/s+sA2afeVAPojmTrNxm/RadrEKI4SLN22IGXdiOmbDvHawj8ukVq7ICOtzHEq8h3X+1FlxRLDe/3bb9Uo6bfjkiqvEQxIUM= X-Gm-Message-State: AOJu0YzWBsCE0mzV9mBA7epswY7KcuS7EGzQ6o8cvMy5mw1pmiO49lOo uNgCEQskAJMg4X0NPZeEGkakov8OaRSD/e7iRy+vH0/NY0ZWBjAKtJvmAH77oTc= X-Google-Smtp-Source: AGHT+IG3huzZbJvj7W1Iydd51Kl4NAJb5ySebRX+HV4626+6wB1HXfeSHul8v0+Czq2PcAdrsHmT/w== X-Received: by 2002:a17:902:e74f:b0:1fd:78dd:8578 with SMTP id d9443c01a7336-201ca1c5bd9mr20762635ad.55.1723497407243; Mon, 12 Aug 2024 14:16:47 -0700 (PDT) Received: from localhost ([71.212.170.185]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-201cd1a963esm1185185ad.181.2024.08.12.14.16.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Aug 2024 14:16:46 -0700 (PDT) From: Kevin Hilman To: Dhruva Gole , Markus Schneider-Pargmann Cc: Nishanth Menon , Tero Kristo , Santosh Shilimkar , Vibhore Vardhan , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Gerlach , Georgi Vlaev , Akashdeep Kaur Subject: Re: [PATCH v9 3/4] firmware: ti_sci: Introduce Power Management Ops In-Reply-To: <20240812054717.6lzkt3lxclzec3zy@lcpd911> References: <20240809135347.2112634-1-msp@baylibre.com> <20240809135347.2112634-4-msp@baylibre.com> <20240812054717.6lzkt3lxclzec3zy@lcpd911> Date: Mon, 12 Aug 2024 14:16:45 -0700 Message-ID: <7hcymdphky.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240812_141648_812888_FD43014C X-CRM114-Status: GOOD ( 19.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dhruva Gole writes: > On Aug 09, 2024 at 15:53:46 +0200, Markus Schneider-Pargmann wrote: >> From: Dave Gerlach >> >> Introduce power management ops supported by the TISCI >> Low Power Mode API [1]. >> >> 1) TISCI_MSG_LPM_WAKE_REASON >> Get which wake up source woke the SoC from Low Power Mode. >> The wake up source IDs will be common for all K3 platforms. >> >> 2) TISCI_MSG_LPM_SET_DEVICE_CONSTRAINT >> Set LPM constraint on behalf of a device. By setting a constraint, the >> device ensures that it will not be powered off or reset in the selected >> mode. >> >> 3) TISCI_MSG_LPM_SET_LATENCY_CONSTRAINT >> Set LPM resume latency constraint. By setting a constraint, the host >> ensures that the resume time from selected mode will be less than the >> constraint value. >> >> [1] https://software-dl.ti.com/tisci/esd/latest/2_tisci_msgs/pm/lpm.html >> >> Signed-off-by: Dave Gerlach >> [g-vlaev@ti.com: LPM_WAKE_REASON and IO_ISOLATION support] >> Signed-off-by: Georgi Vlaev >> [a-kaur@ti.com: SET_DEVICE_CONSTRAINT support] >> Signed-off-by: Akashdeep Kaur >> [vibhore@ti.com: SET_LATENCY_CONSTRAINT support] >> Signed-off-by: Vibhore Vardhan >> Signed-off-by: Markus Schneider-Pargmann >> --- > [...] >> diff --git a/drivers/firmware/ti_sci.h b/drivers/firmware/ti_sci.h >> index 8efe4d0e61fb..9dd40b6711d4 100644 >> --- a/drivers/firmware/ti_sci.h >> +++ b/drivers/firmware/ti_sci.h >> @@ -38,7 +38,10 @@ >> >> /* Low Power Mode Requests */ >> #define TI_SCI_MSG_PREPARE_SLEEP 0x0300 >> +#define TI_SCI_MSG_LPM_WAKE_REASON 0x0306 >> #define TI_SCI_MSG_SET_IO_ISOLATION 0x0307 >> +#define TI_SCI_MSG_LPM_SET_DEVICE_CONSTRAINT 0x0309 >> +#define TI_SCI_MSG_LPM_SET_LATENCY_CONSTRAINT 0x030A >> >> /* Resource Management Requests */ >> #define TI_SCI_MSG_GET_RESOURCE_RANGE 0x1500 >> @@ -610,6 +613,73 @@ struct ti_sci_msg_req_set_io_isolation { >> u8 state; >> } __packed; >> >> +/** >> + * struct ti_sci_msg_resp_lpm_wake_reason - Response for TI_SCI_MSG_LPM_WAKE_REASON. >> + * >> + * @hdr: Generic header. >> + * @wake_source: The wake up source that woke soc from LPM. >> + * @wake_timestamp: Timestamp at which soc woke. >> + * >> + * Response to a generic message with message type TI_SCI_MSG_LPM_WAKE_REASON, >> + * used to query the wake up source from low power mode. >> + */ >> +struct ti_sci_msg_resp_lpm_wake_reason { >> + struct ti_sci_msg_hdr hdr; >> + u32 wake_source; >> + u64 wake_timestamp; >> +} __packed; >> + > > It looks like we forgot to update the parameters in this API. > See [1]: > > struct tisci_msg_lpm_wake_reason_req > > We're missing here the wake_pin, mode and 2 rsvd fields as well. > > [1] https://software-dl.ti.com/tisci/esd/latest/2_tisci_msgs/pm/lpm.html#tisci-msg-lpm-wake-reason > The docs mention how to interpret the pin, but not the mode. This driver should translate this mode number to some human-readable state for better debug messages. Kevin