From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7671C4167B for ; Fri, 8 Dec 2023 17:14:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pWHF2CVO/CnkDrevidq7kqNLJk5Ry3wA4GBRwNcyRBk=; b=hzpTWpw4+2QHlK NuarB/LX1wOvalq+mC/w5grKJyeLSgx87UNVZYsFwz7lBXVbshqWnW0oEXdfCW7ICiYnyBJ49vV4P SWxV4e3ob0u2KmOSzAaR8dRdULIZUwVHvEEOyxfntRibIEciCxLccaJC3q2U7QwKnfwrb0GwsJTou /GxaBKxWqBRsHfMq4uxSHFNgiMPAUyPvjDHT8boVcqhLhfbaf2L1YFh3N7W/1iGYmc2MJM/x6oPpw pgTSSKwtHdicdb1h/eVh5tJxitfG+FeHPhboYP78dCWcIwtiYLkwcaaezsdASyip0vukvgmEHO5+q lDIRwbxboDUnQvFWMhaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rBeQ9-00G8vJ-0S; Fri, 08 Dec 2023 17:13:49 +0000 Received: from mail-pf1-f177.google.com ([209.85.210.177]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rBeQ5-00G8sw-2L for linux-arm-kernel@lists.infradead.org; Fri, 08 Dec 2023 17:13:47 +0000 Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-6cea1522303so1766720b3a.1 for ; Fri, 08 Dec 2023 09:13:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702055624; x=1702660424; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SMMgZavMk6x/anolZA0C5677mHhyCShMOXgIqsNDxyQ=; b=q3ucaBtVCuN42vl/KhcNKldb1bAAd5puoefspy/oOCclKwD3EBM5VsJ1QQt2rXBhN4 +L5QHjEZh2ktiWB1qVtxkgDWWE1aLizkfYt8FBzrVNYSgyQ02WmnUMvCZuFKQj0ZAf40 YisF38QPWeFS+Ltspcf+aUWcY3Gp0NLojmt5ZMr8RY5ziDJrR1pgqOiZ7PU1aGMwPufW EIV7Bvw0PiRtph9NWuDQ0wwB1D2CV74TSjlOODef8uYc/NssMa6iJ4J9OHnAM40KKDer bG9vM9A6E9wbHKxU+tkA+PsbffZHqZbdYVaagz+Uv0KmQJn9ThqTLWQOXJVQv73GQtNS daiA== X-Gm-Message-State: AOJu0Yzy9SHXI8Sw6iw5H6YphE28v+1mBPzSYP5BUQ89UldLWAO3UkFt YZw1Q9M9ZKQRnAcmQRGLiJkczQ== X-Google-Smtp-Source: AGHT+IEI16o8QXIqBOlzEC0ZX1SaRLHxgkzSqk+E+HnKlEbuxqjN2M6HnyonFUfLCoYakuFvcma6vA== X-Received: by 2002:a05:6a00:158c:b0:6ce:72f9:866b with SMTP id u12-20020a056a00158c00b006ce72f9866bmr381237pfk.46.1702055624299; Fri, 08 Dec 2023 09:13:44 -0800 (PST) Received: from localhost (75-172-121-199.tukw.qwest.net. [75.172.121.199]) by smtp.gmail.com with ESMTPSA id x7-20020a056a00188700b006cdda10bdafsm1825045pfh.183.2023.12.08.09.13.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 09:13:44 -0800 (PST) From: Kevin Hilman To: Tony Lindgren Cc: Nishanth Menon , Vignesh Raghavendra , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Dhruva Gole Subject: Re: [PATCH v2 1/1] arm64: dts: ti: k3-am62-wakeup: Configure ti-sysc for wkup_uart0 In-Reply-To: <20231207060854.GQ5169@atomide.com> References: <20231114073209.40756-1-tony@atomide.com> <7h5y1c7c0q.fsf@baylibre.com> <20231207060854.GQ5169@atomide.com> Date: Fri, 08 Dec 2023 09:13:43 -0800 Message-ID: <7hedfwd3co.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231208_091345_762713_4578158A X-CRM114-Status: GOOD ( 16.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Tony Lindgren writes: > * Kevin Hilman [231205 18:14]: >> I'm a little confused why these power-domain and clocks stay here and >> are not moved under the wkup_uart0 node... > > The resources are also needed by the interconnect target module. It's the > wrapper IP for the child device(s). In this case there's one chip 8250 IP > instance. In some other devices there can be multiple child IP devices > wired to one target module. > >> > - clock-names = "fclk"; >> > - status = "disabled"; >> > + clock-names = "fck"; >> > + #address-cells = <1>; >> > + #size-cells = <1>; >> > + ranges = <0 0 0x2b300000 0x100000>; >> > + >> > + wkup_uart0: serial@2b300000 { >> > + compatible = "ti,am64-uart", "ti,am654-uart"; >> > + reg = <0 0x100>; >> > + interrupts = ; >> > + status = "disabled"; >> >> ...here. >> >> The SCI device ID 114 is specifically for wkup_uart0[1], so it seems to >> me those should be in the wkup_uart0 node. > > Those resources are also needed for the parent target module for revision > detection, quirks, reset, idle register configuration, and to probe the > child devices. > > Here the 8250 IP can be set to status = "reserved" when used by the > firmware, and 8250 not touched by Linux. However, the parent interconnect > target module still needs to be configured for idle registers and wake-up > path register bit so the wake-up from deeper suspend states works. OK, makes sense. Thanks for the clarification. In that case, shouldn't the same be done for the other wakeup sources there (e.g. wkup_rtc0) ? Kevin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel