From: khilman@kernel.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 2/2] arm-soc: Add support for tango4 platforms
Date: Tue, 24 Nov 2015 10:05:40 -0800 [thread overview]
Message-ID: <7hegffp91n.fsf@deeprootsystems.com> (raw)
In-Reply-To: <564EF013.4030809@sigmadesigns.com> (Marc Gonzalez's message of "Fri, 20 Nov 2015 11:04:03 +0100")
Marc Gonzalez <marc_gonzalez@sigmadesigns.com> writes:
> On 19/11/2015 20:49, Kevin Hilman wrote:
>
>> Marc Gonzalez wrote:
>>
>>> +static void tango_l2c_write(unsigned long val, unsigned int reg)
>>> +{
>>> + pr_debug("%s: reg=0x%x val=0x%lx\n", __func__, reg, val);
>>
>> leftover debugging aid?
>
> I'll remove it.
>
> (For my education, we're not supposed to use any pr_debug calls?)
pr_debug() are fine to leave if you want them, but I assumed it was just
a leftover as it didn't seem generally useful.
>>> +ENTRY(tango_smc)
>>> + push {lr}
>>> + mov ip, r1
>>> + dsb /* This barrier is probably unnecessary */
>>
>> Then remove it?
>
> This was discussed in v8. It's probably cargo cult from OMAP,
> but the performance hit is negligible, and I don't have time
> to properly analyze the code path. I just wanted to add the
> comment in case someone copied my code.
Sure,
Kevin
prev parent reply other threads:[~2015-11-24 18:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 15:09 [PATCH v9 0/2] Sigma Designs Tango4 port Marc Gonzalez
2015-11-18 15:10 ` [PATCH v9 1/2] arm-soc: Import initial tango4 device tree Marc Gonzalez
2015-11-18 16:05 ` Måns Rullgård
2015-11-18 16:34 ` Marc Gonzalez
2015-11-18 16:38 ` Måns Rullgård
2015-11-18 17:11 ` Olof Johansson
2015-11-18 17:18 ` Måns Rullgård
2015-11-19 13:53 ` Marc Gonzalez
2015-11-19 14:43 ` Måns Rullgård
[not found] ` <564EFB18.3050104@sigmadesigns.com>
2015-11-20 12:08 ` Tango4 clkgen block Måns Rullgård
2015-11-18 15:12 ` [PATCH v9 2/2] arm-soc: Add support for tango4 platforms Marc Gonzalez
2015-11-18 18:04 ` Kevin Hilman
2015-11-18 18:16 ` Måns Rullgård
2015-11-18 19:39 ` Kevin Hilman
2015-11-19 17:24 ` Marc Gonzalez
2015-11-19 19:32 ` Kevin Hilman
2015-11-19 19:49 ` Kevin Hilman
2015-11-20 10:04 ` Marc Gonzalez
2015-11-24 18:05 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hegffp91n.fsf@deeprootsystems.com \
--to=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).