From: Kevin Hilman <khilman@baylibre.com>
To: Huqiang Qin <huqiang.qin@amlogic.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, neil.armstrong@linaro.org,
jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
linus.walleij@linaro.org
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: Replace the IRQ number with the IRQID macro definition
Date: Fri, 28 Jul 2023 12:06:34 -0700 [thread overview]
Message-ID: <7hh6pnhn45.fsf@baylibre.com> (raw)
In-Reply-To: <9da24c47-341b-1581-0043-a6c1cdce462d@amlogic.com>
Huqiang Qin <huqiang.qin@amlogic.com> writes:
> Hi Kevin Hilman,
>
> On 2023/7/27 6:33, Kevin Hilman wrote:
>>> Replacing IRQ numbers with IRQID macro definitions makes node properties
>>> easier to understand and also makes GPIO interrupts easier to use.
>>>
>>> Associated platforms:
>>> - Amlogic Meson-G12A
>>> - Amlogic Meson-G12B
>>> - Amlogic Meson-SM1
>> Does this mean you tested/validated these changes on those platforms
>> also?
>
> Amlogic's G12A/G12B/SM1 have the same GPIO, and the GPIO interrupt number
> is also the same, so I only tested on the SM1 platform, and the test results
> prove that these changes are good.
OK, thank you for the explanation.
For future reference, this kind of detail is helpful to describe in the
patch or cover letter so maintainers & reviewers better understand how
the changes were tested.
Thanks,
Kevin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-28 19:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 7:32 [PATCH 0/3] Add binding header file for GPIO interrupt of Amlogic Meson-G12A Huqiang Qin
2023-07-21 7:32 ` [PATCH 1/3] dt-bindings: interrupt-controller: Add header file for Amlogic Meson-G12A SoCs Huqiang Qin
2023-07-21 8:16 ` Krzysztof Kozlowski
2023-07-21 7:32 ` [PATCH 2/3] pinctrl: Replace the IRQ number in the driver with the IRQID macro definition Huqiang Qin
2023-07-21 7:32 ` [PATCH 3/3] arm64: dts: Replace the IRQ number " Huqiang Qin
[not found] ` <7hcz0ei9r4.fsf@baylibre.com>
2023-07-27 8:45 ` Huqiang Qin
2023-07-28 19:06 ` Kevin Hilman [this message]
2023-08-01 13:25 ` Huqiang Qin
2023-08-07 13:38 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hh6pnhn45.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=huqiang.qin@amlogic.com \
--cc=jbrunet@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).