From: Kevin Hilman <khilman@baylibre.com>
To: Anand Moon <linux.amoon@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org
Cc: Neil Armstrong <narmstrong@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Christian Hewitt <christianshewitt@gmail.com>,
Anand Moon <linux.amoon@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH v3 1/2] arm64: dts: meson-g12b-odroid-n2: Enable RTC controller node
Date: Thu, 20 Aug 2020 12:33:18 -0700 [thread overview]
Message-ID: <7hlfi9xgch.fsf@baylibre.com> (raw)
In-Reply-To: <20200820121323.564-2-linux.amoon@gmail.com>
Anand Moon <linux.amoon@gmail.com> writes:
> Enable RTC PCF8563 node on Odroid-N2 SBC, In order to
> support the RTC wakealarm feature for suspend and resume.
> Also assign an alias to the pcf8563 to rtc0 and meson-vrtc to rtc1
> timer device to prevent it being assigned to /dev/rtc0
> which disto userspace tools assume is a clock device.
>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Kevin Hilman <khilman@baylibre.com>
> Suggested-by: Christian Hewitt <christianshewitt@gmail.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> Changes V3
> --Drop the INI GPIOAO.BIT7 pinctrl.
Why did you drop this GPIO? Isn't this the GPIO that the RTC uses to
wakeup the system? If so, this should be included as part of this
patch.
It probably still works because the bootloader configures this GPIO as
input, but the kernel should not rely on the booloader for that, so
please include as part of this patch.
Other than that, this is looking OK.
Curious how you're testing this?
When I tested with rtcwake (from buildroot), I'm getting this:
/ # rtcwake -d rtc0 -m mem -s4
rtcwake: RTC_RD_TIME: Invalid argument
Kevin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-20 19:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 12:13 [PATCH v3 0/2]Enable RTC on Odroid N2 Anand Moon
2020-08-20 12:13 ` [PATCH v3 1/2] arm64: dts: meson-g12b-odroid-n2: Enable RTC controller node Anand Moon
2020-08-20 19:33 ` Kevin Hilman [this message]
2020-08-21 4:43 ` Anand Moon
2020-08-24 13:41 ` Anand Moon
2020-08-24 13:50 ` Neil Armstrong
2020-08-24 13:57 ` Anand Moon
2020-08-24 14:30 ` Jerome Brunet
2020-08-25 9:01 ` Anand Moon
2020-08-25 14:30 ` Jerome Brunet
2020-08-26 6:59 ` Anand Moon
2020-08-29 16:31 ` Anand Moon
2020-08-29 19:56 ` Martin Blumenstingl
2020-08-30 13:11 ` Anand Moon
2020-08-30 14:04 ` Martin Blumenstingl
2020-08-30 20:05 ` Anand Moon
2020-08-20 12:13 ` [PATCH v3 2/2] arm64: defconfig: Enable RTC devices for Amlogic boards Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hlfi9xgch.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=christianshewitt@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux.amoon@gmail.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).