* [PATCH] ARM64: dts: meson-axg: fix register ranges for SD/eMMC
@ 2018-06-04 22:27 Kevin Hilman
2018-06-05 6:56 ` Yixun Lan
2018-06-05 8:05 ` Jerome Brunet
0 siblings, 2 replies; 4+ messages in thread
From: Kevin Hilman @ 2018-06-04 22:27 UTC (permalink / raw)
To: linux-arm-kernel
Based on updated information from Amlogic, correct the register
range for the SD/eMMC blocks to the right size.
Reported-by: Yixun Lan <yixun.lan@amlogic.com>
Signed-off-by: Kevin Hilman <khilman@baylibre.com>
---
Yixun, please test and confirm this still works on AXG boards.
arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
index fee87737a201..67d7115e4eff 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
@@ -132,7 +132,7 @@
sd_emmc_b: sd at 5000 {
compatible = "amlogic,meson-axg-mmc";
- reg = <0x0 0x5000 0x0 0x2000>;
+ reg = <0x0 0x5000 0x0 0x800>;
interrupts = <GIC_SPI 217 IRQ_TYPE_EDGE_RISING>;
status = "disabled";
clocks = <&clkc CLKID_SD_EMMC_B>,
@@ -144,7 +144,7 @@
sd_emmc_c: mmc at 7000 {
compatible = "amlogic,meson-axg-mmc";
- reg = <0x0 0x7000 0x0 0x2000>;
+ reg = <0x0 0x7000 0x0 0x800>;
interrupts = <GIC_SPI 218 IRQ_TYPE_EDGE_RISING>;
status = "disabled";
clocks = <&clkc CLKID_SD_EMMC_C>,
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM64: dts: meson-axg: fix register ranges for SD/eMMC
2018-06-04 22:27 [PATCH] ARM64: dts: meson-axg: fix register ranges for SD/eMMC Kevin Hilman
@ 2018-06-05 6:56 ` Yixun Lan
2018-06-05 8:05 ` Jerome Brunet
1 sibling, 0 replies; 4+ messages in thread
From: Yixun Lan @ 2018-06-05 6:56 UTC (permalink / raw)
To: linux-arm-kernel
Hi Kevin
On 06/05/18 06:27, Kevin Hilman wrote:
> Based on updated information from Amlogic, correct the register
> range for the SD/eMMC blocks to the right size.
>
> Reported-by: Yixun Lan <yixun.lan@amlogic.com>
> Signed-off-by: Kevin Hilman <khilman@baylibre.com>
> ---
> Yixun, please test and confirm this still works on AXG boards.
>
> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index fee87737a201..67d7115e4eff 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> @@ -132,7 +132,7 @@
>
> sd_emmc_b: sd at 5000 {
> compatible = "amlogic,meson-axg-mmc";
> - reg = <0x0 0x5000 0x0 0x2000>;
> + reg = <0x0 0x5000 0x0 0x800>;
> interrupts = <GIC_SPI 217 IRQ_TYPE_EDGE_RISING>;
> status = "disabled";
> clocks = <&clkc CLKID_SD_EMMC_B>,
> @@ -144,7 +144,7 @@
>
> sd_emmc_c: mmc at 7000 {
> compatible = "amlogic,meson-axg-mmc";
> - reg = <0x0 0x7000 0x0 0x2000>;
> + reg = <0x0 0x7000 0x0 0x800>;
> interrupts = <GIC_SPI 218 IRQ_TYPE_EDGE_RISING>;
> status = "disabled";
> clocks = <&clkc CLKID_SD_EMMC_C>,
>
Starting from GXBB series, the SD/eMMC register range is changed to
0x800, so arch/arm64/boot/dts/amlogic/meson-gx.dtsi also need to be adjusted
Also, test passed on boards: GXBB(p200), GXL(p212, p230), AXG(s400)
Thanks for bringing up this, and fix them.
Yixun
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM64: dts: meson-axg: fix register ranges for SD/eMMC
2018-06-04 22:27 [PATCH] ARM64: dts: meson-axg: fix register ranges for SD/eMMC Kevin Hilman
2018-06-05 6:56 ` Yixun Lan
@ 2018-06-05 8:05 ` Jerome Brunet
2018-06-05 21:56 ` Kevin Hilman
1 sibling, 1 reply; 4+ messages in thread
From: Jerome Brunet @ 2018-06-05 8:05 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 2018-06-04 at 15:27 -0700, Kevin Hilman wrote:
> Based on updated information from Amlogic, correct the register
> range for the SD/eMMC blocks to the right size.
>
> Reported-by: Yixun Lan <yixun.lan@amlogic.com>
> Signed-off-by: Kevin Hilman <khilman@baylibre.com>
Shouldn't we make the same the change on the gx family ?
> ---
> Yixun, please test and confirm this still works on AXG boards.
>
> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index fee87737a201..67d7115e4eff 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> @@ -132,7 +132,7 @@
>
> sd_emmc_b: sd at 5000 {
> compatible = "amlogic,meson-axg-mmc";
> - reg = <0x0 0x5000 0x0 0x2000>;
> + reg = <0x0 0x5000 0x0 0x800>;
> interrupts = <GIC_SPI 217 IRQ_TYPE_EDGE_RISING>;
> status = "disabled";
> clocks = <&clkc CLKID_SD_EMMC_B>,
> @@ -144,7 +144,7 @@
>
> sd_emmc_c: mmc at 7000 {
> compatible = "amlogic,meson-axg-mmc";
> - reg = <0x0 0x7000 0x0 0x2000>;
> + reg = <0x0 0x7000 0x0 0x800>;
> interrupts = <GIC_SPI 218 IRQ_TYPE_EDGE_RISING>;
> status = "disabled";
> clocks = <&clkc CLKID_SD_EMMC_C>,
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM64: dts: meson-axg: fix register ranges for SD/eMMC
2018-06-05 8:05 ` Jerome Brunet
@ 2018-06-05 21:56 ` Kevin Hilman
0 siblings, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2018-06-05 21:56 UTC (permalink / raw)
To: linux-arm-kernel
Jerome Brunet <jbrunet@baylibre.com> writes:
> On Mon, 2018-06-04 at 15:27 -0700, Kevin Hilman wrote:
>> Based on updated information from Amlogic, correct the register
>> range for the SD/eMMC blocks to the right size.
>>
>> Reported-by: Yixun Lan <yixun.lan@amlogic.com>
>> Signed-off-by: Kevin Hilman <khilman@baylibre.com>
>
> Shouldn't we make the same the change on the gx family ?
>
Yes, I was waiting for confirmation from Yixun. Will spin a v2 with GX
included.
Kevin
>> ---
>> Yixun, please test and confirm this still works on AXG boards.
>>
>> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
>> index fee87737a201..67d7115e4eff 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
>> @@ -132,7 +132,7 @@
>>
>> sd_emmc_b: sd at 5000 {
>> compatible = "amlogic,meson-axg-mmc";
>> - reg = <0x0 0x5000 0x0 0x2000>;
>> + reg = <0x0 0x5000 0x0 0x800>;
>> interrupts = <GIC_SPI 217 IRQ_TYPE_EDGE_RISING>;
>> status = "disabled";
>> clocks = <&clkc CLKID_SD_EMMC_B>,
>> @@ -144,7 +144,7 @@
>>
>> sd_emmc_c: mmc at 7000 {
>> compatible = "amlogic,meson-axg-mmc";
>> - reg = <0x0 0x7000 0x0 0x2000>;
>> + reg = <0x0 0x7000 0x0 0x800>;
>> interrupts = <GIC_SPI 218 IRQ_TYPE_EDGE_RISING>;
>> status = "disabled";
>> clocks = <&clkc CLKID_SD_EMMC_C>,
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-05 21:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-04 22:27 [PATCH] ARM64: dts: meson-axg: fix register ranges for SD/eMMC Kevin Hilman
2018-06-05 6:56 ` Yixun Lan
2018-06-05 8:05 ` Jerome Brunet
2018-06-05 21:56 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).