* Re: [PATCH v2] driver core: fw_devlink: Don't warn about sync_state() pending
2025-10-07 9:43 [PATCH v2] driver core: fw_devlink: Don't warn about sync_state() pending Ulf Hansson
@ 2025-10-07 10:53 ` Dhruva Gole
2025-10-07 23:43 ` Saravana Kannan
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Dhruva Gole @ 2025-10-07 10:53 UTC (permalink / raw)
To: Ulf Hansson
Cc: Saravana Kannan, Rafael J . Wysocki, Greg Kroah-Hartman, linux-pm,
Geert Uytterhoeven, Nicolas Frattaroli, Heiko Stuebner,
Sebastian Reichel, Sebin Francis, Diederik de Haas,
Tomi Valkeinen, Jon Hunter, linux-arm-kernel, linux-kernel
On Oct 07, 2025 at 11:43:12 +0200, Ulf Hansson wrote:
> Due to the wider deployment of the ->sync_state() support, for PM domains
> for example, we are receiving reports about the sync_state() pending
> message that is being logged in fw_devlink_dev_sync_state(). In particular
> as it's printed at the warning level, which is questionable.
>
> Even if it certainly is useful to know that the ->sync_state() condition
> could not be met, there may be nothing wrong with it. For example, a driver
> may be built as module and are still waiting to be initialized/probed. For
> this reason let's move to the info level for now.
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Reported-by: Sebin Francis <sebin.francis@ti.com>
> Reported-by: Diederik de Haas <didi.debian@cknow.org>
> Reported-by: Jon Hunter <jonathanh@nvidia.com>
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
>
> Changes in v2:
> - Due to discussions on v1 and because the default Kconfig is to use the
> FW_DEVLINK_SYNC_STATE_STRICT, I suggest that for now it may be best to
> keep the warning level for the "Timed out.." print and only change the
> "sync_state pending..." message.
>
> ---
> drivers/base/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index d22d6b23e758..c62e428b95b0 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -1784,7 +1784,7 @@ static int fw_devlink_dev_sync_state(struct device *dev, void *data)
> return 0;
>
> if (fw_devlink_sync_state == FW_DEVLINK_SYNC_STATE_STRICT) {
> - dev_warn(sup, "sync_state() pending due to %s\n",
> + dev_info(sup, "sync_state() pending due to %s\n",
Reviewed-by: Dhruva Gole <d-gole@ti.com>
--
Best regards,
Dhruva Gole
Texas Instruments Incorporated
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] driver core: fw_devlink: Don't warn about sync_state() pending
2025-10-07 9:43 [PATCH v2] driver core: fw_devlink: Don't warn about sync_state() pending Ulf Hansson
2025-10-07 10:53 ` Dhruva Gole
@ 2025-10-07 23:43 ` Saravana Kannan
2025-10-09 21:54 ` Kevin Hilman
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Saravana Kannan @ 2025-10-07 23:43 UTC (permalink / raw)
To: Ulf Hansson
Cc: Rafael J . Wysocki, Greg Kroah-Hartman, linux-pm,
Geert Uytterhoeven, Nicolas Frattaroli, Heiko Stuebner,
Sebastian Reichel, Sebin Francis, Diederik de Haas,
Tomi Valkeinen, Jon Hunter, linux-arm-kernel, linux-kernel
On Tue, Oct 7, 2025 at 2:43 AM Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> Due to the wider deployment of the ->sync_state() support, for PM domains
> for example, we are receiving reports about the sync_state() pending
> message that is being logged in fw_devlink_dev_sync_state(). In particular
> as it's printed at the warning level, which is questionable.
>
> Even if it certainly is useful to know that the ->sync_state() condition
> could not be met, there may be nothing wrong with it. For example, a driver
> may be built as module and are still waiting to be initialized/probed. For
> this reason let's move to the info level for now.
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Reported-by: Sebin Francis <sebin.francis@ti.com>
> Reported-by: Diederik de Haas <didi.debian@cknow.org>
> Reported-by: Jon Hunter <jonathanh@nvidia.com>
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
>
> Changes in v2:
> - Due to discussions on v1 and because the default Kconfig is to use the
> FW_DEVLINK_SYNC_STATE_STRICT, I suggest that for now it may be best to
> keep the warning level for the "Timed out.." print and only change the
> "sync_state pending..." message.
Acked-by: Saravana Kannan <saravanak@google.com>
-Saravana
>
> ---
> drivers/base/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index d22d6b23e758..c62e428b95b0 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -1784,7 +1784,7 @@ static int fw_devlink_dev_sync_state(struct device *dev, void *data)
> return 0;
>
> if (fw_devlink_sync_state == FW_DEVLINK_SYNC_STATE_STRICT) {
> - dev_warn(sup, "sync_state() pending due to %s\n",
> + dev_info(sup, "sync_state() pending due to %s\n",
> dev_name(link->consumer));
> return 0;
> }
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] driver core: fw_devlink: Don't warn about sync_state() pending
2025-10-07 9:43 [PATCH v2] driver core: fw_devlink: Don't warn about sync_state() pending Ulf Hansson
2025-10-07 10:53 ` Dhruva Gole
2025-10-07 23:43 ` Saravana Kannan
@ 2025-10-09 21:54 ` Kevin Hilman
2025-10-10 12:08 ` Sebastian Reichel
2025-10-13 12:24 ` Sebin Francis
4 siblings, 0 replies; 6+ messages in thread
From: Kevin Hilman @ 2025-10-09 21:54 UTC (permalink / raw)
To: Ulf Hansson, Saravana Kannan, Rafael J . Wysocki,
Greg Kroah-Hartman, linux-pm
Cc: Geert Uytterhoeven, Nicolas Frattaroli, Heiko Stuebner,
Sebastian Reichel, Sebin Francis, Diederik de Haas,
Tomi Valkeinen, Jon Hunter, Ulf Hansson, linux-arm-kernel,
linux-kernel
Ulf Hansson <ulf.hansson@linaro.org> writes:
> Due to the wider deployment of the ->sync_state() support, for PM domains
> for example, we are receiving reports about the sync_state() pending
> message that is being logged in fw_devlink_dev_sync_state(). In particular
> as it's printed at the warning level, which is questionable.
>
> Even if it certainly is useful to know that the ->sync_state() condition
> could not be met, there may be nothing wrong with it. For example, a driver
> may be built as module and are still waiting to be initialized/probed. For
> this reason let's move to the info level for now.
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Reported-by: Sebin Francis <sebin.francis@ti.com>
> Reported-by: Diederik de Haas <didi.debian@cknow.org>
> Reported-by: Jon Hunter <jonathanh@nvidia.com>
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] driver core: fw_devlink: Don't warn about sync_state() pending
2025-10-07 9:43 [PATCH v2] driver core: fw_devlink: Don't warn about sync_state() pending Ulf Hansson
` (2 preceding siblings ...)
2025-10-09 21:54 ` Kevin Hilman
@ 2025-10-10 12:08 ` Sebastian Reichel
2025-10-13 12:24 ` Sebin Francis
4 siblings, 0 replies; 6+ messages in thread
From: Sebastian Reichel @ 2025-10-10 12:08 UTC (permalink / raw)
To: Ulf Hansson
Cc: Saravana Kannan, Rafael J . Wysocki, Greg Kroah-Hartman, linux-pm,
Geert Uytterhoeven, Nicolas Frattaroli, Heiko Stuebner,
Sebin Francis, Diederik de Haas, Tomi Valkeinen, Jon Hunter,
linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1998 bytes --]
Hi,
On Tue, Oct 07, 2025 at 11:43:12AM +0200, Ulf Hansson wrote:
> Due to the wider deployment of the ->sync_state() support, for PM domains
> for example, we are receiving reports about the sync_state() pending
> message that is being logged in fw_devlink_dev_sync_state(). In particular
> as it's printed at the warning level, which is questionable.
>
> Even if it certainly is useful to know that the ->sync_state() condition
> could not be met, there may be nothing wrong with it. For example, a driver
> may be built as module and are still waiting to be initialized/probed. For
> this reason let's move to the info level for now.
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Reported-by: Sebin Francis <sebin.francis@ti.com>
> Reported-by: Diederik de Haas <didi.debian@cknow.org>
> Reported-by: Jon Hunter <jonathanh@nvidia.com>
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
-- Sebastian
> ---
>
> Changes in v2:
> - Due to discussions on v1 and because the default Kconfig is to use the
> FW_DEVLINK_SYNC_STATE_STRICT, I suggest that for now it may be best to
> keep the warning level for the "Timed out.." print and only change the
> "sync_state pending..." message.
>
> ---
> drivers/base/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index d22d6b23e758..c62e428b95b0 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -1784,7 +1784,7 @@ static int fw_devlink_dev_sync_state(struct device *dev, void *data)
> return 0;
>
> if (fw_devlink_sync_state == FW_DEVLINK_SYNC_STATE_STRICT) {
> - dev_warn(sup, "sync_state() pending due to %s\n",
> + dev_info(sup, "sync_state() pending due to %s\n",
> dev_name(link->consumer));
> return 0;
> }
> --
> 2.43.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] driver core: fw_devlink: Don't warn about sync_state() pending
2025-10-07 9:43 [PATCH v2] driver core: fw_devlink: Don't warn about sync_state() pending Ulf Hansson
` (3 preceding siblings ...)
2025-10-10 12:08 ` Sebastian Reichel
@ 2025-10-13 12:24 ` Sebin Francis
4 siblings, 0 replies; 6+ messages in thread
From: Sebin Francis @ 2025-10-13 12:24 UTC (permalink / raw)
To: Ulf Hansson, Saravana Kannan, Rafael J . Wysocki,
Greg Kroah-Hartman, linux-pm
Cc: Geert Uytterhoeven, Nicolas Frattaroli, Heiko Stuebner,
Sebastian Reichel, Diederik de Haas, Tomi Valkeinen, Jon Hunter,
linux-arm-kernel, linux-kernel
Hi,
On 07/10/25 15:13, Ulf Hansson wrote:
> Due to the wider deployment of the ->sync_state() support, for PM domains
> for example, we are receiving reports about the sync_state() pending
> message that is being logged in fw_devlink_dev_sync_state(). In particular
> as it's printed at the warning level, which is questionable.
>
> Even if it certainly is useful to know that the ->sync_state() condition
> could not be met, there may be nothing wrong with it. For example, a driver
> may be built as module and are still waiting to be initialized/probed. For
> this reason let's move to the info level for now.
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Reported-by: Sebin Francis <sebin.francis@ti.com>
> Reported-by: Diederik de Haas <didi.debian@cknow.org>
> Reported-by: Jon Hunter <jonathanh@nvidia.com>
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
Reviewed-by: Sebin Francis <sebin.francis@ti.com>
Tested-by: Sebin Francis <sebin.francis@ti.com>
-- Sebin
>
> Changes in v2:
> - Due to discussions on v1 and because the default Kconfig is to use the
> FW_DEVLINK_SYNC_STATE_STRICT, I suggest that for now it may be best to
> keep the warning level for the "Timed out.." print and only change the
> "sync_state pending..." message.
>
> ---
> drivers/base/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index d22d6b23e758..c62e428b95b0 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -1784,7 +1784,7 @@ static int fw_devlink_dev_sync_state(struct device *dev, void *data)
> return 0;
>
> if (fw_devlink_sync_state == FW_DEVLINK_SYNC_STATE_STRICT) {
> - dev_warn(sup, "sync_state() pending due to %s\n",
> + dev_info(sup, "sync_state() pending due to %s\n",
> dev_name(link->consumer));
> return 0;
> }
^ permalink raw reply [flat|nested] 6+ messages in thread