From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF030C41513 for ; Wed, 9 Aug 2023 17:37:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CRomgn10PgMqLnw5baOc6mtAQd/TKV/B02fnHJWvBZM=; b=boYhfodCs0Xo1m 0d+y6YsrHQT1aAJFxFXAh6Z9mey3Lr966qididTaTzHxREn/zk/i8qkIZD62JPE1pzP1YPhwyupfy V15GxS5Lvd/PKlmA6XvBl8+CF0wKv6R1Epm5o56U4hCMuwf/faLGfjSVHDDx9TpSccP595BVOlNA7 TzzsJxAtNAVLat7FKzeZtgC9jcUEomGevpofir2ADVFlGEGhqQ8W/v1OrVBzAk4M1eKqcClubhsk2 RBZSup7xks7lzFflTuYoHouYjo6Qg+G7XfCLltKVz3QKsby3H1Wb7vZc35c2PAIYo8v5jqLZd07Zs 6FtPxki0IG9+5jRUIP7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTn7Z-005XTx-1h; Wed, 09 Aug 2023 17:37:21 +0000 Received: from mail-pf1-f169.google.com ([209.85.210.169]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTn7X-005XTa-1O for linux-arm-kernel@lists.infradead.org; Wed, 09 Aug 2023 17:37:20 +0000 Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-686b9920362so12249b3a.1 for ; Wed, 09 Aug 2023 10:37:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691602638; x=1692207438; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9yArT/awXRkYrPki92Zws/80hTWdY4r8NmlN6iV95PI=; b=k2YIktZr1dWv+fxdA1l1fxhCAUELBZ8eUPxaKtWU272fdzPJeRpAoD5FCQSHbsS6TI 2fafCYBLl6cJ1d7+lwom3c4Glwe6EYSRk0IuICp2b+YsvXyj7gdA6S1r7J5gzkgdeXvD CZzGz7CcxRWZoeR9d6rqqUIK/SVqsQQGXuHfPnYUpFjw+tnzB+9SYDUW9kOf0iHc3tzl ChQ/HJt8OTviYfWCKnnrfrtYTvt6TRZXzEA8U1zyFHsf1IsXy3XoBiEPoqgrIJxp79P7 yntvvNIJqjhQxLPmAA+kKCWompTe34NxsGNHiRQ3P8v+iRkZpdD6KC/7nJWpQtF8zGyD kkYQ== X-Gm-Message-State: AOJu0YxBy2DraJYYZTFD4V8nX355qp/uf28spxSaDCKeehCEEvYNUOvS 6v6jzmPxUMwBj3Jas346eshc6w== X-Google-Smtp-Source: AGHT+IEOe/X404gAnI9Qj8z0UDy2WHWR3jxWz9myYIGG/dCeUzQac/1bjO6kMws5dZZ6Ia4S1Lp7Bw== X-Received: by 2002:a05:6a20:428a:b0:140:a25:1c1d with SMTP id o10-20020a056a20428a00b001400a251c1dmr3891567pzj.51.1691602638385; Wed, 09 Aug 2023 10:37:18 -0700 (PDT) Received: from localhost ([75.172.135.98]) by smtp.gmail.com with ESMTPSA id j21-20020a62b615000000b00687375d9135sm10158999pff.4.2023.08.09.10.37.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Aug 2023 10:37:17 -0700 (PDT) From: Kevin Hilman To: Tony Lindgren Cc: Dhruva Gole , Andrew Davis , Nishanth Menon , Tero Kristo , Santosh Shilimkar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Viresh Kumar , Praneeth Bajjuri , Dave Gerlach , Vibhore Vardhan , Georgi Vlaev Subject: Re: [PATCH V6 4/4] firmware: ti_sci: Introduce system suspend resume support In-Reply-To: <20230809072330.GB11676@atomide.com> References: <20230803064247.503036-1-d-gole@ti.com> <20230803064247.503036-5-d-gole@ti.com> <3882f0ac-b74c-6eb2-197c-34ca233cd7a3@ti.com> <20230803155541.nwsfwobfkbpefoyw@dhruva> <8c330bd9-5f4e-8cd0-ed02-c3a696d7473a@ti.com> <20230803160815.yfpkdfssv75d4inf@dhruva> <7ho7jifrda.fsf@baylibre.com> <20230808115403.dkz6ev5vc6bhcmzh@dhruva> <7httt9dq2x.fsf@baylibre.com> <20230809072330.GB11676@atomide.com> Date: Wed, 09 Aug 2023 10:37:17 -0700 Message-ID: <7ho7jgdsmq.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230809_103719_474239_B13C949E X-CRM114-Status: GOOD ( 13.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Tony Lindgren writes: > * Kevin Hilman [230809 00:20]: >> To me, it sounds like you might want to use ->resume_early() or maybe >> ->resume_noirq() in the pinctrl driver for this so that IO isolation can >> be disabled sooner? > > For calls that need to happen just before the SoC is disabled or first > thing on resume path, cpu_cluster_pm_enter() and cpu_cluster_pm_exit() > notifiers work nice and allow distributing the code across the related > SoC specific code and device drivers. See for example the usage in > drivers/irqchip/irq-gic.c for CPU_CLUSTER_PM_ENTER. Indeed, this is an option too, but for things that already have "full" drivers (e.g. not an irqchip), they already have a full range of PM callbacks, and adding another set of callbacks/notifiers for cpu_pm_* is a bit clunky IMO. That being said, for things like this IO isolation stuff that is system-wide, and needs to happen very late in suspend (and/or very early in suspend), cpu_pm_ is worth considering if the same cannot be done with the normal PM callbacks. Kevin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel