linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 4/4] arm64: dts: meson-axg: add clock DT info for Meson AXG SoC
Date: Wed, 06 Dec 2017 16:50:02 -0800	[thread overview]
Message-ID: <7ho9nbmked.fsf@baylibre.com> (raw)
In-Reply-To: <20171201012452.27086-5-yixun.lan@amlogic.com> (Yixun Lan's message of "Fri, 1 Dec 2017 09:24:52 +0800")

Yixun Lan <yixun.lan@amlogic.com> writes:

> From: Qiufang Dai <qiufang.dai@amlogic.com>
>
> Try to add Hiubus DT info, and also enable clock DT info
> for the Amlogic's Meson-AXG SoC.
>
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Qiufang Dai <qiufang.dai@amlogic.com>
> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
> ---
>  arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index b932a784b02a..36a2e98338a8 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> @@ -7,6 +7,7 @@
>  #include <dt-bindings/gpio/gpio.h>
>  #include <dt-bindings/interrupt-controller/irq.h>
>  #include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/clock/axg-clkc.h>

This #include will cause an unnessary dependency from the amlogic tree
to the clock tree even though this patch is not currently using any of
the #defines from that header.  It will simplify the dependencies if you
drop this #include from this patch.

In my comment on the cover letter, I suggested adding a patch that also
switches the UART over to the new clock provider.  That is the patch
that should add this #include, since it will actually need #defines from
the header.

Doing it in that order means that we could merge this patch
independently of the clock driver, and then merge the UART switch-over
patch only after the driver (and headers) are merged.

Kevin

  reply	other threads:[~2017-12-07  0:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-01  1:24 [PATCH v4 0/4] add clk controller driver for Meson-AXG SoC Yixun Lan
2017-12-01  1:24 ` [PATCH v4 1/4] dt-bindings: clock: add compatible variant for the Meson-AXG Yixun Lan
2017-12-01  1:24 ` [PATCH v4 2/4] clk: meson-axg: add clocks dt-bindings required header Yixun Lan
2017-12-04 21:37   ` Rob Herring
2017-12-01  1:24 ` [PATCH v4 3/4] clk: meson-axg: add clock controller drivers Yixun Lan
2017-12-07  8:40   ` Neil Armstrong
2017-12-01  1:24 ` [PATCH v4 4/4] arm64: dts: meson-axg: add clock DT info for Meson AXG SoC Yixun Lan
2017-12-07  0:50   ` Kevin Hilman [this message]
2017-12-08 14:50     ` Yixun Lan
2017-12-06 19:13 ` [PATCH v4 0/4] add clk controller driver for Meson-AXG SoC Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ho9nbmked.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).