From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH v2 1/2] soc: amlogic: add Meson GX VPU Domains driver
Date: Mon, 30 Oct 2017 17:56:33 +0100 [thread overview]
Message-ID: <7ho9ootvzy.fsf@baylibre.com> (raw)
In-Reply-To: <CAPDyKFpCf50XRowGe3X5KpmhKrb99NTxOUQtz4RN4aemAVAJCA@mail.gmail.com> (Ulf Hansson's message of "Mon, 30 Oct 2017 16:40:07 +0100")
Ulf Hansson <ulf.hansson@linaro.org> writes:
> Hi Neil,
>
> [...]
>
>> +
>> + pm_genpd_init(&vpu_hdmi_pd.genpd, &simple_qos_governor,
>> + meson_gx_pwrc_vpu_get_power(&vpu_hdmi_pd));
>> +
>
> This means that you may initialize the genpd in powered on state.
>
> For that scenario, I think you will hit a clock unprepare/disable
> in-balance issue when genpd calls your ->power_off() callback, simply
> because you didn't call clk_prepare_enable() for the clocks first.
Yup, in my testing, I definitely hit this.
Kevin
next prev parent reply other threads:[~2017-10-30 16:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-28 16:36 [RESEND PATCH v2 0/2] soc: amlogic: add support for Meson GX VPU Domains Neil Armstrong
2017-10-28 16:36 ` [RESEND PATCH v2 1/2] soc: amlogic: add Meson GX VPU Domains driver Neil Armstrong
2017-10-30 15:40 ` Ulf Hansson
2017-10-30 16:47 ` Neil Armstrong
2017-10-30 16:56 ` Kevin Hilman [this message]
2017-10-28 16:36 ` [RESEND PATCH v2 2/2] dt-bindings: power: add amlogic meson power domain bindings Neil Armstrong
-- strict thread matches above, loose matches on Subject: below --
2017-10-28 16:40 [RESEND PATCH v2 0/2] soc: amlogic: add support for Meson GX VPU Domains Neil Armstrong
2017-10-28 16:40 ` [RESEND PATCH v2 1/2] soc: amlogic: add Meson GX VPU Domains driver Neil Armstrong
2017-10-29 14:59 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ho9ootvzy.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).