From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0A74C3271E for ; Tue, 9 Jul 2024 00:24:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wlo3UWV9lkDtVHiC3tnceLIBeIIjDfMxY69ysONeH1A=; b=XVQAc55dLOq0K4UVwJoKZPy8CK 6r5RT1KlVXvkpP25qNXSV5I6Cg4WFU55HruIubjXWkD4ioCy9xtQx8nN8OYtXCbNogxh7iD0SWdB4 Qy3Xfd/NO4iTVj9WCCDFvEfdZWoERdCJDMpUI8aUJWKD3Bxb6L0xcinc3ixBQxkuCaSKm9vTX1c5g JqgcRvQrFG9DR9Hopu9YGKUmX4GxbAMWdrvecE3KvLQxOli8hda/3mAzHeroR+CbcIe3wLmqcfXCy s3+kJ9iSh9n26WxvZROb2qGtJWzE4LCqC72l2SIbPEF36hFfKQE3J0s03ceP1Ene8JE23tPPZiZDZ hFwsgY5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sQyew-00000005Qu5-2Vwe; Tue, 09 Jul 2024 00:24:42 +0000 Received: from mail-pl1-f177.google.com ([209.85.214.177]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sQyeh-00000005Qqu-12Ey for linux-arm-kernel@lists.infradead.org; Tue, 09 Jul 2024 00:24:28 +0000 Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1fb72eb3143so15318625ad.1 for ; Mon, 08 Jul 2024 17:24:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720484666; x=1721089466; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wlo3UWV9lkDtVHiC3tnceLIBeIIjDfMxY69ysONeH1A=; b=rXJbk+LWAN8dRpcNv8UCHNm8wfGt9cVG/Ga2vn+/rGc2A7AKR/dlXzYecvudfxLJHS /ptmnfwdsIPfJVaVX67IoNSQyNSKk4B/fDMDVPCs8cH0OMZG7x8rNKhGJQhPsfH0s1KW W+qQPdHNsq8MkmRXiysCC2Rj/gz0nPJBLcnKHzd2vlxFohjkHmbQK3THvNFg59u294Pn 6Gn0leeaIQj5GdE9eFRsbzAXhTWQ38mNafvrARjUdzeb6Pd00+c0RV6ATbfdisklAya0 LwdqyFCj1/K2cLXLLoIjCD0KrgMpFrNnokuZEDXwzAnDUYN4bm6LiT2IFb8yRJagFZyH OGiw== X-Forwarded-Encrypted: i=1; AJvYcCUdVmpXSsD8YiBVU94ze5GRYTnMvGQMu5yONH5xGIHXbE8Rvj87qJJXd1HJ/F8AMQcD6CBHCa/VsJhMKbcdV7G5qtQ4/TyExlNh0Axei3PhTE14OA4= X-Gm-Message-State: AOJu0Yz9ICOIma8QjNLtxl+PhWNTEbwKIoz5Zq3Cr14iNwcJpwYY59z6 HjtU9KMeO+iOchIaZ64EFUb9w7+OdHTcRvLk3UdhAg9v44k3zPFAr7vIS02/OrY= X-Google-Smtp-Source: AGHT+IFdw3EaveRM2ZTHoRq8dYxA8E7q05nixOcYOGorj2dRL4w7J12n220WAjIf2IctJiJkVfxTEw== X-Received: by 2002:a17:902:db0e:b0:1f4:a04e:8713 with SMTP id d9443c01a7336-1fbb804725emr12528595ad.28.1720484666359; Mon, 08 Jul 2024 17:24:26 -0700 (PDT) Received: from localhost (97-126-77-189.tukw.qwest.net. [97.126.77.189]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fbb6ab7d2dsm4321415ad.180.2024.07.08.17.24.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jul 2024 17:24:25 -0700 (PDT) From: Kevin Hilman To: Viresh Kumar , "Rafael J. Wysocki" , Viresh Kumar , Huang Rui , "Gautham R. Shenoy" , Mario Limonciello , Perry Yuan , Hector Martin , Sven Peter , Alyssa Rosenzweig , Markus Mayer , Broadcom internal kernel review list , Srinivas Pandruvada , Len Brown , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Naveen N. Rao" , Sudeep Holla , Cristian Marussi , Thierry Reding , Jonathan Hunter , Matthias Brugger , AngeloGioacchino Del Regno Cc: linux-pm@vger.kernel.org, Vincent Guittot , Lizhe , linux-kernel@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 4/4] cpufreq: Make cpufreq_driver->exit() return void In-Reply-To: <3f73fda736818128558b61ad5fe2bed5dce3ddc4.1720075640.git.viresh.kumar@linaro.org> References: <3f73fda736818128558b61ad5fe2bed5dce3ddc4.1720075640.git.viresh.kumar@linaro.org> Date: Mon, 08 Jul 2024 17:24:25 -0700 Message-ID: <7hplrn76py.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240708_172427_309155_D8768509 X-CRM114-Status: GOOD ( 10.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Viresh Kumar writes: > From: Lizhe > > The cpufreq core doesn't check the return type of the exit() callback > and there is not much the core can do on failures at that point. Just > drop the returned value and make it return void. > > Signed-off-by: Lizhe > [ Viresh: Reworked the patches to fix all missing changes together. ] > Signed-off-by: Viresh Kumar > --- [...] > drivers/cpufreq/omap-cpufreq.c | 3 +-- For OMAP: Acked-by: Kevin Hilman