From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4449C48BC3 for ; Wed, 14 Feb 2024 17:04:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0PgBp1YFN/ABBaEy9z0Vcpt8zkLrkT3d0jarcVT/vW8=; b=kIhxgFfj5k4C9p 5ON6Nar0pJ480phsP72C65BLTOfj1rOhMZU89mzTaeZq66bgx1AdIzNHvK2uc2aopX48gKrN2ovfH iWwQfVshQraKQ/V9m4Dlw6qHSUI897jCPhC23Suo81/mYvi3hHdbtyI2l2N2yqvswkdfzw0RM4TdH Ftf/Xmy0bQu8ETeSZ5HzwHSKVolMIGfp0esAcwsi7ZfBP13Yd4jxx4KEyDapZhXYGN+PBKMqwDQ+/ m8PnWiYrRr9XTOoANPDc/5JUDY5OnVNwUq4JOtWm6dDe9MT0JVREbhMQXeN4oKuwLqWVzEKPuS9e8 7GlBL+r0FAWK2UeB5BMQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1raIgJ-0000000Ddqi-0VwP; Wed, 14 Feb 2024 17:04:23 +0000 Received: from mail-pf1-f177.google.com ([209.85.210.177]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1raIgG-0000000Ddp4-15Pi for linux-arm-kernel@lists.infradead.org; Wed, 14 Feb 2024 17:04:21 +0000 Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-6e10614c276so1002875b3a.3 for ; Wed, 14 Feb 2024 09:04:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707930252; x=1708535052; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/rNhav+7L2/K8KIa8PybW7vaELkvxb4l6BfkxMKSsrw=; b=whdEPIb6x1mk1ZgLCjlP1a9ANTPpzZUmgIGMxtgxEOwWY61izw7RPN4CIBuURRmwyR IKd76TUrZjOX646kv0cjLSegGXHw5Q399uem4mzolBeStRKp6iHyccuidRysXrmay+uM pS3OKpuWyAlnusBlKIcdx+xGMSQTrfG1oGR0bctNxj5RIZAAI+Y5YH2yJsn7UTixv2lt HRV5z2an5WSLNeBzXl1aFK0Ruya11WqPLsjxczQ8GXR37Ctbzm2g1qS+Wwh1IgpFUOup nYOzNJzgMvNYebAJMOd9gAG0tD5epi/gBZtaMHX84ph7qKX92CJtQ33E6MmECGy+h6x3 dZ0Q== X-Forwarded-Encrypted: i=1; AJvYcCXleXEBC/7wNnSR/TUeKK4htY6TbOBmAlDJtMV71Vyktp2QNQQ+F2SUmcKT5IAvP/Pvo8+Nr/qL43VjZIEdd1jKj07Xb6SUm1R1e+NwKO7FVFpRzw0= X-Gm-Message-State: AOJu0Yy0PTb01koylR6AkzjnqHuTdLhjq3bVkpyoViSVGH8+lHgnBnXQ HS+ZrYmOm/UBOjQiapvp6WyMbdiAXjj97Gw986CHFZbEnG0beKzj2B6SuWMX/eo= X-Google-Smtp-Source: AGHT+IFsv4N1m6Boc7Pwj7tvZOfnK773MPq2SjotlEj2cK62z5QH3wAcvbwi5jo/bYE2q6zQdf8oJA== X-Received: by 2002:a05:6a00:2d88:b0:6de:209c:3228 with SMTP id fb8-20020a056a002d8800b006de209c3228mr3775946pfb.6.1707930252034; Wed, 14 Feb 2024 09:04:12 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWJVqfd3ZBC3+g61zbA6HBTnD5Z9te/X4KeI6sQ3exqNSyqiArKAuV6RrMShSBtA7aE+oEE1FeJ8XFiq7yuOqrwNh80fODw/mufUf254/czZyN6qcrvx7uhUT1Lary/1zGH8Lm79yKixhIlavYRfe+oDsyc+lkvDu3vtlWJpM6xVdvX6QCw2ATiy0FG/0CcjhetkWPk5tRSlnlL3NqpWcJqbOE1sY4tgb5TUr5btH2/pGmbTwy/ogx3S9VsVZLJkrsMGur4v0HqIc55SETLCGuzL0Xd57gfO6hcdmVs6K+vw1kXkE/82qDaOSDx3yweNe8iL9zt/MUAhk2UMhMnEGBv9senfEpuq3PKl7imMLZLJ02u9KOMY3GcGsJxzVeyrqJfPML99O7gP0VfAp/dKj4ESnPNbT6F54FSF8Wdtt0EN4UzgI54T8QMEVol5fnDVxRw+PQL2C7ejrAaFXbQ+th792TGBxTsSX0Xszvj56mg0EfeB/uW9JrN+f4Ibc5q8mqGUCwFvzjP/YGcEghaQRPbp7pKmO++FrLs/AlM4PXSwMZJiyfgAxLW07kXbSMoWgkd6sZ5aqvq9g== Received: from localhost (71-212-63-227.tukw.qwest.net. [71.212.63.227]) by smtp.gmail.com with ESMTPSA id r19-20020aa78b93000000b006e02cdad499sm9842044pfd.99.2024.02.14.09.04.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 09:04:10 -0800 (PST) From: Kevin Hilman To: Bhargav Raviprakash , linux-kernel@vger.kernel.org Cc: m.nirmaladevi@ltts.com, lee@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jpanis@baylibre.com, devicetree@vger.kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, lgirdwood@gmail.com, broonie@kernel.org, linus.walleij@linaro.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, nm@ti.com, vigneshr@ti.com, kristo@kernel.org, Bhargav Raviprakash Subject: Re: [RESEND PATCH v1 04/13] mfd: tps6594-i2c: Add TI TPS65224 PMIC I2C In-Reply-To: <20240208105343.1212902-5-bhargav.r@ltts.com> References: <20240208105343.1212902-1-bhargav.r@ltts.com> <20240208105343.1212902-5-bhargav.r@ltts.com> Date: Wed, 14 Feb 2024 09:04:10 -0800 Message-ID: <7hplwz565x.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240214_090420_331004_58AF91C3 X-CRM114-Status: GOOD ( 10.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, Bhargav Raviprakash writes: > Add support for TPS65224 PMIC in TPS6594's I2C driver which has > significant functional overlap. > > Signed-off-by: Bhargav Raviprakash Thanks for the patch adding TPS65224 support [...] > @@ -216,15 +217,18 @@ static int tps6594_i2c_probe(struct i2c_client *client) > tps->reg = client->addr; > tps->irq = client->irq; > > - tps->regmap = devm_regmap_init(dev, NULL, client, &tps6594_i2c_regmap_config); > - if (IS_ERR(tps->regmap)) > - return dev_err_probe(dev, PTR_ERR(tps->regmap), "Failed to init regmap\n"); > - > match = of_match_device(tps6594_i2c_of_match_table, dev); > if (!match) > return dev_err_probe(dev, -EINVAL, "Failed to find matching chip ID\n"); > tps->chip_id = (unsigned long)match->data; > > + if (tps->chip_id == TPS65224) > + tps6594_i2c_regmap_config.volatile_table = &tps65224_volatile_table; minor nit: for chip-specific differnces like this, rather than do this kind of "if" check here to update the regmap_config, instead use the compatible match data have a separate i2c_regmap_config match table for tps65224. Kevin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel