From: Kevin Hilman <khilman@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] soc: meson: enable building drivers as modules
Date: Tue, 20 Oct 2020 14:00:30 -0700 [thread overview]
Message-ID: <7hpn5ck3yp.fsf@baylibre.com> (raw)
In-Reply-To: <CAFBinCAXcmnbzuQg4syZiDM0jvivHpiPzYYdtGOG1E81QMc3mQ@mail.gmail.com>
Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:
> Hi Kevin,
>
> On Tue, Oct 20, 2020 at 12:47 AM Kevin Hilman <khilman@baylibre.com> wrote:
> [...]
>> diff --git a/drivers/soc/amlogic/meson-secure-pwrc.c b/drivers/soc/amlogic/meson-secure-pwrc.c
>> index 5fb29a475879..2dfcb7b6e664 100644
>> --- a/drivers/soc/amlogic/meson-secure-pwrc.c
>> +++ b/drivers/soc/amlogic/meson-secure-pwrc.c
>> @@ -13,6 +13,7 @@
>> #include <dt-bindings/power/meson-a1-power.h>
>> #include <linux/arm-smccc.h>
>> #include <linux/firmware/meson/meson_sm.h>
>> +#include <linux/module.h>
>>
>> #define PWRC_ON 1
>> #define PWRC_OFF 0
>> @@ -193,6 +194,7 @@ static const struct of_device_id meson_secure_pwrc_match_table[] = {
>> },
>> { /* sentinel */ }
>> };
>> +MODULE_DEVICE_TABLE(of, meson_secure_pwrc_match_table);
>>
>> static struct platform_driver meson_secure_pwrc_driver = {
>> .probe = meson_secure_pwrc_probe,
>> @@ -201,4 +203,5 @@ static struct platform_driver meson_secure_pwrc_driver = {
>> .of_match_table = meson_secure_pwrc_match_table,
>> },
>> };
>> -builtin_platform_driver(meson_secure_pwrc_driver);
>> +module_platform_driver(meson_secure_pwrc_driver);
>> +MODULE_LICENSE("Dual BSD/GPL");
> This file uses SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> do we need to use MODULE_LICENSE("Dual MIT/GPL v2"); in this case?
Since the SPDX header says GPL2+, I'll change this to:
MODULE_LICENSE("Dual MIT/GPL");
Good catch, thanks!
Kevin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-20 21:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 22:46 [PATCH 1/2] soc: mx-socinfo: only build for arm Kevin Hilman
2020-10-19 22:46 ` [PATCH 2/2] soc: meson: enable building drivers as modules Kevin Hilman
2020-10-20 19:44 ` Martin Blumenstingl
2020-10-20 21:00 ` Kevin Hilman [this message]
2020-10-20 7:58 ` [PATCH 1/2] soc: mx-socinfo: only build for arm Jerome Brunet
2020-10-20 14:47 ` Kevin Hilman
2020-10-20 19:40 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hpn5ck3yp.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).