From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDD6EC4363A for ; Tue, 20 Oct 2020 21:02:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BE3121548 for ; Tue, 20 Oct 2020 21:02:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="q4DgiHLp"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="q6P2TcP8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BE3121548 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sMe1HxiTh8YkllCRF7SElHcqOJla7v0zKV9kPL0NCfU=; b=q4DgiHLpdI9ezmrCv/gepBnbk W7E1WAreBgwRzO1ZCziYz8ho7F0rJKy2WreG2Zg4xtrvLojnrC+v9dPLYHQMnGTyf1CK3AJbsJ1mJ q+pbAFOGAiw36N3Hw72uD8QWMHMbbPBZvjoX3krxpCy7mqHt+pAkRsKrjRL96nWrdE/R0HkvJYBXA B/3MIduWJcGcvMD85pNT4Ij2ziv/SC7TCLlZL0JLHqEvhdMv/XAMDVhhmJQeOvqzntSgePc+N6Qeb 1vR0cyJ+YcdnwReI3hHefSQNg5FZuyhv5W4QdSLn7vOQYIoB/+Wo3uzC5BouRkB0hTLIuyIDK8Ogd aQ6SmGwaw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUykH-0008Al-C7; Tue, 20 Oct 2020 21:00:37 +0000 Received: from mail-pj1-x1042.google.com ([2607:f8b0:4864:20::1042]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUykD-00089i-Th for linux-arm-kernel@lists.infradead.org; Tue, 20 Oct 2020 21:00:35 +0000 Received: by mail-pj1-x1042.google.com with SMTP id p3so1268851pjd.0 for ; Tue, 20 Oct 2020 14:00:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=ehJTgQK+jvHaWoYT/Sgm6HAaNherPc/KXjHhyZ957G8=; b=q6P2TcP8lhBHHpIq67nl9e4koJ1gaagX1jdYnAiLPclTmOisOLMYU+CE7u3IZRZvo5 t3Htc1MQlQWrclXlIk/JwVv6HHJqeNpelSw+eZpteaAbUKYanU+e7EKgMF2nqu5dY6Y+ 6zz39Rk3XPvvqRlxYvLnFA3gcmWn9N9hw/0rRRqSvevYYwaEs2D9F7MwXlGfejCnSjAn mMtZ9qoIneO+IrHh2T8K5uzb90WgwLaV0eYmHeVB8Rd72PXLOGWreGIMo95blAcILz7W 27Db5JV5jtrAE3gxC1VoEXfw8c4RI1KhpLL5jkQtwwCkXYhc8TEYt+0bcTWPB0vjXtIW 90kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=ehJTgQK+jvHaWoYT/Sgm6HAaNherPc/KXjHhyZ957G8=; b=PX+P6WtJmiGOxKOz79P2pGr1S8uFSKiC5jc7EBp62gLG/2uzII9n/yvLcODuwGKm/t ktm6CLZjevVnNXrM2p7p9ibeRkGQ8oWNaW7Ow+qgg7Cpb1j5UAe76gF+nMmlJ0pwP8ux P3UGzEdgXO+Q6y8u2Cx8Lq2NtmNLjdDxWy2wDDsRgrwva1Ze+iz3gZ3+QVLxRprY4LhF 12Xs4foTmqKFNdwPz5TzAQMYeYx2fSNBnmg2X+ni2U435By4qtARlMKE09W/kwUghZgv taWJpyomneI61DL26m4SFYclo+hHU9sgI0Ic0t1VChaLuP92XJU3HW8mtjspraDj9j/O t5Nw== X-Gm-Message-State: AOAM531guKpNn7888oElK962/hISEVgokLkftPNJAx+szV6uQhnwwNhk m0mhM/9KiRlpKtUUu4Gkus9vfg== X-Google-Smtp-Source: ABdhPJwz4EtlYE+QMTKTa9kMc0Jd4XV7TkBTC+xltGTf7r4iWnuUjJ7nOLgAPGKYENLBYC4It4Y/BA== X-Received: by 2002:a17:90a:6a4f:: with SMTP id d15mr18936pjm.80.1603227631674; Tue, 20 Oct 2020 14:00:31 -0700 (PDT) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id i126sm2975641pfc.48.2020.10.20.14.00.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Oct 2020 14:00:30 -0700 (PDT) From: Kevin Hilman To: Martin Blumenstingl Subject: Re: [PATCH 2/2] soc: meson: enable building drivers as modules In-Reply-To: References: <20201019224649.14302-1-khilman@baylibre.com> <20201019224649.14302-2-khilman@baylibre.com> Date: Tue, 20 Oct 2020 14:00:30 -0700 Message-ID: <7hpn5ck3yp.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201020_170034_094243_E78B6145 X-CRM114-Status: GOOD ( 13.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Martin Blumenstingl writes: > Hi Kevin, > > On Tue, Oct 20, 2020 at 12:47 AM Kevin Hilman wrote: > [...] >> diff --git a/drivers/soc/amlogic/meson-secure-pwrc.c b/drivers/soc/amlogic/meson-secure-pwrc.c >> index 5fb29a475879..2dfcb7b6e664 100644 >> --- a/drivers/soc/amlogic/meson-secure-pwrc.c >> +++ b/drivers/soc/amlogic/meson-secure-pwrc.c >> @@ -13,6 +13,7 @@ >> #include >> #include >> #include >> +#include >> >> #define PWRC_ON 1 >> #define PWRC_OFF 0 >> @@ -193,6 +194,7 @@ static const struct of_device_id meson_secure_pwrc_match_table[] = { >> }, >> { /* sentinel */ } >> }; >> +MODULE_DEVICE_TABLE(of, meson_secure_pwrc_match_table); >> >> static struct platform_driver meson_secure_pwrc_driver = { >> .probe = meson_secure_pwrc_probe, >> @@ -201,4 +203,5 @@ static struct platform_driver meson_secure_pwrc_driver = { >> .of_match_table = meson_secure_pwrc_match_table, >> }, >> }; >> -builtin_platform_driver(meson_secure_pwrc_driver); >> +module_platform_driver(meson_secure_pwrc_driver); >> +MODULE_LICENSE("Dual BSD/GPL"); > This file uses SPDX-License-Identifier: (GPL-2.0+ OR MIT) > do we need to use MODULE_LICENSE("Dual MIT/GPL v2"); in this case? Since the SPDX header says GPL2+, I'll change this to: MODULE_LICENSE("Dual MIT/GPL"); Good catch, thanks! Kevin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel