From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC840C43387 for ; Fri, 11 Jan 2019 00:21:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B62C2133F for ; Fri, 11 Jan 2019 00:21:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ja8Wy/2p"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="GSnRMTVE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B62C2133F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nlckedCo6AEo56/Bh3bnpQwogGdK0LxlkrOUIDf5HaA=; b=ja8Wy/2pHlCtE+ zUNILUGKKohd052kLHEMBqOYaubsIaU6jz5W7IuuWsKdOQsWU8jrTxdYOs7RA1pbX6xmXzJRCqtNy eq+uf0WPlQP/vlNq+EudKCavk1ofqj+sU1yIzFJfkQ+8KfhFqamvuEKRp72DSgbjECC14wzkM1Eb4 HTdHbfVWakKmdjNUIZau6LwuQFhnB0Mnu+qrhTbS9KFa1tj9dlbWKIdPRYcvuqaoFaPJd/PJkJncj u+TN/+VC6KI71vHx8NS8GC+u6r3cJ/NfyG2Nadm0GupyI2WEgvro2kBSvED/VlBNbXQPlD6+cwDNi 40l1toysgyfbXa9vI3yA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ghkZd-0001tQ-N7; Fri, 11 Jan 2019 00:21:21 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ghkZY-0001sC-KX for linux-arm-kernel@lists.infradead.org; Fri, 11 Jan 2019 00:21:18 +0000 Received: by mail-pl1-x642.google.com with SMTP id y1so5909083plp.9 for ; Thu, 10 Jan 2019 16:21:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=U5ied4IpUVo0pHUmsHibr0IXWO/yNrasETY2g43N018=; b=GSnRMTVEQIOAn5/ac55f+bPtbB0vLJc5Q5RLD2gZ1eVov4WuW4XdmZRXjYkL3uBITz MBP5SSQbJO42xGViJbJRRbBH2wlHpRyFsGvVCzVlvMJYys0XgHHHVDi6PNyxX/9iDIzX pJWDvlAJ1GHRwErhfE6PEEPJSFJDzjj99SvoS7wTNgV57GuloN5FzV60L9ztphtjjtQx rv9/SjAw3sQGbB6lnIS0fdGnYJ6coQp0dEf+wUzVxoOFbEwJ5yjhpsUprLTNkp8oh47W DVM8Z8iSC9wu7lJg2AsBg1D4P4yfinK8zM8i/KaX3Z5ckU9xeUD7iwBs++LicSZEAWYp lcEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=U5ied4IpUVo0pHUmsHibr0IXWO/yNrasETY2g43N018=; b=ke9kSYK7V67BjyzBABh2njIsGL33ZOFjxhfk5Lf347VLBa80gpZGHrCJQGtEwDSifO m4neVv6PJNvaKPYimrMrlxY7WB3i47QahPfbliBM1nipZG4GsfaJfB2sbtSqSLmeGl8F zkul6wqyOco3npgTLGzbPk16hUgq7fsB0xxF4GLIeD0y+1UDNr9iHv0ZgGt0T3L2nChx 87zZWw7iHeo4ev5TsFcQvN65XcakrrYGEmXk5Ye+I9aUSTBx27akFyQOftONIxyNvR7h hPfMuaowFmvFw5680gWOvqKoctVOVEhFnptar/7oqQN2m2f7PJD7xfcETCFvYuBI+A1Z LC+Q== X-Gm-Message-State: AJcUukeynlqzTMR7Tsl2D3Cr+p13t0DaIGs+mhkeoritLVkLyk5a4tUD SLp1HTX8X4OmNPowEVaqigwl4ODKFJA= X-Google-Smtp-Source: ALg8bN5uPOktJrpj7ce1wLi9pSB5u80P34ytQ6EYAHFCV2NXGoFCHVzYDGrv5Dvdnbht11jwx/hcHw== X-Received: by 2002:a17:902:8ec8:: with SMTP id x8mr12542185plo.210.1547166075478; Thu, 10 Jan 2019 16:21:15 -0800 (PST) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.googlemail.com with ESMTPSA id b68sm115136686pfg.160.2019.01.10.16.21.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 Jan 2019 16:21:14 -0800 (PST) From: Kevin Hilman To: Martin Blumenstingl , Carlo Caione Subject: Re: [PATCH v2 2/2] arm: dts: meson: Fix IRQ trigger type for macirq In-Reply-To: References: <20181207105231.25593-1-ccaione@baylibre.com> <20181207105231.25593-3-ccaione@baylibre.com> Date: Thu, 10 Jan 2019 16:21:14 -0800 Message-ID: <7hpnt4qc1x.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190110_162116_669589_697AC70D X-CRM114-Status: GOOD ( 15.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, ingrassia@epigenesys.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Martin Blumenstingl writes: > Hi Carlo, > > On Fri, Dec 7, 2018 at 11:52 AM Carlo Caione wrote: >> >> A long running stress test on a custom board shipping an AXG SoCs and a >> Realtek RTL8211F PHY revealed that after a few hours the connection >> speed would drop drastically, from ~1000Mbps to ~3Mbps. At the same time >> the 'macirq' (eth0) IRQ would stop being triggered at all and as >> consequence the GMAC IRQs never ACKed. >> >> After a painful investigation the problem seemed to be due to a wrong >> defined IRQ type for the GMAC IRQ that should be LEVEL_HIGH instead of >> EDGE_RISING. >> >> The change in the macirq IRQ type also solved another long standing >> issue affecting this SoC/PHY where EEE was causing the network >> connection to die after stressing it with iperf3 (even though much >> sooner). It's now possible to remove the 'eee-broken-1000t' quirk as >> well. > (disclaimer: I was not able to reproduce this bug without your > patches, but I didn't run iperf3 for more than a couple of minutes) > I did test your patch with and without my "Meson8b RGMII Ethernet pin > cleanup" from [0] which shows that there's another performance related > problem: > 1) before and after your patch receive speeds were fine (above > 700Mbit/s and no transmit errors / retries in iperf3) but the transmit > speed was bad (<200Mbit/s and >1500 retries in perf3) > 2) transmit errors (when Odroid-C1 is sending) are not occurring > anymore after my patch from [0] > > thus I believe your patch is fine, especially since we already have > IRQ_TYPE_LEVEL_HIGH for the dwc2 controllers > >> Fixes: 9c15795a4f96 ("ARM: dts: meson8b-odroidc1: ethernet support") >> Signed-off-by: Carlo Caione > Reviewed-by: Martin Blumenstingl > Tested-by: Martin Blumenstingl > > I wonder if Kevin can send this as a fix for v4.20 Queued as a fix for v5.0-rc Kevin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel