[PATCHv3 1/2] dt-bindings: mfd: syscon: Add ti,j721e-acspcie-proxy-ctrl compatible

[PATCHv3 1/2] dt-bindings: mfd: syscon: Add ti,j721e-acspcie-proxy-ctrl compatible

[Romain Naour]

From: Romain Naour <romain.naour@skf.com>

The ACSPCIE_PROXY_CTRL registers within the CTRL_MMR space of TI's J721e
SoC are used to drive the reference clock to the PCIe Endpoint device via
the PAD IO Buffers. Add the compatible for allowing the PCIe driver to
obtain the regmap for the ACSPCIE_CTRL register within the System
Controller device-tree node in order to enable the PAD IO Buffers.

The Technical Reference Manual for J721e SoC with details of the
ASCPCIE_CTRL registers is available at:
https://www.ti.com/lit/zip/spruil1

Signed-off-by: Romain Naour <romain.naour@skf.com>
---
 Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
index b414de4fa779..032cdd30d95f 100644
--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
@@ -115,6 +115,7 @@ select:
           - ti,am625-dss-oldi-io-ctrl
           - ti,am62p-cpsw-mac-efuse
           - ti,am654-dss-oldi-io-ctrl
+          - ti,j721e-acspcie-proxy-ctrl
           - ti,j784s4-acspcie-proxy-ctrl
           - ti,j784s4-pcie-ctrl
           - ti,keystone-pllctrl
-- 
2.45.0

[PATCHv3 2/2] arm64: dts: ti: k3-j721e-beagleboneai64: Enable ACSPCIE output for PCIe1

[Romain Naour]

From: Romain Naour <romain.naour@skf.com>

Unlike the SK-TDA4VM (k3-j721e-sk) board, there is no clock generator
(CDCI6214RGET) on the BeagleBone AI-64 (k3-j721e-beagleboneai64) to
provide PCIe refclk signal to PCIe Endponts. So the ACSPCIE module must
provide refclk through PCIe_REFCLK pins.

Use the new "ti,syscon-acspcie-proxy-ctrl" property to enable ACSPCIE
module's PAD IO Buffers.

Cc: Siddharth Vadapalli <s-vadapalli@ti.com>
Signed-off-by: Romain Naour <romain.naour@skf.com>
---
With this patch, we can remove "HACK: Sierra: Drive clock out" patch
applied on vendor kernel for BeagleBone AI-64:
https://openbeagle.org/beagleboard/linux/-/commit/ad65d7ef675966cdbc5d75f2bd545fad1914ba9b

v3:
 - update "acspcie0_proxy_ctrl" compatible to "ti,j721e-acspcie-proxy-ctrl"
   since this property is specific to j721e variant.

v2:
 - use generic style comments
 - use "syscon" as generic node name for "acspcie0_proxy_ctrl" node
 - Keep the compatible "ti,j784s4-acspcie-proxy-ctrl" since the
   ACSPCIE buffer and its functionality is the same across all K3 SoCs.
   (Siddharth Vadapalli)

   "The compatible "ti,j784s4-acspcie-pcie-ctrl" should be reused for
   J721E and all other K3 SoCs.
   For example, see:
   https://lore.kernel.org/r/20240402105708.4114146-1-s-vadapalli@ti.com/
   which introduced "ti,am62p-cpsw-mac-efuse" compatible.

   The same compatible is reused across all K3 SoCs:
   https://lore.kernel.org/r/20240628151518.40100-1-afd@ti.com/ "
---
 arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts |  5 +++++
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi          | 10 ++++++++--
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
index fb899c99753e..741ad2ba6fdb 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
@@ -859,6 +859,11 @@ &pcie1_rc {
 	num-lanes = <2>;
 	max-link-speed = <3>;
 	reset-gpios = <&main_gpio0 22 GPIO_ACTIVE_HIGH>;
+	/*
+	 * There is no on-board or external reference clock generators,
+	 * use refclk from the ACSPCIE module's PAD IO Buffers.
+	 */
+	ti,syscon-acspcie-proxy-ctrl = <&acspcie0_proxy_ctrl 0x3>;
 };
 
 &ufs_wrapper {
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
index af3d730154ac..32a232a90100 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
@@ -5,6 +5,7 @@
  * Copyright (C) 2016-2024 Texas Instruments Incorporated - https://www.ti.com/
  */
 #include <dt-bindings/phy/phy.h>
+#include <dt-bindings/phy/phy-cadence.h>
 #include <dt-bindings/phy/phy-ti.h>
 #include <dt-bindings/mux/mux.h>
 
@@ -82,6 +83,11 @@ ehrpwm_tbclk: clock-controller@4140 {
 			reg = <0x4140 0x18>;
 			#clock-cells = <1>;
 		};
+
+		acspcie0_proxy_ctrl: syscon@18090 {
+			compatible = "ti,j721e-acspcie-proxy-ctrl", "syscon";
+			reg = <0x18090 0x4>;
+		};
 	};
 
 	main_ehrpwm0: pwm@3000000 {
@@ -979,8 +985,8 @@ pcie1_rc: pcie@2910000 {
 		max-link-speed = <3>;
 		num-lanes = <2>;
 		power-domains = <&k3_pds 240 TI_SCI_PD_EXCLUSIVE>;
-		clocks = <&k3_clks 240 1>;
-		clock-names = "fck";
+		clocks = <&k3_clks 240 1>, <&serdes1 CDNS_SIERRA_DERIVED_REFCLK>;
+		clock-names = "fck", "pcie_refclk";
 		#address-cells = <3>;
 		#size-cells = <2>;
 		bus-range = <0x0 0xff>;
-- 
2.45.0

Re: [PATCHv3 1/2] dt-bindings: mfd: syscon: Add ti,j721e-acspcie-proxy-ctrl compatible

[Krzysztof Kozlowski]

On Mon, Dec 02, 2024 at 03:33:30PM +0100, Romain Naour wrote:
> From: Romain Naour <romain.naour@skf.com>
> 
> The ACSPCIE_PROXY_CTRL registers within the CTRL_MMR space of TI's J721e
> SoC are used to drive the reference clock to the PCIe Endpoint device via
> the PAD IO Buffers. Add the compatible for allowing the PCIe driver to
> obtain the regmap for the ACSPCIE_CTRL register within the System
> Controller device-tree node in order to enable the PAD IO Buffers.
> 
> The Technical Reference Manual for J721e SoC with details of the
> ASCPCIE_CTRL registers is available at:
> https://www.ti.com/lit/zip/spruil1
> 
> Signed-off-by: Romain Naour <romain.naour@skf.com>
> ---
>  Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCHv3 1/2] dt-bindings: mfd: syscon: Add ti,j721e-acspcie-proxy-ctrl compatible

[Kevin Hilman]

On Mon, 02 Dec 2024 15:33:30 +0100, Romain Naour wrote:
> The ACSPCIE_PROXY_CTRL registers within the CTRL_MMR space of TI's J721e
> SoC are used to drive the reference clock to the PCIe Endpoint device via
> the PAD IO Buffers. Add the compatible for allowing the PCIe driver to
> obtain the regmap for the ACSPCIE_CTRL register within the System
> Controller device-tree node in order to enable the PAD IO Buffers.
> 
> The Technical Reference Manual for J721e SoC with details of the
> ASCPCIE_CTRL registers is available at:
> https://www.ti.com/lit/zip/spruil1
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: mfd: syscon: Add ti,j721e-acspcie-proxy-ctrl compatible
      commit: d8efc0b428856137608ffcbb6994da6041c9fe2a
[2/2] arm64: dts: ti: k3-j721e-beagleboneai64: Enable ACSPCIE output for PCIe1
      commit: 1d5e14a20dc60b440c60bec8489acfd45cdf7508

Best regards,
-- 
Kevin Hilman <khilman@baylibre.com>

Re: [PATCHv3 1/2] dt-bindings: mfd: syscon: Add ti,j721e-acspcie-proxy-ctrl compatible

[Nishanth Menon]

On 15:07-20241205, Kevin Hilman wrote:
> 
> On Mon, 02 Dec 2024 15:33:30 +0100, Romain Naour wrote:
> > The ACSPCIE_PROXY_CTRL registers within the CTRL_MMR space of TI's J721e
> > SoC are used to drive the reference clock to the PCIe Endpoint device via
> > the PAD IO Buffers. Add the compatible for allowing the PCIe driver to
> > obtain the regmap for the ACSPCIE_CTRL register within the System
> > Controller device-tree node in order to enable the PAD IO Buffers.
> > 
> > The Technical Reference Manual for J721e SoC with details of the
> > ASCPCIE_CTRL registers is available at:
> > https://www.ti.com/lit/zip/spruil1
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/2] dt-bindings: mfd: syscon: Add ti,j721e-acspcie-proxy-ctrl compatible
>       commit: d8efc0b428856137608ffcbb6994da6041c9fe2a
> [2/2] arm64: dts: ti: k3-j721e-beagleboneai64: Enable ACSPCIE output for PCIe1
>       commit: 1d5e14a20dc60b440c60bec8489acfd45cdf7508
> 
> Best regards,
> -- 
> Kevin Hilman <khilman@baylibre.com>
> 
This will need a bit of fixup - See along the lines of the following.
Additionally, we should be a bit careful about the dependency of dts
mix up from two trees.

https://lore.kernel.org/all/20250103174524.28768-1-afd@ti.com/T/#m15dcfa786fc430d54cf96475afc10648372f8589

From Andrew Davis:

diff --git a/Documentation/devicetree/bindings/soc/ti/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,j721e-system-controller.yaml
index 378e9cc5fac2a..3323f3bc976e0 100644
--- a/Documentation/devicetree/bindings/soc/ti/ti,j721e-system-controller.yaml
+++ b/Documentation/devicetree/bindings/soc/ti/ti,j721e-system-controller.yaml
@@ -68,6 +68,12 @@ patternProperties:
     description:
       The node corresponding to SoC chip identification.
 
+  "^aspcie-ctrl@[0-9a-f]+$":
+    type: object
+    $ref: /schemas/mfd/syscon.yaml#
+    description:
+      This is the ASPCIe control region.
+
 required:
   - compatible
   - reg
@@ -110,5 +116,10 @@ examples:
             compatible = "ti,am654-chipid";
             reg = <0x14 0x4>;
         };
+
+        acspcie0_proxy_ctrl: aspcie-ctrl@18090 {
+            compatible = "ti,j721e-acspcie-proxy-ctrl", "syscon";
+            reg = <0x18090 0x4>;
+        };
     };
 ...
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
index 32a232a90100e..4b2101e90fb51 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
@@ -84,7 +84,7 @@ ehrpwm_tbclk: clock-controller@4140 {
                        #clock-cells = <1>;
                };
 
-               acspcie0_proxy_ctrl: syscon@18090 {
+               acspcie0_proxy_ctrl: aspcie-ctrl@18090 {
                        compatible = "ti,j721e-acspcie-proxy-ctrl", "syscon";
                        reg = <0x18090 0x4>;
                };

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [PATCHv3 1/2] dt-bindings: mfd: syscon: Add ti,j721e-acspcie-proxy-ctrl compatible

[Kevin Hilman]

Nishanth Menon <nm@ti.com> writes:

> On 15:07-20241205, Kevin Hilman wrote:
>> 
>> On Mon, 02 Dec 2024 15:33:30 +0100, Romain Naour wrote:
>> > The ACSPCIE_PROXY_CTRL registers within the CTRL_MMR space of TI's J721e
>> > SoC are used to drive the reference clock to the PCIe Endpoint device via
>> > the PAD IO Buffers. Add the compatible for allowing the PCIe driver to
>> > obtain the regmap for the ACSPCIE_CTRL register within the System
>> > Controller device-tree node in order to enable the PAD IO Buffers.
>> > 
>> > The Technical Reference Manual for J721e SoC with details of the
>> > ASCPCIE_CTRL registers is available at:
>> > https://www.ti.com/lit/zip/spruil1
>> > 
>> > [...]
>> 
>> Applied, thanks!
>> 
>> [1/2] dt-bindings: mfd: syscon: Add ti,j721e-acspcie-proxy-ctrl compatible
>>       commit: d8efc0b428856137608ffcbb6994da6041c9fe2a
>> [2/2] arm64: dts: ti: k3-j721e-beagleboneai64: Enable ACSPCIE output for PCIe1
>>       commit: 1d5e14a20dc60b440c60bec8489acfd45cdf7508
>> 
>> Best regards,
>> -- 
>> Kevin Hilman <khilman@baylibre.com>
>> 
> This will need a bit of fixup - See along the lines of the following.
> Additionally, we should be a bit careful about the dependency of dts
> mix up from two trees.

sorry, these should be going through your tree in the first place.  They
are now dropped from my tree, please go ahead and take them along with
Andrews fixup.  Sorry for complicating things.

Kevin

Re: [PATCHv3 1/2] dt-bindings: mfd: syscon: Add ti,j721e-acspcie-proxy-ctrl compatible

[Nishanth Menon]

On 14:46-20250107, Kevin Hilman wrote:
> Nishanth Menon <nm@ti.com> writes:
> 
> > On 15:07-20241205, Kevin Hilman wrote:
> >> 
> >> On Mon, 02 Dec 2024 15:33:30 +0100, Romain Naour wrote:
> >> > The ACSPCIE_PROXY_CTRL registers within the CTRL_MMR space of TI's J721e
> >> > SoC are used to drive the reference clock to the PCIe Endpoint device via
> >> > the PAD IO Buffers. Add the compatible for allowing the PCIe driver to
> >> > obtain the regmap for the ACSPCIE_CTRL register within the System
> >> > Controller device-tree node in order to enable the PAD IO Buffers.
> >> > 
> >> > The Technical Reference Manual for J721e SoC with details of the
> >> > ASCPCIE_CTRL registers is available at:
> >> > https://www.ti.com/lit/zip/spruil1
> >> > 
> >> > [...]
> >> 
> >> Applied, thanks!
> >> 
> >> [1/2] dt-bindings: mfd: syscon: Add ti,j721e-acspcie-proxy-ctrl compatible
> >>       commit: d8efc0b428856137608ffcbb6994da6041c9fe2a
> >> [2/2] arm64: dts: ti: k3-j721e-beagleboneai64: Enable ACSPCIE output for PCIe1
> >>       commit: 1d5e14a20dc60b440c60bec8489acfd45cdf7508
> >> 
> >> Best regards,
> >> -- 
> >> Kevin Hilman <khilman@baylibre.com>
> >> 
> > This will need a bit of fixup - See along the lines of the following.
> > Additionally, we should be a bit careful about the dependency of dts
> > mix up from two trees.
> 
> sorry, these should be going through your tree in the first place.  They
> are now dropped from my tree, please go ahead and take them along with
> Andrews fixup.  Sorry for complicating things.


Romain,

There is additional fixups needed, unfortunately as well: syscon yaml
has two lists based on which dt-schema version you use.. your patch
fixed one list, but missed the other as well. Could you integrate the
fixes and resubmit, please?


-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Something of this form needs to be squashed.

diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
index 348025870b0f7..dda489916bc54 100644
--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
@@ -216,6 +216,8 @@ properties:
           - ti,am62p-cpsw-mac-efuse
           - ti,am654-dss-oldi-io-ctrl
           - ti,am654-icssg-ctrl
+          - ti,j721e-acspcie-proxy-ctrl
           - ti,j784s4-pcie-ctrl
           - ti,keystone-pllctrl
       - const: syscon 

Re: [PATCHv3 1/2] dt-bindings: mfd: syscon: Add ti,j721e-acspcie-proxy-ctrl compatible

[Andrew Davis]

On 1/8/25 7:11 AM, Nishanth Menon wrote:
> On 14:46-20250107, Kevin Hilman wrote:
>> Nishanth Menon <nm@ti.com> writes:
>>
>>> On 15:07-20241205, Kevin Hilman wrote:
>>>>
>>>> On Mon, 02 Dec 2024 15:33:30 +0100, Romain Naour wrote:
>>>>> The ACSPCIE_PROXY_CTRL registers within the CTRL_MMR space of TI's J721e
>>>>> SoC are used to drive the reference clock to the PCIe Endpoint device via
>>>>> the PAD IO Buffers. Add the compatible for allowing the PCIe driver to
>>>>> obtain the regmap for the ACSPCIE_CTRL register within the System
>>>>> Controller device-tree node in order to enable the PAD IO Buffers.
>>>>>
>>>>> The Technical Reference Manual for J721e SoC with details of the
>>>>> ASCPCIE_CTRL registers is available at:
>>>>> https://www.ti.com/lit/zip/spruil1
>>>>>
>>>>> [...]
>>>>
>>>> Applied, thanks!
>>>>
>>>> [1/2] dt-bindings: mfd: syscon: Add ti,j721e-acspcie-proxy-ctrl compatible
>>>>        commit: d8efc0b428856137608ffcbb6994da6041c9fe2a
>>>> [2/2] arm64: dts: ti: k3-j721e-beagleboneai64: Enable ACSPCIE output for PCIe1
>>>>        commit: 1d5e14a20dc60b440c60bec8489acfd45cdf7508
>>>>
>>>> Best regards,
>>>> -- 
>>>> Kevin Hilman <khilman@baylibre.com>
>>>>
>>> This will need a bit of fixup - See along the lines of the following.
>>> Additionally, we should be a bit careful about the dependency of dts
>>> mix up from two trees.
>>
>> sorry, these should be going through your tree in the first place.  They
>> are now dropped from my tree, please go ahead and take them along with
>> Andrews fixup.  Sorry for complicating things.
> 
> 
> Romain,
> 
> There is additional fixups needed, unfortunately as well: syscon yaml
> has two lists based on which dt-schema version you use.. your patch
> fixed one list, but missed the other as well. Could you integrate the
> fixes and resubmit, please?
> 
> 

Or since we already have 'ti,j784s4-acspcie-proxy-ctrl' for the same
reason, you could drop the first patch and re-use this compatible.

For the second patch, you'll still need to add in my suggested
changes and re-send.

Andrew

Re: [PATCHv3 1/2] dt-bindings: mfd: syscon: Add ti,j721e-acspcie-proxy-ctrl compatible

[Siddharth Vadapalli]

On Wed, Jan 08, 2025 at 09:09:37AM -0600, Andrew Davis wrote:

Hello Andrew,

> On 1/8/25 7:11 AM, Nishanth Menon wrote:
> > On 14:46-20250107, Kevin Hilman wrote:
> > > Nishanth Menon <nm@ti.com> writes:
> > > 
> > > > On 15:07-20241205, Kevin Hilman wrote:
> > > > > 
> > > > > On Mon, 02 Dec 2024 15:33:30 +0100, Romain Naour wrote:
> > > > > > The ACSPCIE_PROXY_CTRL registers within the CTRL_MMR space of TI's J721e
> > > > > > SoC are used to drive the reference clock to the PCIe Endpoint device via
> > > > > > the PAD IO Buffers. Add the compatible for allowing the PCIe driver to
> > > > > > obtain the regmap for the ACSPCIE_CTRL register within the System
> > > > > > Controller device-tree node in order to enable the PAD IO Buffers.
> > > > > > 
> > > > > > The Technical Reference Manual for J721e SoC with details of the
> > > > > > ASCPCIE_CTRL registers is available at:
> > > > > > https://www.ti.com/lit/zip/spruil1
> > > > > > 
> > > > > > [...]
> > > > > 
> > > > > Applied, thanks!
> > > > > 
> > > > > [1/2] dt-bindings: mfd: syscon: Add ti,j721e-acspcie-proxy-ctrl compatible
> > > > >        commit: d8efc0b428856137608ffcbb6994da6041c9fe2a
> > > > > [2/2] arm64: dts: ti: k3-j721e-beagleboneai64: Enable ACSPCIE output for PCIe1
> > > > >        commit: 1d5e14a20dc60b440c60bec8489acfd45cdf7508
> > > > > 
> > > > > Best regards,
> > > > > -- 
> > > > > Kevin Hilman <khilman@baylibre.com>
> > > > > 
> > > > This will need a bit of fixup - See along the lines of the following.
> > > > Additionally, we should be a bit careful about the dependency of dts
> > > > mix up from two trees.
> > > 
> > > sorry, these should be going through your tree in the first place.  They
> > > are now dropped from my tree, please go ahead and take them along with
> > > Andrews fixup.  Sorry for complicating things.
> > 
> > 
> > Romain,
> > 
> > There is additional fixups needed, unfortunately as well: syscon yaml
> > has two lists based on which dt-schema version you use.. your patch
> > fixed one list, but missed the other as well. Could you integrate the
> > fixes and resubmit, please?
> > 
> > 
> 
> Or since we already have 'ti,j784s4-acspcie-proxy-ctrl' for the same
> reason, you could drop the first patch and re-use this compatible.

I had suggested this in the past since the ACSPCIE IP on J784S4 and J721E
is the same, but Krzysztof insists that there will be hardware differences
in the ACSPCIE block across J784S4 and J721E irrespective of what the
datasheet says, as mentioned by Krzysztof at:
https://lore.kernel.org/r/1bfdf1f1-7542-4149-a85d-2ac4b659b26b@kernel.org/
Therefore Romain had to introduce a new compatible for J721E.

Regards,
Siddharth.

Re: [PATCHv3 1/2] dt-bindings: mfd: syscon: Add ti,j721e-acspcie-proxy-ctrl compatible

[Romain Naour]

Hello Andrew, Siddharth, All,

Le 08/01/2025 à 16:46, Siddharth Vadapalli a écrit :
> On Wed, Jan 08, 2025 at 09:09:37AM -0600, Andrew Davis wrote:
> 
> Hello Andrew,
> 
>> On 1/8/25 7:11 AM, Nishanth Menon wrote:
>>> On 14:46-20250107, Kevin Hilman wrote:
>>>> Nishanth Menon <nm@ti.com> writes:
>>>>
>>>>> On 15:07-20241205, Kevin Hilman wrote:
>>>>>>
>>>>>> On Mon, 02 Dec 2024 15:33:30 +0100, Romain Naour wrote:
>>>>>>> The ACSPCIE_PROXY_CTRL registers within the CTRL_MMR space of TI's J721e
>>>>>>> SoC are used to drive the reference clock to the PCIe Endpoint device via
>>>>>>> the PAD IO Buffers. Add the compatible for allowing the PCIe driver to
>>>>>>> obtain the regmap for the ACSPCIE_CTRL register within the System
>>>>>>> Controller device-tree node in order to enable the PAD IO Buffers.
>>>>>>>
>>>>>>> The Technical Reference Manual for J721e SoC with details of the
>>>>>>> ASCPCIE_CTRL registers is available at:
>>>>>>> https://www.ti.com/lit/zip/spruil1
>>>>>>>
>>>>>>> [...]
>>>>>>
>>>>>> Applied, thanks!
>>>>>>
>>>>>> [1/2] dt-bindings: mfd: syscon: Add ti,j721e-acspcie-proxy-ctrl compatible
>>>>>>        commit: d8efc0b428856137608ffcbb6994da6041c9fe2a
>>>>>> [2/2] arm64: dts: ti: k3-j721e-beagleboneai64: Enable ACSPCIE output for PCIe1
>>>>>>        commit: 1d5e14a20dc60b440c60bec8489acfd45cdf7508
>>>>>>
>>>>>> Best regards,
>>>>>> -- 
>>>>>> Kevin Hilman <khilman@baylibre.com>
>>>>>>
>>>>> This will need a bit of fixup - See along the lines of the following.
>>>>> Additionally, we should be a bit careful about the dependency of dts
>>>>> mix up from two trees.
>>>>
>>>> sorry, these should be going through your tree in the first place.  They
>>>> are now dropped from my tree, please go ahead and take them along with
>>>> Andrews fixup.  Sorry for complicating things.
>>>
>>>
>>> Romain,
>>>
>>> There is additional fixups needed, unfortunately as well: syscon yaml
>>> has two lists based on which dt-schema version you use.. your patch
>>> fixed one list, but missed the other as well. Could you integrate the
>>> fixes and resubmit, please?
>>>
>>>
>>
>> Or since we already have 'ti,j784s4-acspcie-proxy-ctrl' for the same
>> reason, you could drop the first patch and re-use this compatible.
> 
> I had suggested this in the past since the ACSPCIE IP on J784S4 and J721E
> is the same, but Krzysztof insists that there will be hardware differences
> in the ACSPCIE block across J784S4 and J721E irrespective of what the
> datasheet says, as mentioned by Krzysztof at:
> https://lore.kernel.org/r/1bfdf1f1-7542-4149-a85d-2ac4b659b26b@kernel.org/
> Therefore Romain had to introduce a new compatible for J721E.

There is a pending patch series from Andrew [1] fixing
ti,j784s4-acspcie-proxy-ctrl compatible for the same reason.

Should I take it into account before resubmit?

[1] https://lore.kernel.org/linux-devicetree/20250103174524.28768-1-afd@ti.com/

Best regards,
Romain


> 
> Regards,
> Siddharth.