From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15A01CE7A9F for ; Thu, 5 Sep 2024 22:00:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=debuxuNcW7Vau/i5ri1+uD5qWokdP8/oPSvRGMK4Oy4=; b=m7Dt1nXUqseN2hJnnt/QUvXl6p smWw2jFDIYIeJ3+ulmKoXrI+9np1V25Gt5FyYJvI62w9GXkfJUofaNyRtuE6TovXUBzHw9Ri39jG8 w5soZwT9mgUN4IBlNLbH6jkVSaH30V8xqCy7C1j+fD9Ss89hLcdzEjTg6ALYozBDDyRlRYL0k58na LAnTz33UCx9FD4rOZv1APfkN/Mqk384v8rjVmN16s3M0AFBDlUAsqAPzqKwnPGHr5Sbp0VT8Br59E N7s7i7pYHEw68Af35aJ3lqIbr3fqyp+4W45Ez4RF7dqJ0pPnJhwVBYplVYghFHahlk2uIGOtvRJSJ h6WB9vWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1smKWB-00000009wn9-2Nos; Thu, 05 Sep 2024 21:59:55 +0000 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1smKUV-00000009wXY-1eCi for linux-arm-kernel@lists.infradead.org; Thu, 05 Sep 2024 21:58:26 +0000 Received: by mail-pj1-x102c.google.com with SMTP id 98e67ed59e1d1-2d892997913so946908a91.3 for ; Thu, 05 Sep 2024 14:58:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1725573490; x=1726178290; darn=lists.infradead.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=debuxuNcW7Vau/i5ri1+uD5qWokdP8/oPSvRGMK4Oy4=; b=M2imUwhQKD/bNtsPA4eCtHL0+2aoHeCtSeh9xFKMuiEXeTUE3DJ6+DV9xISjrJlE+s jzmoV2BG1r8vzMh9BdbOw8pQnid74NZtrqPWRl/XnHLRDFN673COEqaqG3zouHgLwZbQ ZMMMEB0SG4GVEgUjhez4QtnJ33kqfdrxVQPRVkR6yFKmuJ5Lnkj9x367pS+HkHK07Lgt SQi0egf0fBaQc850ICzRlU0BvwhyHVVBpC0CRQsZUQWHGZBU8wG8NiyonkDwZnYzJDvF M3UvSv5bIEtG89BsRMYxnR2yBVC41UZvnQMmaFNNABJ8Yywo5u7yYTGjdD82YTXVyjdE WMgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725573490; x=1726178290; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=debuxuNcW7Vau/i5ri1+uD5qWokdP8/oPSvRGMK4Oy4=; b=Doij60iKJKFvLSigbNez4jc4+1nARy6PO+czDdEsO+vr8sl9mCw85Fip0PCFJKH/+u FEJVbhO3kKdVM4ocQQ62Ukk7ggiN0aRrQ386/mutzRiTB6S40Yy5yQQ7LRLunmz1/1TH JGXPAIMa+tK2Pwzs2QIwansNeY7lMwsW1Zb9klQtjQ2Qu0EBRSGQwXkctWPM9pWbzSma pG83S4lY9hg1vlJkI7dHG9acWuh34ulAHhtzQY4RIDrU0DdRzJmRTYExxwtFRVZUxse5 t5qpuKSrpBNfbxoQuUpllPphwfDr+1WFRBj+JpPilyaZAGCq3yXFoYG4iI2RA+RpwnCe sWdg== X-Forwarded-Encrypted: i=1; AJvYcCXDHVIhHaOopuDc9Hkx84IVpV0BlIf/1xHNHM5ZePGvM4tSI1mYaAleuHrWSSV0n83vEKQA4TVaYYKBMTZAhkx+@lists.infradead.org X-Gm-Message-State: AOJu0Yyj9XDoDZxnCkcr1Hm1v/m0pMcUuTaTCH/gKU7vWh7RXTGKHO9q ceF93U4HN3NGT8YeYQuO+5oQzS3k5lHRCKDqzViwhf83QeynKbtvFeNnRrbD+co= X-Google-Smtp-Source: AGHT+IGTshBMlJFlXsC+frdPM3BZscmeS6VUJgi2fVQqYwOBl4sze3V53Rb4d0wn1FbyDqYcOILusQ== X-Received: by 2002:a17:90a:f48e:b0:2d8:7a3b:730d with SMTP id 98e67ed59e1d1-2dad501408fmr847011a91.21.1725573490526; Thu, 05 Sep 2024 14:58:10 -0700 (PDT) Received: from localhost ([71.212.170.185]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2dadbff3c6dsm6637a91.3.2024.09.05.14.58.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2024 14:58:10 -0700 (PDT) From: Kevin Hilman To: Ulf Hansson Cc: linux-pm@vger.kernel.org, Nishanth Menon , Vibhore Vardhan , Dhruva Gole , Akashdeep Kaur , Sebin Francis , Markus Schneider-Pargmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] pmdomain: ti_sci: add wakeup constraint management In-Reply-To: References: <20240819-lpm-v6-10-constraints-pmdomain-v2-0-461325a6008f@baylibre.com> <20240819-lpm-v6-10-constraints-pmdomain-v2-2-461325a6008f@baylibre.com> Date: Thu, 05 Sep 2024 14:58:09 -0700 Message-ID: <7hseudahla.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240905_145811_492447_E181DF8F X-CRM114-Status: GOOD ( 13.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ulf Hansson writes: > On Tue, 20 Aug 2024 at 02:00, Kevin Hilman wrote: >> >> During system-wide suspend, check all devices connected to PM domain >> to see if they are wakeup-enabled. If so, set a TI SCI device >> constraint. >> >> Note: DM firmware clears all constraints on resume. >> >> Co-developed-by: Vibhore Vardhan >> Signed-off-by: Vibhore Vardhan >> Signed-off-by: Kevin Hilman >> Signed-off-by: Dhruva Gole >> --- >> drivers/pmdomain/ti/ti_sci_pm_domains.c | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> >> diff --git a/drivers/pmdomain/ti/ti_sci_pm_domains.c b/drivers/pmdomain/ti/ti_sci_pm_domains.c >> index 963272fa387b..8af907579152 100644 >> --- a/drivers/pmdomain/ti/ti_sci_pm_domains.c >> +++ b/drivers/pmdomain/ti/ti_sci_pm_domains.c >> @@ -76,6 +76,23 @@ static int ti_sci_pd_set_lat_constraint(struct device *dev, s32 val) >> return ret; >> } >> >> +static inline bool ti_sci_pd_set_wkup_constraint(struct device *dev) >> +{ > > Similar comment as for patch1, should this be a static void intstead? > Yes, will do in v3. Kevin