From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6FD89EE3F39 for ; Tue, 12 Sep 2023 22:41:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mmTBikBFZ/bDjKHJXSQq09ShT5sBg8r8ZaZMDhd7YsA=; b=nemVXytZbUlSVL /gdEgEPoIL8Zg+86EIaPALPImJpMfrB3N+BZ3jTQcDx/bug41gzcJMPt+TRPm2xhfu8zXnpPdzSGt ULs8NYh1jL2lGLYmxjO6gZL5ZQIW+Vm7pr0topYdrx0WdAD8OaOYlbXmk75+4bDy+58G5zU3pd/t0 aulUjjZHZxTsIPlMvzC7GhGg2ZyoayvCiv911TKTeowLJKtxK3NFD9Km+JtpX+pM1AIg3OCSdvSPu P3AyjIxvnI3UJwq/u3VhDiEr8al/+HD/cW1EirSkz0sxC7QL+sm1uwfPzzMv4mPbXypW8pY1UPv8z u8fYJIsdYF3PAUXr10ZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qgC3k-004Cnd-0S; Tue, 12 Sep 2023 22:40:40 +0000 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qgC3f-004Cmk-12 for linux-arm-kernel@lists.infradead.org; Tue, 12 Sep 2023 22:40:38 +0000 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1c39f2b4f5aso22891755ad.0 for ; Tue, 12 Sep 2023 15:40:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1694558433; x=1695163233; darn=lists.infradead.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=n1O93Em0dGb2w1gcbLaR3b+qaKxj8ErGxsZztgFUmxE=; b=Ddl66DWJWGzTFgvMZwEMaL2Ty1tSJ9L9ENKbv00+ISDTQh9GevDwvxPEqVLT8X5NIl sEmOpD2XTgo/jGUmUGgmHtHC+vyrnVNvhkOyHTkN9iTAjPWH19QDSKO2G0tMim6WQnnT ffbIx5oCMq6wyhDYZJ6jfsMmkotSsgDlPC/NRnX4ug0GAipnPk3QMLwKRGU+59ZDQOK5 Ja2gpMowWrmEMmW17LSGxr/GmWYekGuMGa624VKK8duurPHPfumvuTKDLt1MV5wabyvq Wq6z1jcyJdMGeuxXKINMk6eqz68Kyk4oXIvlkuRsy0MW6NEhewDofWBop+mk7J/9JlfJ 89YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694558433; x=1695163233; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n1O93Em0dGb2w1gcbLaR3b+qaKxj8ErGxsZztgFUmxE=; b=wW091OftwDN2PGgpwi4vVd0szK2hOebb9AlNvx4XAo2fw86p38yb/3NvH3IeVzOikw XMR32CXRy/vh+1x9dXr0eeoX9f9rsY9EA0sR2x8q78RMrdXHU6+G0qnB8/6cAGzysksZ Jpiv1OFOlk9iNXAzP6w7ZZe/6CSNBA1Xu6sNImmGjRX+6l7o/BJRz99PFXOcnOCT5wNV r0osryCJfE/hBu1B0odraROAcciFumr0Y5vQvvOdL/A2rf8SiU/jyOOFBrdOcyJjL1i6 M0/rCswtdCP+IRlbpi2yqoj31ORprg5QcAY/N4RRnjyPVYHR5PkiqofrTY/AaHB1QiEj Utmw== X-Gm-Message-State: AOJu0YwJEno0hdjlA2VjONE0iEQqWbNy/OMJHaaXxfoKlZBhOElNRAyE LAhMMgQr8w3dyVlA3B/qF92NaO1UrHtJMhb/85U= X-Google-Smtp-Source: AGHT+IEJmsLAsW5l+VB/hOPMJJgw4AHIPmDee2zCHtRkWTNC/a9XAmGaVZj83Hcxw7dHfLY1DzqAdQ== X-Received: by 2002:a17:903:22c3:b0:1bb:59a0:3d34 with SMTP id y3-20020a17090322c300b001bb59a03d34mr1264418plg.30.1694558433268; Tue, 12 Sep 2023 15:40:33 -0700 (PDT) Received: from localhost (71-212-56-62.tukw.qwest.net. [71.212.56.62]) by smtp.gmail.com with ESMTPSA id l12-20020a170902eb0c00b001bf574dd1fesm8943675plb.141.2023.09.12.15.40.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 15:40:32 -0700 (PDT) From: Kevin Hilman To: Dhruva Gole , Tony Lindgren Cc: linux-omap@vger.kernel.org, Greg Kroah-Hartman , Keerthy , Nishanth Menon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, vibhore@ti.com Subject: Re: [PATCH] bus: ti-sysc: Fix SYSC_QUIRK_SWSUP_SIDLE_ACT handling for uart wake-up In-Reply-To: <20230907062231.muwzvje726wlqnqw@dhruva.dhcp.ti.com> References: <20230907055441.19476-1-tony@atomide.com> <20230907062231.muwzvje726wlqnqw@dhruva.dhcp.ti.com> Date: Tue, 12 Sep 2023 15:40:31 -0700 Message-ID: <7hsf7j582o.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230912_154035_582834_FD7C7D9A X-CRM114-Status: GOOD ( 19.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dhruva Gole writes: > On Sep 07, 2023 at 08:54:41 +0300, Tony Lindgren wrote: >> The uarts should be tagged with SYSC_QUIRK_SWSUP_SIDLE instead of >> SYSC_QUIRK_SWSUP_SIDLE_ACT. The difference is that SYSC_QUIRK_SWSUP_SIDLE >> is used to force idle target modules rather than block idle during usage. >> >> The SYSC_QUIRK_SWSUP_SIDLE_ACT should disable autoidle and wake-up when >> a target module is active, and configure autoidle and wake-up when a >> target module is inactive. We are missing configuring the target module >> on sysc_disable_module(), and missing toggling of the wake-up bit. >> >> Let's fix the issue to allow uart wake-up to work. >> >> Fixes: fb685f1c190e ("bus: ti-sysc: Handle swsup idle mode quirks") >> Signed-off-by: Tony Lindgren >> --- >> drivers/bus/ti-sysc.c | 22 +++++++++++++++++----- >> 1 file changed, 17 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c >> --- a/drivers/bus/ti-sysc.c >> +++ b/drivers/bus/ti-sysc.c > > Thanks for the fix Tony, > I have tested this on a TI SK-AM62x with deepsleep and am able to wakeup > with keypress on the wake_uart. > > For anyone else who wants to give this a shot, the required patches for > deepsleep and DT related changes have been pushed to my branch on github > [0]. > > Hence, > Tested-by: Dhruva Gole > > [0] https://github.com/DhruvaG2000/v-linux/commits/v6.5-rc7_wkuart Also tested on k3-am625-sk using Dhruval's branch. Tested-by: Kevin Hilman Kevin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel