From: khilman@linaro.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: EXYNOS: mcpm: Don't rely on firmware's secondary_cpu_start
Date: Mon, 09 Jun 2014 11:09:02 -0700 [thread overview]
Message-ID: <7htx7uq7k1.fsf@paris.lan> (raw)
In-Reply-To: <1402096465-13218-1-git-send-email-dianders@chromium.org> (Doug Anderson's message of "Fri, 6 Jun 2014 16:14:25 -0700")
Doug Anderson <dianders@chromium.org> writes:
> On exynos mcpm systems the firmware is hardcoded to jump to an address
> in SRAM (0x02073000) when secondary CPUs come up. By default the
> firmware puts a bunch of code at that location. That code expects the
> kernel to fill in a few slots with addresses that it uses to jump back
> to the kernel's entry point for secondary CPUs.
>
> Originally (on prerelease hardware) this firmware code contained a
> bunch of workarounds to deal with boot ROM bugs. However on all
> shipped hardware we simply use this code to redirect to a kernel
> function for bringing up the CPUs.
>
> Let's stop relying on the code provided by the bootloader and just
> plumb in our own (simple) code jump to the kernel. This has the nice
> benefit of fixing problems due to the fact that older bootloaders
> (like the one shipped on the Samsung Chromebook 2) might have put
> slightly different code into this location.
>
> Once suspend/resume is implemented for systems using exynos-mcpm we'll
> need to make sure we reinstall our fixed up code after resume. ...but
> that's not anything new since IRAM (and thus the address of the
> mcpm_entry_point) is lost across suspend/resume anyway.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
Acked-by: Kevin Hilman <khilman@linaro.org>
Tested-by: Kevin Hilman <khilman@linaro.org>
I confirm that this patch (plus the enable CCI hack[1]) allows me to see
all 8 cores when booting linux-next on my Chromebook2.
Kevin
[1] While waiting for the forth-coming patch from Andrew to enable the
CCI port for the boot cluster), I do this from u-boot before starting
the kernel (based on earlier email from Doug):
mw.l 10d25000 3 # Enable CCI from U-Boot
next prev parent reply other threads:[~2014-06-09 18:09 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 21:43 [PATCH] ARM: EXYNOS: mcpm: Don't rely on firmware's secondary_cpu_start Doug Anderson
2014-06-06 22:35 ` Nicolas Pitre
2014-06-06 22:43 ` Doug Anderson
2014-06-06 22:46 ` Andrew Bresticker
2014-06-06 23:14 ` [PATCH v2] " Doug Anderson
2014-06-07 1:34 ` Nicolas Pitre
2014-06-09 18:09 ` Kevin Hilman [this message]
2014-06-09 20:05 ` Andrew Bresticker
2014-06-09 20:22 ` Nicolas Pitre
2014-06-09 20:35 ` Kevin Hilman
2014-06-09 20:55 ` Nicolas Pitre
2014-06-16 18:37 ` Doug Anderson
2014-06-16 18:47 ` Nicolas Pitre
2014-06-07 18:12 ` [PATCH] " Lorenzo Pieralisi
2014-06-09 17:03 ` Doug Anderson
2014-06-09 22:38 ` Lorenzo Pieralisi
2014-06-10 8:12 ` Chander Kashyap
2014-06-10 15:21 ` Doug Anderson
2014-06-10 15:49 ` Nicolas Pitre
2014-06-11 4:52 ` Chander Kashyap
2014-06-11 10:13 ` Lorenzo Pieralisi
2014-06-11 12:14 ` Chander Kashyap
2014-06-11 13:15 ` Lorenzo Pieralisi
2014-06-11 13:29 ` Chander Kashyap
2014-06-11 13:34 ` Abhilash Kesavan
2014-06-11 15:19 ` Doug Anderson
2014-06-11 15:28 ` Kukjin Kim
2014-06-13 11:54 ` Chander Kashyap
2014-06-13 13:29 ` Nicolas Pitre
2014-06-13 15:10 ` Doug Anderson
2014-06-16 7:40 ` Chander Kashyap
2014-06-16 18:35 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7htx7uq7k1.fsf@paris.lan \
--to=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).